Re: [webkit-dev] Reformatting-only patches being applied to trunk

2009-07-26 Thread David Levin
On Sat, Jul 25, 2009 at 4:11 PM, Ojan Vafai o...@chromium.org wrote: We could also hook [the style checker] into any create-patch scripts so that patches [from] (new) contributors upload don't need to be manually vetted by a reviewer for style. This could be done without making all code

[webkit-dev] Reformatting-only patches being applied to trunk

2009-07-25 Thread Oliver Hunt
I've just noticed that there have been a few purely style related patches being landed in the tree recently, I don't believe these are a good idea and that any further reformatting only patches be rejected. Historically we have avoided purely style related changes as they impact our

Re: [webkit-dev] Reformatting-only patches being applied to trunk

2009-07-25 Thread Maciej Stachowiak
On Jul 25, 2009, at 2:08 AM, Oliver Hunt wrote: I've just noticed that there have been a few purely style related patches being landed in the tree recently, I don't believe these are a good idea and that any further reformatting only patches be rejected. Historically we have avoided

Re: [webkit-dev] Reformatting-only patches being applied to trunk

2009-07-25 Thread George Staikos
On 25-Jul-09, at 6:46 AM, Maciej Stachowiak wrote: On Jul 25, 2009, at 2:08 AM, Oliver Hunt wrote: I've just noticed that there have been a few purely style related patches being landed in the tree recently, I don't believe these are a good idea and that any further reformatting only

Re: [webkit-dev] Reformatting-only patches being applied to trunk

2009-07-25 Thread Nikolas Zimmermann
Am 25.07.2009 um 10:08 schrieb Oliver Hunt: I've just noticed that there have been a few purely style related patches being landed in the tree recently, I don't believe these are a good idea and that any further reformatting only patches be rejected. Hm, I don't share your opinion here.

Re: [webkit-dev] Reformatting-only patches being applied to trunk

2009-07-25 Thread David Hyatt
On Jul 25, 2009, at 3:08 AM, Oliver Hunt wrote: I've just noticed that there have been a few purely style related patches being landed in the tree recently, I don't believe these are a good idea and that any further reformatting only patches be rejected. I completely disagree. I see

Re: [webkit-dev] Reformatting-only patches being applied to trunk

2009-07-25 Thread Ojan Vafai
On Sat, Jul 25, 2009 at 4:39 PM, David Hyatt hy...@apple.com wrote: On Jul 25, 2009, at 3:08 AM, Oliver Hunt wrote: I've just noticed that there have been a few purely style related patches being landed in the tree recently, I don't believe these are a good idea and that any further