Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

2012-06-04 Thread Balazs Kelemen
On 06/04/2012 03:10 AM, Ryosuke Niwa wrote: On Sun, Jun 3, 2012 at 6:01 PM, Adam Barth aba...@webkit.org mailto:aba...@webkit.org wrote: On Sun, Jun 3, 2012 at 5:54 PM, Ryosuke Niwa rn...@webkit.org mailto:rn...@webkit.org wrote: On Sun, Jun 3, 2012 at 5:33 PM, Maciej

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

2012-06-04 Thread Sam Weinig
On Jun 3, 2012, at 6:10 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sun, Jun 3, 2012 at 6:01 PM, Adam Barth aba...@webkit.org wrote: On Sun, Jun 3, 2012 at 5:54 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sun, Jun 3, 2012 at 5:33 PM, Maciej Stachowiak m...@apple.com wrote: On Jun 3, 2012, at

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

2012-06-04 Thread Adam Barth
On Mon, Jun 4, 2012 at 10:51 AM, Sam Weinig wei...@apple.com wrote: On Jun 3, 2012, at 6:10 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sun, Jun 3, 2012 at 6:01 PM, Adam Barth aba...@webkit.org wrote: On Sun, Jun 3, 2012 at 5:54 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sun, Jun 3, 2012

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

2012-06-04 Thread Sam Weinig
On Jun 4, 2012, at 11:07 AM, Adam Barth aba...@webkit.org wrote: On Mon, Jun 4, 2012 at 10:51 AM, Sam Weinig wei...@apple.com wrote: On Jun 3, 2012, at 6:10 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sun, Jun 3, 2012 at 6:01 PM, Adam Barth aba...@webkit.org wrote: On Sun, Jun 3, 2012 at

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

2012-06-04 Thread Ryosuke Niwa
On Sun, Jun 3, 2012 at 6:01 PM, Adam Barth aba...@webkit.org wrote: On Sun, Jun 3, 2012 at 5:54 PM, Ryosuke Niwa rn...@webkit.org wrote: Are you referring to things like JSValueRef? If JS* functions are supposed to be tested in DumpRenderTree, then that's a good argument against this

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

2012-06-03 Thread Ryosuke Niwa
On Sat, Jun 2, 2012 at 8:04 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sat, Jun 2, 2012 at 8:03 PM, Adam Barth aba...@webkit.org wrote: We might also want to define the layoutTestController object with IDL so we don't have to hand-write bindings every time we change it. Using IDL for

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

2012-06-03 Thread Maciej Stachowiak
Already done for the WebKit2 WebKitTestRunner. It should be straightforward to adapt its IDL compiler. - Maciej On Jun 2, 2012, at 11:03 PM, Adam Barth aba...@webkit.org wrote: We might also want to define the layoutTestController object with IDL so we don't have to hand-write bindings

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

2012-06-03 Thread Maciej Stachowiak
I am on vacation so I won't be able to review your patch in detail, but from your description it sounds less appealing to me than the WKTR approach. It seems like bad layering to me to define the IDL interface in WebCore for something actually implemented completely outside of WebCore. It also

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

2012-06-03 Thread Ryosuke Niwa
On Sun, Jun 3, 2012 at 3:55 PM, Maciej Stachowiak m...@apple.com wrote: I am on vacation so I won't be able to review your patch in detail, but from your description it sounds less appealing to me than the WKTR approach. It seems like bad layering to me to define the IDL interface in WebCore

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

2012-06-03 Thread Maciej Stachowiak
Sent from my iPad On Jun 3, 2012, at 8:05 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sun, Jun 3, 2012 at 3:55 PM, Maciej Stachowiak m...@apple.com wrote: I am on vacation so I won't be able to review your patch in detail, but from your description it sounds less appealing to me than the

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

2012-06-03 Thread Ryosuke Niwa
On Sun, Jun 3, 2012 at 5:33 PM, Maciej Stachowiak m...@apple.com wrote: On Jun 3, 2012, at 8:05 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sun, Jun 3, 2012 at 3:55 PM, Maciej Stachowiak m...@apple.com wrote: I am on vacation so I won't be able to review your patch in detail, but from your

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

2012-06-03 Thread Adam Barth
On Sun, Jun 3, 2012 at 5:54 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sun, Jun 3, 2012 at 5:33 PM, Maciej Stachowiak m...@apple.com wrote: On Jun 3, 2012, at 8:05 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sun, Jun 3, 2012 at 3:55 PM, Maciej Stachowiak m...@apple.com wrote: I am on

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

2012-06-03 Thread Ryosuke Niwa
On Sun, Jun 3, 2012 at 6:01 PM, Adam Barth aba...@webkit.org wrote: On Sun, Jun 3, 2012 at 5:54 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sun, Jun 3, 2012 at 5:33 PM, Maciej Stachowiak m...@apple.com wrote: On Jun 3, 2012, at 8:05 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sun, Jun 3,

[webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

2012-06-02 Thread Ryosuke Niwa
Hi, One thing that has annoyed me ever since I started working on WebKit is that our test runner is called DumpRenderTree. We fixed this problem in WebKit2 by renaming it to WebKitTestRunner but we've still got DumpRenderTree in WebKit1 land. Can we either rename DumpRenderTree to

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

2012-06-02 Thread Adam Barth
We might also want to define the layoutTestController object with IDL so we don't have to hand-write bindings every time we change it. Using IDL for window.internals seems to have worked out well. It would be nice to replicate that success with layoutTestController. Adam On Sat, Jun 2, 2012 at

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

2012-06-02 Thread Ryosuke Niwa
On Sat, Jun 2, 2012 at 8:03 PM, Adam Barth aba...@webkit.org wrote: We might also want to define the layoutTestController object with IDL so we don't have to hand-write bindings every time we change it. Using IDL for window.internals seems to have worked out well. It would be nice to