Re: [webkit-dev] Some thoughts about platform flags

2008-09-25 Thread Amanda Walker
On Thu, Sep 25, 2008 at 2:27 AM, Eric Seidel <[EMAIL PROTECTED]> wrote: > p.p.s. I should also note that Amanda is currently focused on the Mac > port, while changes you've seen from myself and others are about our > Windows port. We owe you a lot of Windows code yet, but Amanda's > primary conce

Re: [webkit-dev] Some thoughts about platform flags

2008-09-24 Thread Eric Seidel
Sam and I talked about this at length over coffee this evening. He and I agreed, this conversation should be less about #ifdefs and more about abstractions. I'm sure I'm clear on which abstractions we need for Chromium (beyond ScriptController, and GraphicsContext), certainly not as clear as Dari

Re: [webkit-dev] Some thoughts about platform flags

2008-09-24 Thread Darin Fisher
On Wed, Sep 24, 2008 at 10:44 PM, Maciej Stachowiak <[EMAIL PROTECTED]> wrote: > > On Sep 24, 2008, at 10:10 PM, Amanda Walker wrote: > > On Wed, Sep 24, 2008 at 7:25 PM, Maciej Stachowiak <[EMAIL PROTECTED]> wrote: >> >>> On Sep 24, 2008, at 3:36 PM, Darin Fisher wrote: >>> I don't think an

Re: [webkit-dev] Some thoughts about platform flags

2008-09-24 Thread Maciej Stachowiak
On Sep 24, 2008, at 10:10 PM, Amanda Walker wrote: > On Wed, Sep 24, 2008 at 7:25 PM, Maciej Stachowiak <[EMAIL PROTECTED]> > wrote: >> On Sep 24, 2008, at 3:36 PM, Darin Fisher wrote: >>> I don't think anything about our port implies hosted in a rendering >>> subprocess. Our port works perfec

Re: [webkit-dev] Some thoughts about platform flags

2008-09-24 Thread Amanda Walker
On Wed, Sep 24, 2008 at 7:25 PM, Maciej Stachowiak <[EMAIL PROTECTED]> wrote: > On Sep 24, 2008, at 3:36 PM, Darin Fisher wrote: > > I don't think anything about our port implies hosted in a rendering > > subprocess. Our port works perfectly well in a single process traditional > > browser model.

Re: [webkit-dev] Some thoughts about platform flags

2008-09-24 Thread Amanda Walker
On Wed, Sep 24, 2008 at 7:22 PM, Maciej Stachowiak <[EMAIL PROTECTED]> wrote: > Do you guys have cross-process rendering working on Mac yet, even as a > prototype? I am wondering if these statements about what is required to do > it have been tested or are just assumptions. We have working proofs

Re: [webkit-dev] Some thoughts about platform flags

2008-09-24 Thread Maciej Stachowiak
On Sep 24, 2008, at 5:03 PM, Eric Seidel wrote: > I think this is best discussed as individual patches. I would > encourage Amanda (and others) to make patches as necessary and mark > them for review. I think it's worth discussing the plan a bit up front. Not endlessly, but enough so that rev

Re: [webkit-dev] Some thoughts about platform flags

2008-09-24 Thread Eric Seidel
I think this is best discussed as individual patches. I would encourage Amanda (and others) to make patches as necessary and mark them for review. I would also encourage the rest of WebKit to be rather lenient about getting these #ifdefs into our source. I think that the benefit of getting all o

Re: [webkit-dev] Some thoughts about platform flags

2008-09-24 Thread Darin Fisher
[resent, doh... that's it, i'm registering my other email address] On Wed, Sep 24, 2008 at 4:32 PM, Darin Fisher <[EMAIL PROTECTED]> wrote: > On Wed, Sep 24, 2008 at 4:22 PM, Maciej Stachowiak <[EMAIL PROTECTED]> wrote: > >> >> On Sep 24, 2008, at 3:30 PM, Amanda Walker wrote: >> >> > >> > The re

Re: [webkit-dev] Some thoughts about platform flags

2008-09-24 Thread Maciej Stachowiak
On Sep 24, 2008, at 3:36 PM, Darin Fisher wrote: On Wed, Sep 24, 2008 at 2:16 PM, Maciej Stachowiak <[EMAIL PROTECTED]> wrote: On Sep 24, 2008, at 12:14 PM, Amanda Walker wrote: Hello all, A conversation started on https://bugs.webkit.org/show_bug.cgi?id=20890 that Alexey suggested movi

Re: [webkit-dev] Some thoughts about platform flags

2008-09-24 Thread Maciej Stachowiak
On Sep 24, 2008, at 3:30 PM, Amanda Walker wrote: > > The renderer process will be using CoreText, CG, some Cocoa, etc., but > using the Apple WebView sitting inside an NSScrollView which is in > turn inside an NSWindow--we must introduce a proxy, since remoting > NSView or NSWindow over DO doesn

Re: [webkit-dev] Some thoughts about platform flags

2008-09-24 Thread Darin Fisher
[resent from an address mailman knows about] On Wed, Sep 24, 2008 at 3:36 PM, Darin Fisher <[EMAIL PROTECTED]> wrote: > On Wed, Sep 24, 2008 at 2:16 PM, Maciej Stachowiak <[EMAIL PROTECTED]> wrote: > >> >> On Sep 24, 2008, at 12:14 PM, Amanda Walker wrote: >> >> Hello all, >> A conversation start

Re: [webkit-dev] Some thoughts about platform flags

2008-09-24 Thread Amanda Walker
On Wed, Sep 24, 2008 at 5:53 PM, Darin Adler <[EMAIL PROTECTED]> wrote: > I think that despite its short pithy name that seems to refer to only a type > of computer, the Mac suffix and PLATFORM(MAC) doesn't mean "code that runs > on Mac OS X". In my opinion it doesn't mean "Apple's Mac port" either

Re: [webkit-dev] Some thoughts about platform flags

2008-09-24 Thread Amanda Walker
On Wed, Sep 24, 2008 at 5:16 PM, Maciej Stachowiak <[EMAIL PROTECTED]> wrote: > 1) PLATFORM macros should primarily be about use of particular underlying > libraries technologies that a port sits on top of. This is where things get a little messy (at least in their current usage), but it makes goo

Re: [webkit-dev] Some thoughts about platform flags

2008-09-24 Thread Darin Adler
On Sep 24, 2008, at 3:17 PM, David Kilzer wrote: > Would replacing PLATFORM(MAC) with PLATFORM(COCOA) make more sense > (in some cases)? There are two separate issues. Naturally, we could rename MAC to COCOA, and without commenting on whether I think that's a good change — if we did it we'd

Re: [webkit-dev] Some thoughts about platform flags

2008-09-24 Thread David Kilzer
On Wed, 9/24/08, Darin Adler <[EMAIL PROTECTED]> wrote: > PS: We could also consider coming up with a new name for > PLATFORM(MAC) > or PLATFORM(WIN) that expresses this more clearly. > That's a challenge, > but I wouldn't rule out changing the name for clarity > if we can come > up with som

Re: [webkit-dev] Some thoughts about platform flags

2008-09-24 Thread Darin Adler
On Sep 24, 2008, at 1:11 PM, Amanda Walker wrote: > ScrollView, where we will want to not define or call > ScrollView::getDocumentView() even though PLATFORM(MAC) is defined. > Our initial approach is to change the #if in ScrollView.h to add "&& > !PLATFORM(CHROMIUM)" (and then have a differen

Re: [webkit-dev] Some thoughts about platform flags

2008-09-24 Thread Maciej Stachowiak
On Sep 24, 2008, at 12:14 PM, Amanda Walker wrote: Hello all, A conversation started on https://bugs.webkit.org/show_bug.cgi?id=20890 that Alexey suggested moving to webkit-dev, so here we go :-). One of the things we ran into when bringing up the Chromium application architecture was th

Re: [webkit-dev] Some thoughts about platform flags

2008-09-24 Thread Amanda Walker
On Wed, Sep 24, 2008 at 3:35 PM, Darin Adler <[EMAIL PROTECTED]> wrote: > > It's really hard to usefully discuss this in the abstract. Can we start with > a particular example where PLATFORM(CHROMIUM) is being used, but where the > code in question is really more of a "don't crawl a view hierarch

Re: [webkit-dev] Some thoughts about platform flags

2008-09-24 Thread Darin Adler
It's really hard to usefully discuss this in the abstract. Can we start with a particular example where PLATFORM(CHROMIUM) is being used, but where the code in question is really more of a "don't crawl a view hierarchy" change rather than a truly Chromium-specific change? -- Darin

[webkit-dev] Some thoughts about platform flags

2008-09-24 Thread Amanda Walker
Hello all, A conversation started on https://bugs.webkit.org/show_bug.cgi?id=20890 that Alexey suggested moving to webkit-dev, so here we go :-). One of the things we ran into when bringing up the Chromium application architecture was that we needed to distinguish between "platform" and "applicati