Re: [webkit-dev] Subpixel Layout Update

2012-02-23 Thread Levi Weintraub
On Wed, Feb 22, 2012 at 6:15 PM, Dirk Schulze wrote: > > On Feb 21, 2012, at 10:13 AM, Levi Weintraub wrote: > > Hi Dirk, > > Inline: > > On Sat, Feb 18, 2012 at 9:44 PM, Dirk Schulze wrote: > >> Hi Emil and Levi, >> >> I have a question to sub pixels from the SVG point of view. >> >> Right now

Re: [webkit-dev] Subpixel Layout Update

2012-02-22 Thread Dirk Schulze
On Feb 21, 2012, at 10:13 AM, Levi Weintraub wrote: Hi Dirk, Inline: On Sat, Feb 18, 2012 at 9:44 PM, Dirk Schulze mailto:dschu...@adobe.com>> wrote: Hi Emil and Levi, I have a question to sub pixels from the SVG point of view. Right now a lot of content on renderers and also in RenderStyle

Re: [webkit-dev] Subpixel Layout Update

2012-02-21 Thread Levi Weintraub
You're right, those are obsolete. We'll get those removed. On Tue, Feb 21, 2012 at 10:37 AM, David Hyatt wrote: > I had a question about the subpixel layout stuff. Right now RenderBlock is > full of comments talking about switching to floats, .e.g., > > > FIXME: Might need rounding once we swit

Re: [webkit-dev] Subpixel Layout Update

2012-02-21 Thread David Hyatt
I had a question about the subpixel layout stuff. Right now RenderBlock is full of comments talking about switching to floats, .e.g., FIXME: Might need rounding once we switch to float, see https://bugs.webkit.org/show_bug.cgi?id=64021 FIXME: Change to use roughlyEquals when we mo

Re: [webkit-dev] Subpixel Layout Update

2012-02-21 Thread Levi Weintraub
Hi Dirk, Inline: On Sat, Feb 18, 2012 at 9:44 PM, Dirk Schulze wrote: > Hi Emil and Levi, > > I have a question to sub pixels from the SVG point of view. > > Right now a lot of content on renderers and also in RenderStyle uses > LayoutPoint, LayoutSize, LayoutRect, Length… and so on. How would

[webkit-dev] Subpixel Layout Update

2012-02-18 Thread Dirk Schulze
Hi Emil and Levi, I have a question to sub pixels from the SVG point of view. Right now a lot of content on renderers and also in RenderStyle uses LayoutPoint, LayoutSize, LayoutRect, Length… and so on. How would LayoutUnit deal with SVG's "float system"? Your Wiki says that SVG's float system

Re: [webkit-dev] Subpixel Layout Update

2012-02-12 Thread Robert O'Callahan
Cool! FYI, your formula for enclosingIntRect is wrong. Consider, e.g., x=0.4 and width=0.7. Also, in pixelSnappedIntRect, you need to ensure that your rounding function doesn't round towards (or away from) 0. See http://robert.ocallahan.org/2008/02/rounding-towards-or-away-from-zero_12.html. In p

Re: [webkit-dev] Subpixel Layout Update

2012-02-11 Thread Ojan Vafai
On Fri, Feb 10, 2012 at 6:14 PM, Adam Barth wrote: > On Fri, Feb 10, 2012 at 6:09 PM, Levi Weintraub wrote: > > On Fri, Feb 10, 2012 at 6:03 PM, Adam Barth wrote: > >> > >> On Fri, Feb 10, 2012 at 5:49 PM, Levi Weintraub > wrote: > >> > WebKittens, > >> > > >> > We're planning to wrap up our c

Re: [webkit-dev] Subpixel Layout Update

2012-02-11 Thread Simon Fraser
On Feb 11, 2012, at 2:49 AM, Levi Weintraub wrote: > WebKittens, > > We're planning to wrap up our conversion of the RenderTree to subpixel units > next week. We've created a the following wiki page to help explain the > changes we are making: https://trac.webkit.org/wiki/LayoutUnit If you work

Re: [webkit-dev] Subpixel Layout Update

2012-02-10 Thread Emil A Eklund
> I meant it would let us update the PNGs once instead of twice. Ah, that's a good point. We're "only" touching about 500 pixel tests so it wouldn't be too bad if we had to do it twice. Might be nice to avoid though. ___ webkit-dev mailing list webkit-de

Re: [webkit-dev] Subpixel Layout Update

2012-02-10 Thread Adam Barth
On Fri, Feb 10, 2012 at 6:22 PM, Levi Weintraub wrote: > On Fri, Feb 10, 2012 at 6:14 PM, Adam Barth wrote: >> >> On Fri, Feb 10, 2012 at 6:09 PM, Levi Weintraub wrote: >> > On Fri, Feb 10, 2012 at 6:03 PM, Adam Barth wrote: >> >> >> >> On Fri, Feb 10, 2012 at 5:49 PM, Levi Weintraub >> >> wro

Re: [webkit-dev] Subpixel Layout Update

2012-02-10 Thread Levi Weintraub
On Fri, Feb 10, 2012 at 6:14 PM, Adam Barth wrote: > On Fri, Feb 10, 2012 at 6:09 PM, Levi Weintraub wrote: > > On Fri, Feb 10, 2012 at 6:03 PM, Adam Barth wrote: > >> > >> On Fri, Feb 10, 2012 at 5:49 PM, Levi Weintraub > wrote: > >> > WebKittens, > >> > > >> > We're planning to wrap up our c

Re: [webkit-dev] Subpixel Layout Update

2012-02-10 Thread Adam Barth
On Fri, Feb 10, 2012 at 6:09 PM, Levi Weintraub wrote: > On Fri, Feb 10, 2012 at 6:03 PM, Adam Barth wrote: >> >> On Fri, Feb 10, 2012 at 5:49 PM, Levi Weintraub wrote: >> > WebKittens, >> > >> > We're planning to wrap up our conversion of the RenderTree to subpixel >> > units >> > next week. We

Re: [webkit-dev] Subpixel Layout Update

2012-02-10 Thread Levi Weintraub
On Fri, Feb 10, 2012 at 6:03 PM, Adam Barth wrote: > On Fri, Feb 10, 2012 at 5:49 PM, Levi Weintraub wrote: > > WebKittens, > > > > We're planning to wrap up our conversion of the RenderTree to subpixel > units > > next week. We've created a the following wiki page to help explain the > > change

Re: [webkit-dev] Subpixel Layout Update

2012-02-10 Thread Adam Barth
On Fri, Feb 10, 2012 at 5:49 PM, Levi Weintraub wrote: > WebKittens, > > We're planning to wrap up our conversion of the RenderTree to subpixel units > next week. We've created a the following wiki page to help explain the > changes we are making: https://trac.webkit.org/wiki/LayoutUnit If you wor

Re: [webkit-dev] Subpixel Layout Update

2012-02-10 Thread Levi Weintraub
WebKittens, We're planning to wrap up our conversion of the RenderTree to subpixel units next week. We've created a the following wiki page to help explain the changes we are making: https://trac.webkit.org/wiki/LayoutUnit If you work on the rendering code, please take a look and talk to Emil and

Re: [webkit-dev] Subpixel Layout Update

2011-10-28 Thread Levi Weintraub
We've been pretty heavily in bug-fix mode recently, but it's been our intention to synchronize layout-unit usage in trunk to shrink down our patch for awhile now. On Fri, Oct 28, 2011 at 3:14 PM, Eric Seidel wrote: > It's not a big deal.  It just wasn't until I saw the diff in > prettydiff that I

Re: [webkit-dev] Subpixel Layout Update

2011-10-28 Thread Eric Seidel
It's not a big deal. It just wasn't until I saw the diff in prettydiff that I had any clue what the branch changes look like. After looking at the diff, it looks like you all should be able to easily merge most of your branch into trunk *today*. Much of it is changes we want regardless of whether

Re: [webkit-dev] Subpixel Layout Update

2011-10-28 Thread Emil A Eklund
On Fri, Oct 28, 2011 at 14:52, Eric Seidel wrote: > I've posted the current diff from the branch so that its easier to read. Thanks Eric, I'll make sure to update it periodically to make it easier to follow our progress. -- Emil ___ webkit-dev mailing

Re: [webkit-dev] Subpixel Layout Update

2011-10-28 Thread Eric Seidel
I've posted the current diff from the branch so that its easier to read. On Fri, Oct 28, 2011 at 2:45 PM, Levi Weintraub wrote: > Thanks Eric, > > I just created a meta bug to track issues found in the branch. Please > file issues as blocking bugs against 71143: > https://bugs.webkit.org/show_bug

Re: [webkit-dev] Subpixel Layout Update

2011-10-28 Thread Levi Weintraub
Thanks Eric, I just created a meta bug to track issues found in the branch. Please file issues as blocking bugs against 71143: https://bugs.webkit.org/show_bug.cgi?id=71143 -Levi On Fri, Oct 28, 2011 at 2:38 PM, Eric Seidel wrote: > Do you have a master bug we can CC ourselves on to follow alon

Re: [webkit-dev] Subpixel Layout Update

2011-10-28 Thread Emil A Eklund
On Fri, Oct 28, 2011 at 13:47, Eric Seidel wrote: > Most interesting is to see the branch diff.  Is that possible from the > web?  Could you tell me what the magic svn command is if it's not > possible? The easiest seems to be the following: svn diff --old http://svn.webkit.org/repository/webkit

Re: [webkit-dev] Subpixel Layout Update

2011-10-28 Thread Benjamin Poulain
On Fri, Oct 28, 2011 at 1:43 PM, Levi Weintraub wrote: > As you may know, Emil and I have been diligently working on getting > subpixel layout up and running in WebKit. After much testing, we > settled on a fixed point implementation instead of floats; we're happy > to discuss how we arrived at th

Re: [webkit-dev] Subpixel Layout Update

2011-10-28 Thread Eric Seidel
Most interesting is to see the branch diff. Is that possible from the web? Could you tell me what the magic svn command is if it's not possible? Thanks! On Fri, Oct 28, 2011 at 1:43 PM, Levi Weintraub wrote: > WebKittens, > > As you may know, Emil and I have been diligently working on getting

[webkit-dev] Subpixel Layout Update

2011-10-28 Thread Levi Weintraub
WebKittens, As you may know, Emil and I have been diligently working on getting subpixel layout up and running in WebKit. After much testing, we settled on a fixed point implementation instead of floats; we're happy to discuss how we arrived at this decision. We're currently in a state where we pa