Adam Barth wrote:
On Sat, Aug 1, 2009 at 1:13 PM, David Kilzerddkil...@webkit.org wrote:
Either we should change the review process to only set the review+ flag if the
patch is ready to go with zero modifications, or we should use the commit+ flag
to signify that.
I could go either way on
On Aug 1, 2009, at 8:41 PM, Adam Barth wrote:
On Sat, Aug 1, 2009 at 1:13 PM, David Kilzerddkil...@webkit.org
wrote:
Either we should change the review process to only set the review+
flag if the patch is ready to go with zero modifications, or we
should use the commit+ flag to signify
OK, per the discussion, I will add a commit-queue=? flag for Adam's testing.
If we like it, we can keep it. If not, we can kill it.
-eric
On Mon, Aug 3, 2009 at 9:43 AM, Maciej Stachowiak m...@apple.com wrote:
On Aug 1, 2009, at 8:41 PM, Adam Barth wrote:
On Sat, Aug 1, 2009 at 1:13 PM,
I've been experimenting with a wrapper for bugzilla-tool that runs in
a loop and tries to land patches [1]. Ideally, there would be enough
information in Bugzilla so I could kick off this script and make tea
while it does its thing. However, deciding whether a bug with an r+
patch is ready to be
I went through the queue tonight and manually marked the bugs as
commit-ready by adding [commit+] to their titles. This worked well,
except that it made the bug titles ugly. I think a better solution is
to have flag analogous to r+ which is commit+.
Adam, as I suggedted previously, bugzilla
On Sat, Aug 1, 2009 at 11:43 AM, tonikitoo (Antonio Gomes)
toniki...@gmail.com wrote:
I went through the queue tonight and manually marked the bugs as
commit-ready by adding [commit+] to their titles. This worked well,
except that it made the bug titles ugly. I think a better solution is
On Sat, Aug 1, 2009 at 8:43 AM, tonikitoo (Antonio
Gomes)toniki...@gmail.com wrote:
Adam, as I suggedted previously, bugzilla supports KEYWORDs, so that
would be a matter of adding a special support for bugs where patches
are ready to go in.
'checkin-needed' keyword would work , i believe.
On Saturday, August 1, 2009 10:16:39 AM, Adam Barth wrote:
On Sat, Aug 1, 2009 at 8:43 AM, tonikitoo (Antonio Gomes)wrote:
Adam, as I suggedted previously, bugzilla supports KEYWORDs, so that
would be a matter of adding a special support for bugs where patches
are ready to go in.
On Sat, Aug 1, 2009 at 11:04 AM, David Kilzerddkil...@webkit.org wrote:
Bugzilla has the ability to create additional 4-state flags at both the
attachment level and at the bug level. (Note that bugs.webkit.org does not
have bug-level flags enabled.)
For example, we could create a commit
On Sat, Aug 1, 2009 at 11:45 AM, Ojan Vafai o...@chromium.org wrote:
On Sat, Aug 1, 2009 at 2:08 PM, Adam Barth aba...@webkit.org wrote:
On Sat, Aug 1, 2009 at 11:04 AM, David Kilzerddkil...@webkit.org wrote:
Bugzilla has the ability to create additional 4-state flags at both the
attachment
On Saturday, August 1, 2009 11:45:43 AM, Ojan Vafai wrote:
On Sat, Aug 1, 2009 at 2:08 PM, Adam Barth aba...@webkit.org wrote:
On Sat, Aug 1, 2009 at 11:04 AM, David Kilzerddkil...@webkit.org wrote:
Bugzilla has the ability to create additional 4-state flags at
both the attachment level and at
On Sat, Aug 1, 2009 at 12:53 PM, Jeremy Orlowjor...@chromium.org wrote:
Btw, I see one downside to a commit queue: When you manually commit
something, you're supposed to watch the build bots for breakage. If the
submit queue is running all the tests on all the platforms then it doesn't
On Sat, Aug 1, 2009 at 1:13 PM, David Kilzerddkil...@webkit.org wrote:
Either we should change the review process to only set the review+ flag if
the patch is ready to go with zero modifications, or we should use the
commit+ flag to signify that.
I could go either way on this. I don't like
13 matches
Mail list logo
