Re: [webkit-dev] WebKit memory instrumentation

2012-07-27 Thread Dominik Röttsches
On 07/24/2012 01:09 AM, Yury Semikhatsky wrote: On Mon, Jul 23, 2012 at 11:21 PM, Ryosuke Niwa rn...@webkit.org mailto:rn...@webkit.org wrote: This is somewhat tangential but once we've solved this problem, can we expose the data via testRunner or internals object so that we may

Re: [webkit-dev] WebKit memory instrumentation

2012-07-27 Thread Zoltan Horvath
On Fri, 27 Jul 2012 09:53:43 +0200, Dominik Röttsches dominik.rottsc...@intel.com wrote: On 07/24/2012 01:09 AM, Yury Semikhatsky wrote: On Mon, Jul 23, 2012 at 11:21 PM, Ryosuke Niwa rn...@webkit.org wrote: This is

Re: [webkit-dev] WebKit memory instrumentation

2012-07-25 Thread Maciej Stachowiak
On Jul 25, 2012, at 2:08 AM, Yury Semikhatsky yu...@chromium.org wrote: On Tue, Jul 24, 2012 at 10:34 PM, Maciej Stachowiak m...@apple.com wrote: On Jul 24, 2012, at 12:39 AM, Yury Semikhatsky yu...@chromium.org wrote: On Tue, Jul 24, 2012 at 12:47 AM, Maciej Stachowiak

Re: [webkit-dev] WebKit memory instrumentation

2012-07-25 Thread Ilya Tikhonovsky
It turns out that clang has good API for plugins and a simple plugin for checking the instrumentation coverage contains ~200 loc. Thus the first option looks useless. Regards, Tim. On Wed, Jul 25, 2012 at 11:34 PM, Maciej Stachowiak m...@apple.com wrote: On Jul 25, 2012, at 2:08 AM, Yury

Re: [webkit-dev] WebKit memory instrumentation

2012-07-24 Thread Yury Semikhatsky
On Tue, Jul 24, 2012 at 12:47 AM, Maciej Stachowiak m...@apple.com wrote: On Jul 23, 2012, at 8:09 AM, Yury Semikhatsky yu...@chromium.org wrote: * First option we consider is to define a class with the same set of fields as the instrumented one, then have a compile time assert that size

Re: [webkit-dev] WebKit memory instrumentation

2012-07-24 Thread Allan Sandfeld Jensen
Hi This is very interesting. I have been trying to debug memory-comsumption lately as well, though I have used different methods: I guess this API is to make the data available in web-inspector right? I have gathered similar data using valgrind's massif which can tell you which objects have

Re: [webkit-dev] WebKit memory instrumentation

2012-07-24 Thread Maciej Stachowiak
On Jul 24, 2012, at 12:39 AM, Yury Semikhatsky yu...@chromium.org wrote: On Tue, Jul 24, 2012 at 12:47 AM, Maciej Stachowiak m...@apple.com wrote: On Jul 23, 2012, at 8:09 AM, Yury Semikhatsky yu...@chromium.org wrote: First option we consider is to define a class with the same

[webkit-dev] WebKit memory instrumentation

2012-07-23 Thread Yury Semikhatsky
*Hi WebKit, Almost all developers would like to know why the render process takes so much memory. We are trying to address this problem by providing an information on how much memory is consumed by some high-level WebKit parts(DOM, CSS, JavaScript etc) . Currently there is a real-time chart in

Re: [webkit-dev] WebKit memory instrumentation

2012-07-23 Thread Adam Barth
Is there no way to use the sizeof operator to help? That might not help if we restructure the data, but it would at least help us track the size of individual objects. Adam On Mon, Jul 23, 2012 at 8:09 AM, Yury Semikhatsky yu...@chromium.orgwrote: *Hi WebKit, Almost all developers would

Re: [webkit-dev] WebKit memory instrumentation

2012-07-23 Thread Andreas Kling
Hi guys, First off, this is a really neat addition for web and WebKit developers alike, so thanks for hacking it! We're already using the reference class with same size as original class pattern to guard against object size regression for some of our very high-volume objects. While that's fine

Re: [webkit-dev] WebKit memory instrumentation

2012-07-23 Thread Zoltan Horvath
Hi there, On Mon, 23 Jul 2012 17:09:19 +0200, Yury Semikhatsky yu...@chromium.org wrote: *Hi WebKit, Almost all developers would like to know why the render process takes so much memory. We are trying to address this problem by providing an information on how much memory is consumed by

Re: [webkit-dev] WebKit memory instrumentation

2012-07-23 Thread Zoltan Herczeg
Hi, parts(DOM, CSS, JavaScript etc) . Currently there is a real-time chart in Web Inspector that shows the render process memory broken down into several components: Unfortunately this part is removed by the mail server, and from webkit-dev archives, but as far as I remember (we measured

Re: [webkit-dev] WebKit memory instrumentation

2012-07-23 Thread Yury Semikhatsky
On Mon, Jul 23, 2012 at 8:07 PM, Zoltan Horvath zol...@webkit.org wrote: Hi there, On Mon, 23 Jul 2012 17:09:19 +0200, Yury Semikhatsky yu...@chromium.org wrote: *Hi WebKit, Almost all developers would like to know why the render process takes so much memory. We are trying to address

Re: [webkit-dev] WebKit memory instrumentation

2012-07-23 Thread Simon Fraser
On Jul 23, 2012, at 11:14 AM, Zoltan Herczeg zherc...@webkit.org wrote: Hi, parts(DOM, CSS, JavaScript etc) . Currently there is a real-time chart in Web Inspector that shows the render process memory broken down into several components: Unfortunately this part is removed by the mail

Re: [webkit-dev] WebKit memory instrumentation

2012-07-23 Thread Ryosuke Niwa
This is somewhat tangential but once we've solved this problem, can we expose the data via testRunner or internals object so that we may use it in our performance tests? It'll be very valuable to be able to monitor changes in these metrics. - Ryosuke

Re: [webkit-dev] WebKit memory instrumentation

2012-07-23 Thread Zoltan Horvath
On Mon, 23 Jul 2012 21:21:54 +0200, Ryosuke Niwa rn...@webkit.org wrote:This is somewhat tangential but once we've solved this problem, can we expose the data via testRunner or internals object so that we may use it in our performance tests? It'll be very valuable to be able to monitor changes in

Re: [webkit-dev] WebKit memory instrumentation

2012-07-23 Thread Maciej Stachowiak
On Jul 23, 2012, at 8:09 AM, Yury Semikhatsky yu...@chromium.org wrote: First option we consider is to define a class with the same set of fields as the instrumented one, then have a compile time assert that size of the reference class equals to the size of the instrumented one. See

Re: [webkit-dev] WebKit memory instrumentation

2012-07-23 Thread Yury Semikhatsky
On Mon, Jul 23, 2012 at 11:21 PM, Ryosuke Niwa rn...@webkit.org wrote: This is somewhat tangential but once we've solved this problem, can we expose the data via testRunner or internals object so that we may use it in our performance tests? It'll be very valuable to be able to monitor changes