Another angle to attack this problem from is to make our OOPS system
less confusing. New committers are very often confused as to what
OOPS is or does. I made an attempt to make our changelog template
more explanatory at one point, but perhaps someone could make a better
one.
In either case, the
The code is here:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py#L38
The original bug is here:
https://bugs.webkit.org/show_bug.cgi?id=26927
"unreviewed" (or similar text) serves to differentiate between the
case where someone just mangled the "Reviewed
On Thu, Mar 3, 2011 at 11:58 PM, Ojan Vafai wrote:
> This isn't a big deal either way, but I noticed
> that http://trac.webkit.org/wiki/CommitterTips#Walkingyouthroughyourfirstcommit
> lists the following as the process for unreviewed commits: "Unreviewed
> commits should include a line saying "Un
On Mar 3, 2011, at 11:58 PM, Ojan Vafai wrote:
> The "Unreviewed" bit is news to me. I thought it was assumed that if there's
> no "Reviewed By..." line then it was committed unreviewed and, in fact, that
> was preferred to adding the "Unreviewed" line.
Yes, this is how I understood it too.
Why does the commit-queue need to do more than just looking for OOPS?
On Fri, Mar 4, 2011 at 7:37 PM, Eric Seidel wrote:
> The unreviewed bit is currently used by the scripts (like the
> commit-queue) to help them understand that the patch is intentionally
> unreviewed.
>
> I don't know what the
The unreviewed bit is currently used by the scripts (like the
commit-queue) to help them understand that the patch is intentionally
unreviewed.
I don't know what the "official" process is. But certainly some
amount of "this is intentionally missing a review" information is
useful for the commit-q
On Fri, Mar 4, 2011 at 7:03 PM, Mark Rowe wrote:
> On 2011-03-03, at 23:58, Ojan Vafai wrote:
> It's never been customary to say "Unreviewed." in place of a reviewer. The
> most common type of change that doesn't require review is a build fix, and
> in those cases it's customary to omit the revi
On Mar 3, 2011, at 11:58 PM, Ojan Vafai wrote:
> This isn't a big deal either way, but I noticed that
> http://trac.webkit.org/wiki/CommitterTips#Walkingyouthroughyourfirstcommit
> lists the following as the process for unreviewed commits: "Unreviewed
> commits should include a line saying "Un
On 2011-03-03, at 23:58, Ojan Vafai wrote:
> This isn't a big deal either way, but I noticed that
> http://trac.webkit.org/wiki/CommitterTips#Walkingyouthroughyourfirstcommit
> lists the following as the process for unreviewed commits: "Unreviewed
> commits should include a line saying "Unrevi
This isn't a big deal either way, but I noticed that
http://trac.webkit.org/wiki/CommitterTips#Walkingyouthroughyourfirstcommitlists
the following as the process for unreviewed commits: "Unreviewed
commits should include a line saying "Unreviewed." in place of the "Reviewed
By..." line in each Chan
10 matches
Mail list logo
