Hi Darin,
Thanks for your detailed comments!
Adding windows.h to Assertions.h will not cause it to be included in
public headers. Assertions.h is not designed to be used in public
headers; it's for internal use inside the WebKit project.
I've just executed the following:
find . -name '*.h'
On 2008-07-02, at 00:40, Jörg Bornemann wrote:
Hi Darin,
Thanks for your detailed comments!
Adding windows.h to Assertions.h will not cause it to be included
in
public headers. Assertions.h is not designed to be used in public
headers; it's for internal use inside the WebKit project.
On Wednesday 02 July 2008 09:40:19 Jörg Bornemann wrote:
Hi Darin,
Thanks for your detailed comments!
Adding windows.h to Assertions.h will not cause it to be included in
public headers. Assertions.h is not designed to be used in public
headers; it's for internal use inside the WebKit
Darin Adler wrote:
Well, this is a small change but also a very bad idea. Not because of
compilation time, but because of the crappy Windows headers which define
*a* *lot* of global stuff. E.g. the XSLT parser of WebKit won't build
because there's a #define ERROR somenumber which breaks an
On Jul 1, 2008, at 1:45 AM, Jörg Bornemann wrote:
This solution is easy to do, leads to the smallest source diff but
is a very dirty hack, which will lead to problems on WinCE, because
we will include windows.h in public headers.
Adding windows.h to Assertions.h will not cause it to be
On Jul 1, 2008, at 10:39 AM, Paul Pedriana wrote:
On a related note, I would like to propose (possibly in a separate
email) that the CRASH macro in Assertions.h that ASSERT uses be
augmented to the following for improved debugging and portability
across most platforms:
That sounds like
On Jun 27, 2008, at 1:50 AM, Jörg Bornemann wrote:
Well, this is a small change but also a very bad idea. Not because of
compilation time, but because of the crappy Windows headers which
define
*a* *lot* of global stuff. E.g. the XSLT parser of WebKit won't build
because there's a #define
On Jun 26, 2008, at 5:16 AM, Jörg Bornemann wrote:
That means ATM that I have to make sure to always include
windows.h _before_ Assertion.h.
Then lets add this to Assertion.h:
#if PLATFORM(WINCE) // or whatever is the right if
#include windows.h
#endif
I'd prefer this to a
8 matches
Mail list logo
