Re: [webkit-dev] deleteOwnedPtr(T* ptr)

2010-11-11 Thread Finnur Thorarinsson
Umm... shouldn't this behavior be commented so that people are not left wondering why it fails and trying to fix it? On Wed, Nov 10, 2010 at 16:04, Darin Adler da...@apple.com wrote: On Nov 10, 2010, at 2:33 PM, Daebarkee Jung wrote: I found that the following lines made errors: //

Re: [webkit-dev] deleteOwnedPtr(T* ptr)

2010-11-11 Thread Daebarkee Jung
Thanks, all of you. Now, everything is clear. Daebark On Thu, Nov 11, 2010 at 2:24 AM, Finnur Thorarinsson fin...@chromium.orgwrote: Umm... shouldn't this behavior be commented so that people are not left wondering why it fails and trying to fix it? On Wed, Nov 10, 2010 at 16:04, Darin

Re: [webkit-dev] deleteOwnedPtr(T* ptr)

2010-11-11 Thread Darin Adler
On Nov 11, 2010, at 12:24 AM, Finnur Thorarinsson wrote: Umm... shouldn't this behavior be commented so that people are not left wondering why it fails and trying to fix it? Sure, sounds good. Instructions for submitting patches to add things like those comments are at

Re: [webkit-dev] deleteOwnedPtr(T* ptr)

2010-11-11 Thread David Levin
Do or do not. Then, there is no question. :) btw, in another code base, you may familiar with, the comment is the variable name: http://www.google.com/codesearch?q=type_must_be_completeexact_package=chromium On Thu, Nov 11, 2010 at 12:24 AM, Finnur Thorarinsson fin...@chromium.orgwrote: Umm...

Re: [webkit-dev] deleteOwnedPtr(T* ptr)

2010-11-11 Thread Maciej Stachowiak
On Nov 11, 2010, at 7:20 AM, Darin Adler wrote: On Nov 11, 2010, at 12:24 AM, Finnur Thorarinsson wrote: Umm... shouldn't this behavior be commented so that people are not left wondering why it fails and trying to fix it? Sure, sounds good. Instructions for submitting patches to add

Re: [webkit-dev] deleteOwnedPtr(T* ptr)

2010-11-10 Thread Darin Adler
On Nov 10, 2010, at 2:33 PM, Daebarkee Jung wrote: I found that the following lines made errors: // OwnPtrCommon.h template typename T inline void deleteOwnedPtr(T* ptr) { typedef char known[sizeof(T) ? 1 : -1]; if (sizeof(known)) delete ptr; } I am very