On Apr 21, 2010, at 8:37 PM, Eric Seidel wrote:
I don't
think NRWT works on Windows yet. Adam Roben had some half-working
patches to that affect, but I don't think they're done yet. Mostly
they involve ripping out chromium-specific windows assumptions. :)
I'm planning to clean up these
On Apr 21, 2010, at 6:35 PM, Ojan Vafai wrote:
Do we know how may cores are on those windows machines?
4 each.
-Adam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
On Thu, Apr 22, 2010 at 8:16 AM, Adam Roben aro...@apple.com wrote:
On Apr 21, 2010, at 8:37 PM, Eric Seidel wrote:
I don't
think NRWT works on Windows yet. Adam Roben had some half-working
patches to that affect, but I don't think they're done yet. Mostly
they involve ripping out
On Apr 21, 2010, at 3:35 PM, Ojan Vafai wrote:
On Wed, Apr 21, 2010 at 3:27 PM, Gavin Barraclough barraclo...@apple.com
wrote:
I believe a big problem that caused the extended periods of redness
was the slowness of the Windows test queues. These can lag badly
behind the builds, making
On Apr 22, 2010, at 1:31 PM, Maciej Stachowiak wrote:
On Apr 21, 2010, at 3:35 PM, Ojan Vafai wrote:
On Wed, Apr 21, 2010 at 3:27 PM, Gavin Barraclough barraclo...@apple.com
wrote:
I believe a big problem that caused the extended periods of redness was the
slowness of the Windows test
On Apr 22, 2010, at 1:46 PM, Adam Roben wrote:
and I believe that is because they are not doing parallel builds that take
advantage of their multiple cores.
Yes, this is because pdevenv doesn't currently work with VC++ Express (which
the bots are using to build). There might be ways to
On Thu, Apr 22, 2010 at 10:46 AM, Adam Roben aro...@apple.com wrote:
On Apr 22, 2010, at 1:31 PM, Maciej Stachowiak wrote:
I suspect Windows builders fall behind whenever there is a sequence of
changes that each requires a long rebuild.
That might be right, though I'm having trouble finding
I sent an email to webkit-dev a couple of weeks ago, explaining my logic behind
why I thought the testers were slow.
quote
My theory as to what is happening is that:
- The Windows Release tests take ~500 seconds to run.
- The Windows Debug tests take ~950 seconds to run.
The master is
On Apr 22, 2010, at 2:04 PM, Brian Weinstein wrote:
This means that they both have to keep two trees up to date (the debug and
release trees),
The svn step of the test builders takes about 4.5 minutes, compared to about
15 minutes to run the tests. I don't know if having to update two
On Apr 22, 2010, at 2:19 PM, Adam Roben wrote:
The svn step of the test builders takes about 4.5 minutes, compared to
about 15 minutes to run the tests. I don't know if having to update two
different source trees is the main problem here.
Note that this data was for a revision where only 5
On Thu, Apr 22, 2010 at 11:23 AM, Adam Roben aro...@apple.com wrote:
On Apr 22, 2010, at 2:19 PM, Adam Roben wrote:
The svn step of the test builders takes about 4.5 minutes, compared to
about 15 minutes to run the tests. I don't know if having to update two
different source trees is the
On Apr 22, 2010, at 2:30 PM, Ojan Vafai wrote:
On Thu, Apr 22, 2010 at 11:25 AM, Adam Barth aba...@webkit.org wrote:
On Thu, Apr 22, 2010 at 11:23 AM, Adam Roben aro...@apple.com wrote:
On Apr 22, 2010, at 2:19 PM, Adam Roben wrote:
The svn step of the test builders takes about 4.5
On Thu, Apr 22, 2010 at 11:32 AM, Adam Roben aro...@apple.com wrote:
On Apr 22, 2010, at 2:30 PM, Ojan Vafai wrote:
Builds 11611 and 11612 took 89 and 93 seconds, respectively. Seems like
there's a fair amount of variance. In any case it sounds like the svn step
is even less of an issue than
Ojan,
What is going there is that both machines are running Windows Debug Tests (or
Windows Release Tests).
We have two machines that run both Windows Debug Tests, and Windows Release
Tests, so there are some times where they are both running the same kind of
test, and it looks like the other
On Thu, Apr 22, 2010 at 11:44 AM, Brian Weinstein bweinst...@apple.comwrote:
What is going there is that both machines are running Windows Debug Tests
(or Windows Release Tests).
We have two machines that run both Windows Debug Tests, and Windows Release
Tests, so there are some times where
Hi webkit-dev,
I'd like to start a discussion about adding FTS3 support to WebSQLDatabases
in WebKit. FTS3 has been a standard SQLite extension for quite some time and
allows web developers to use full text search. The goal is to make it easier
for web developers who used Gears for their apps to
On Apr 22, 2010, at 3:02 PM, Ojan Vafai wrote:
On Thu, Apr 22, 2010 at 11:44 AM, Brian Weinstein bweinst...@apple.com
wrote:
What is going there is that both machines are running Windows Debug Tests (or
Windows Release Tests).
We have two machines that run both Windows Debug Tests, and
On Apr 22, 2010, at 3:32 PM, Adam Roben wrote:
On Apr 22, 2010, at 3:02 PM, Ojan Vafai wrote:
On Thu, Apr 22, 2010 at 11:44 AM, Brian Weinstein bweinst...@apple.com
wrote:
What is going there is that both machines are running Windows Debug Tests
(or Windows Release Tests).
We have
I’m having trouble reviewing patches with the action=review patch since the
experimental commenting support was added. I now have to do a lot of editing
and copying and pasting when reviewing that was not necessary before.
- The action=review JavaScript code now deletes the copy of the patch,
One of the other demos put together at the hackathon let you drag on
the patch to select how much context you wanted when making your
comment. I can try to make that work.
Adam
On Thu, Apr 22, 2010 at 1:09 PM, Adam Barth aba...@webkit.org wrote:
How would you like me to address this issue?
On Apr 22, 2010, at 4:01 PM, Darin Adler wrote:
- The comments all cite only a single line of the patch and I almost never
have a comment that's for a single line. So I have to do a lot of editing,
pretending to comment on multiple lines.
I think it would be nice if you could drag to select
Seems like the most critical issue is that old-style review is broken.
Perhaps the comment field can be cleared with a button, or we could
add a button to paste the full patch. Other issues seem like iterative
refinements we could do over time.
- Maciej
On Apr 22, 2010, at 1:09 PM,
I'd like to ask some of our SQLite gurus at Apple about this. I recall that
they have had (admitedly Apple Internal) concerns about it in the past.
Is there a bugzilla for this that I can follow and update?
~Brady
On Apr 22, 2010, at 12:15 PM, Dumitru Daniliuc wrote:
Hi webkit-dev,
I'd
i've just opened https://bugs.webkit.org/show_bug.cgi?id=38003 to track
this.
dumi
On Thu, Apr 22, 2010 at 1:15 PM, Brady Eidson beid...@apple.com wrote:
I'd like to ask some of our SQLite gurus at Apple about this. I recall
that they have had (admitedly Apple Internal) concerns about it in
https://bugs.webkit.org/show_bug.cgi?id=38004
On Thu, Apr 22, 2010 at 1:15 PM, Maciej Stachowiak m...@apple.com wrote:
Seems like the most critical issue is that old-style review is broken.
Perhaps the comment field can be cleared with a button, or we could add a
button to paste the full
Hi all,
If no one has already figured out, the warnings on Gtk builds are due to
http://trac.webkit.org/changeset/58108
In particular, four of the warnings are due to the fact there is no
prototype declaration for webkit_dom_document_get_title
and webkit_dom_document_set_title called on the line
26 matches
Mail list logo
