Re: [webkit-dev] Renaming directories

2010-12-21 Thread Simon Fraser
On Dec 21, 2010, at 11:14 AM, Darin Adler wrote: Here’s my attempt to list the tests we currently have: - Automated regression tests (from LayoutTests directory). Many different types: Layout/pixel, text, script-tests, ref-tests coming soon, some requiring local server, some JavaScript

Re: [webkit-dev] Renaming directories

2010-12-21 Thread Eric Seidel
Chromium already has a ton of architecture for automated runs of the PLT which I'm sure they'd be happy to share. (e.g. http://build.chromium.org/f/chromium/perf/dashboard/overview.html) The problem remains that (aside from the SVG PLT no one uses) we have no publicly available PLT content. :)

[webkit-dev] Platform specific fields on WebCore::HistoryItem

2010-12-21 Thread Darin Fisher
I'm working on fixing some session history bugs related to a HistoryItem's URL property changing. See for example the call to HistoryItem::setURL in HistoryController::updateForReload [1]. I'm curious about the platform specific fields on WebCore::HistoryItem. *** Do any of those need to be

Re: [webkit-dev] Platform specific fields on WebCore::HistoryItem

2010-12-21 Thread Brady Eidson
On Dec 21, 2010, at 11:39 AM, Darin Fisher wrote: I'm working on fixing some session history bugs related to a HistoryItem's URL property changing. See for example the call to HistoryItem::setURL in HistoryController::updateForReload [1]. I'm curious about the platform specific fields

Re: [webkit-dev] Platform specific fields on WebCore::HistoryItem

2010-12-21 Thread Darin Fisher
On Tue, Dec 21, 2010 at 11:46 AM, Brady Eidson beid...@apple.com wrote: On Dec 21, 2010, at 11:39 AM, Darin Fisher wrote: I'm working on fixing some session history bugs related to a HistoryItem's URL property changing. See for example the call to HistoryItem::setURL in

Re: [webkit-dev] WebKitTools has changed to Tools

2010-12-21 Thread Ryosuke Niwa
Thanks for the rename! I love the fact I can access Tools in just 2 key strokes (T + tab). - Ryosuke On Fri, Dec 17, 2010 at 4:09 PM, Dan Bernstein m...@apple.com wrote: Done in r74301. On Nov 20, 2010, at 11:29 PM, Dan Bernstein wrote: WebKit developers, I am going to commit the patch

Re: [webkit-dev] Platform specific fields on WebCore::HistoryItem

2010-12-21 Thread Yael.Aharon
From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev-boun...@lists.webkit.org] On Behalf Of ext Darin Fisher Sent: Tuesday, December 21, 2010 2:39 PM To: WebKit Development Subject: [webkit-dev] Platform specific fields on WebCore::HistoryItem I'm working on fixing some session history

Re: [webkit-dev] Renaming directories

2010-12-21 Thread Maciej Stachowiak
On Dec 18, 2010, at 2:23 AM, Adam Barth wrote: While we're in the mood to rename directories, would these renamings make sense: WebKitSite = WebSite Just Site might be more Tab-complete-friendly, though it is less precise. Regards, Maciej ___

Re: [webkit-dev] Renaming directories

2010-12-21 Thread Maciej Stachowiak
On Dec 21, 2010, at 11:14 AM, Darin Adler wrote: Here’s my attempt to list the tests we currently have: - Automated regression tests (from LayoutTests directory). Many different types: Layout/pixel, text, script-tests, ref-tests coming soon, some requiring local server, some

Re: [webkit-dev] Platform specific fields on WebCore::HistoryItem

2010-12-21 Thread Darin Fisher
On Tue, Dec 21, 2010 at 11:49 AM, Darin Fisher da...@chromium.org wrote: On Tue, Dec 21, 2010 at 11:46 AM, Brady Eidson beid...@apple.com wrote: On Dec 21, 2010, at 11:39 AM, Darin Fisher wrote: I'm working on fixing some session history bugs related to a HistoryItem's URL property

Re: [webkit-dev] Renaming directories

2010-12-21 Thread Oliver Hunt
On Dec 21, 2010, at 1:49 PM, Maciej Stachowiak wrote: And we have JavaScriptCore API tests which are not run automated. The JSC API tests run as part of run-javascript-tests, which the build bots do execute --Oliver ___ webkit-dev mailing list

Re: [webkit-dev] Renaming directories

2010-12-21 Thread Sam Weinig
We also have WebKit2 API tests (or soon will if they aren't landed yet). The WebKit2 tests have been in the tree (under Tools/TestWebKitAPI) for bit now. The harness can also be used to test WTF data structures and has a sample test of basic testing of Vector. -Sam

Re: [webkit-dev] Platform specific fields on WebCore::HistoryItem

2010-12-21 Thread Darin Fisher
On Tue, Dec 21, 2010 at 2:56 PM, Brady Eidson beid...@apple.com wrote: On Dec 21, 2010, at 1:57 PM, Darin Fisher wrote: On Tue, Dec 21, 2010 at 11:49 AM, Darin Fisher da...@chromium.org wrote: On Tue, Dec 21, 2010 at 11:46 AM, Brady Eidson beid...@apple.com wrote: On Dec 21, 2010, at

Re: [webkit-dev] Platform specific fields on WebCore::HistoryItem

2010-12-21 Thread Darin Fisher
On Tue, Dec 21, 2010 at 3:59 PM, Darin Fisher da...@chromium.org wrote: On Tue, Dec 21, 2010 at 2:56 PM, Brady Eidson beid...@apple.com wrote: On Dec 21, 2010, at 1:57 PM, Darin Fisher wrote: On Tue, Dec 21, 2010 at 11:49 AM, Darin Fisher da...@chromium.orgwrote: On Tue, Dec 21, 2010

Re: [webkit-dev] Platform specific fields on WebCore::HistoryItem

2010-12-21 Thread Brady Eidson
On Dec 21, 2010, at 4:26 PM, Darin Fisher wrote: On Tue, Dec 21, 2010 at 3:59 PM, Darin Fisher da...@chromium.org wrote: On Tue, Dec 21, 2010 at 2:56 PM, Brady Eidson beid...@apple.com wrote: On Dec 21, 2010, at 1:57 PM, Darin Fisher wrote: On Tue, Dec 21, 2010 at 11:49 AM, Darin

Re: [webkit-dev] Renaming directories

2010-12-21 Thread Ryosuke Niwa
On Mon, Dec 20, 2010 at 11:22 PM, Adam Barth aba...@webkit.org wrote: Do we want to move LayoutTests = RegressionTests? My sense is that would be more disruptive than the other moves. Last time we discussed this question, Darin encouraged us to view the future as larger than the past and to

Re: [webkit-dev] Renaming directories

2010-12-21 Thread Mihai Parparita
On Tue, Dec 21, 2010 at 6:12 PM, Ryosuke Niwa rn...@webkit.org wrote: Why don't we do this as we change the format of render tree dumps.  We can remove expected tests from LayoutTests, move tests to RegressionTests with new expected results. I don't think an incremental migration will work

Re: [webkit-dev] Renaming directories

2010-12-21 Thread Ryosuke Niwa
On Tue, Dec 21, 2010 at 6:16 PM, Mihai Parparita mih...@chromium.orgwrote: On Tue, Dec 21, 2010 at 6:12 PM, Ryosuke Niwa rn...@webkit.org wrote: Why don't we do this as we change the format of render tree dumps. We can remove expected tests from LayoutTests, move tests to RegressionTests

Re: [webkit-dev] Page Cache for web-pages with plugin

2010-12-21 Thread Aneesh Bhasin
On Tue, Dec 21, 2010 at 12:56 AM, Sam Weinig sam.wei...@gmail.com wrote: No one (that I know of) is currently working on making plugins work with the PageCache. The most pressing road block to make it work is infrastructure to kill and restart plugins (or alternatively, and reliable way to

Re: [webkit-dev] Renaming directories

2010-12-21 Thread Adam Barth
On Tue, Dec 21, 2010 at 11:30 PM, Darin Adler da...@apple.com wrote: On Dec 21, 2010, at 11:20 PM, Adam Barth wrote: Looking through my working copy, there are a couple of things that aren't obvious to me where they would go in this structure: WebKitBuild and WebKitLibraries. Maybe these