Re: [webkit-dev] Changes in QtWebKit development

2013-09-30 Thread Allan Sandfeld Jensen
On Thursday 26 September 2013, Andreas Kling wrote: On Sep 25, 2013, at 12:40 PM, Allan Sandfeld Jensen k...@carewolf.com wrote: On Saturday 14 September 2013, Andreas Kling wrote: On Sep 14, 2013, at 11:24 AM, Allan Sandfeld Jensen k...@carewolf.com wrote: That said, in all

[webkit-dev] Type cast by using toFoo()

2013-09-30 Thread Gyuyoung Kim
Hello WebKittens, I have focused on using toFoo() for SVG and CSS instead of using static_cast. Because I think there are some advantages when we use it. - Bad type cast can be detected by using ASSERTION in toFoo(). The toFoo() function has an ASSERTION to check if source value is a proper

Re: [webkit-dev] Changes in QtWebKit development

2013-09-30 Thread Dirk Schulze
On Sep 30, 2013, at 11:58 AM, Allan Sandfeld Jensen k...@carewolf.com wrote: On Thursday 26 September 2013, Andreas Kling wrote: On Sep 25, 2013, at 12:40 PM, Allan Sandfeld Jensen k...@carewolf.com wrote: On Saturday 14 September 2013, Andreas Kling wrote: On Sep 14, 2013, at 11:24 AM,

Re: [webkit-dev] Changes in QtWebKit development

2013-09-30 Thread Arunprasad Rajkumar
New XML parser was removed from the tree [1]. [1] https://lists.webkit.org/pipermail/webkit-dev/2012-August/022103.html http://trac.webkit.org/changeset/140399 On 30 September 2013 19:18, Konstantin Tokarev annu...@yandex.ru wrote: 30.09.2013, 17:39, Dirk Schulze k...@webkit.org: On Sep

Re: [webkit-dev] Changes in QtWebKit development

2013-09-30 Thread Allan Sandfeld Jensen
On Monday 30 September 2013, Dirk Schulze wrote: I would not necessarily disagree with the problem of upstreaming work. But you said that most likely you wouldn't be able to branch WebKit anymore because of the compiler requirement. At least for Qt. Do you have other interests in QtWebKit

Re: [webkit-dev] Changes in QtWebKit development

2013-09-30 Thread Geoffrey Garen
I’m planning to remove m_qStringData from StringImpl, along with any code that depends on it. Any objections? Geoff ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Changes in QtWebKit development

2013-09-30 Thread Allan Sandfeld Jensen
On Monday 30 September 2013, Geoffrey Garen wrote: I’m planning to remove m_qStringData from StringImpl, along with any code that depends on it. Any objections? It should be removable by manually reverting r119217, it will hurt Qt WK2 and JSC bridge performance, but in theory not break

Re: [webkit-dev] Changes in QtWebKit development

2013-09-30 Thread Geoffrey Garen
It should be removable by manually reverting r119217, it will hurt Qt WK2 and JSC bridge performance, but in theory not break anything if done right. Do you need to remove it to free a up a new type of string buffer ownership? We’d like to remove all special buffers, so that: -

Re: [webkit-dev] Type cast by using toFoo()

2013-09-30 Thread Sam Weinig
On Sep 30, 2013, at 3:39 AM, Gyuyoung Kim gyuyoung@webkit.org wrote: Hello WebKittens, I have focused on using toFoo() for SVG and CSS instead of using static_cast. Because I think there are some advantages when we use it. - Bad type cast can be detected by using ASSERTION in

Re: [webkit-dev] Type cast by using toFoo()

2013-09-30 Thread Yong Li
I think it can be done by checking the vtable pointer if the classes are virtual. From: Sam Weinig Sent: ‎Monday‎, ‎September‎ ‎30‎, ‎2013 ‎12‎:‎53‎ ‎PM To: Gyuyoung Kim Cc: Webkit Development List On Sep 30, 2013, at 3:39 AM, Gyuyoung Kim gyuyoung@webkit.org wrote: Hello WebKittens,

Re: [webkit-dev] Proposal: Remove DOMFileSystem support

2013-09-30 Thread Sam Weinig
Antonio Gomes noted to me that Ryosuke asked the same question around a month ago and got no objections (https://lists.webkit.org/pipermail/webkit-dev/2013-August/025351.html), so I am going to move forward and remove it. Thanks, -Sam On Sep 29, 2013, at 9:24 PM, Sam Weinig wei...@apple.com

Re: [webkit-dev] Proposal: Remove DOMFileSystem support

2013-09-30 Thread Ryosuke Niwa
Yay! Less code. - R. Niwa On Mon, Sep 30, 2013 at 9:55 AM, Sam Weinig wei...@apple.com wrote: Antonio Gomes noted to me that Ryosuke asked the same question around a month ago and got no objections ( https://lists.webkit.org/pipermail/webkit-dev/2013-August/025351.html), so I am going to

Re: [webkit-dev] Changes in QtWebKit development

2013-09-30 Thread Konstantin Tokarev
30.09.2013, 13:59, Allan Sandfeld Jensen k...@carewolf.com:  If a new branch is made from WebKit trunk in the future would likely only be limited to specific platforms, and therefore not suited as a module shipped with Qt, but as an optional upgrade. If QtWebKit is downgraded from Qt

Re: [webkit-dev] Type cast by using toFoo()

2013-09-30 Thread Darin Adler
On Sep 30, 2013, at 9:54 AM, Yong Li yong.li.web...@outlook.com wrote: Finally I plan to add this toFoo() policy to the WebKit style checker. Can you explain more about this? How are you going to determine static_casts that are acceptable from ones that aren’t. I think it can be done

Re: [webkit-dev] Type cast by using toFoo()

2013-09-30 Thread Yong Li
Bottom line is turning on RTTI in debug build? From: Darin Adlermailto:da...@apple.com Sent: ‎2013-‎09-‎30 1:50 PM To: Yong Limailto:yong.li.web...@outlook.com Cc: Gyuyoung Kimmailto:gyuyoung@webkit.org; Sam Weinigmailto:wei...@apple.com; WebKit

Re: [webkit-dev] Type cast by using toFoo()

2013-09-30 Thread Ryosuke Niwa
On Mon, Sep 30, 2013 at 10:52 AM, Yong Li yong.li.web...@outlook.comwrote: Bottom line is turning on RTTI in debug build? Style checker analyzes the code statically. It's nothing to do with runtime assertions. If that wasn't clear enough, style check happens before WebKit is ever built. -

Re: [webkit-dev] Changes in QtWebKit development

2013-09-30 Thread Oliver Hunt
On Sep 30, 2013, at 7:41 AM, Allan Sandfeld Jensen k...@carewolf.com wrote: Some of this is exactly the reason we want to keep Qt WebKit alive. It may never be possible to fully replace Qt WebKit with anything Blink/Chromium based. I really don’t understand this, there are only two options:

[webkit-dev] WTF::fastMalloc

2013-09-30 Thread Geoffrey Garen
Hi folks. I’m planning to remove our years-out-of-date port of TCMalloc, and replace it with something that takes maximum advantage of Mac and iOS virtual memory, threading, and security APIs. I've heard that TCMalloc has caused some problems for non-Mac, non-iOS ports in the past. So, if you

Re: [webkit-dev] WTF::fastMalloc

2013-09-30 Thread Zoltan Horvath
Hi Geoffrey, I used to work on memory related topics, while I was working on the University of Szeged. Based on a 2.5-year-old measurement ( http://webkit.sed.hu/blog/20100302/war-allocators-qtlaunchers-coast) on the Qt-port, the page loading on the Methanol test suite was 5% faster (avg) with

[webkit-dev] AX: Implement CSS -webkit-alt property (text alternative for generated content pseudo-elements ::before and ::after)

2013-09-30 Thread James Craig
AX: Implement CSS -webkit-alt property https://bugs.webkit.org/show_bug.cgi?id=120188 This is blocking 20+ bugs on one of our higher profile content sites and we’d like to start work on it. To clarify, the problem is that with CSS generated content in pseudo-elements like this:

Re: [webkit-dev] Type cast by using toFoo()

2013-09-30 Thread Gyuyoung Kim
My plan is to show style error when submitted patch doesn't use toFoo() though toFoo exists. This idea was originated from blink commit. However, it was reverted because of some regression. http://src.chromium.org/viewvc/blink?view=revisionrevision=158059 If my understanding is correct, the