Re: [webkit-dev] Unified source builds and adding or removing files...

2019-03-20 Thread Don . Olmstead
The ability to toggle unified builds on and off was enabled in https://trac.webkit.org/changeset/239561/webkit . Immediately afterwards this bug was opened https://bugs.webkit.org/show_bug.cgi?id=193073 which needs to get resolved. We're open to adding a bot with ENABLE_UNIFIED_BUILDS=OFF if

Re: [webkit-dev] Style guideline on initializing non-POD types via member initialization

2019-03-20 Thread Simon Fraser
> On Mar 14, 2019, at 1:06 PM, Filip Pizlo wrote: > > I like to draw this distinction: is the initializer a constant? > > It’s not a constant if it relies on arguments to the constructor. “This” is > an argument to the constructor. > > It’s also not a constant if it involves reading the

Re: [webkit-dev] MathML Refresh Heads up

2019-03-20 Thread Ryosuke Niwa
On Wed, Mar 20, 2019 at 5:57 AM Frédéric Wang wrote: > On 16/03/2019 00:04, Ryosuke Niwa wrote: > > On Fri, Mar 15, 2019 at 3:33 PM Frédéric Wang wrote: > >> Hi Ryosuke and Myles, >> >> Thank you for your reply. First, the exact thing about what will be in >> MathML Core is still open, people

Re: [webkit-dev] MathML Refresh Heads up

2019-03-20 Thread Frédéric Wang
On 16/03/2019 00:29, Maciej Stachowiak wrote: > It’s easier for us to check Apple Books and iOS App compatibility for > a batch of possible removals at once, instead of one at a time. We can > start by looking at the set of items below. > > It’s helpful to give a heads-up other than the normal

Re: [webkit-dev] Code Style: Opinion on returning void

2019-03-20 Thread Nico Weber
On Thu, Feb 21, 2019 at 12:31 PM Darin Adler wrote: > I tried not to weigh in on this, but my view on the materials we should > use to build the bike shed must be shared! > > Generally it seems neat to be able to make the code slightly more tight > and terse by merging the function call and the

Re: [webkit-dev] MathML Refresh Heads up

2019-03-20 Thread Frédéric Wang
On 16/03/2019 00:04, Ryosuke Niwa wrote: > On Fri, Mar 15, 2019 at 3:33 PM Frédéric Wang > wrote: > > Hi Ryosuke and Myles, > > Thank you for your reply. First, the exact thing about what will > be in MathML Core is still open, people are welcome to join and >

Re: [webkit-dev] MathML Refresh Heads up

2019-03-20 Thread Ryosuke Niwa
On Wed, Mar 20, 2019 at 10:42 AM Ryosuke Niwa wrote: > > On Wed, Mar 20, 2019 at 5:57 AM Frédéric Wang wrote: > >> On 16/03/2019 00:04, Ryosuke Niwa wrote: >> >> On Fri, Mar 15, 2019 at 3:33 PM Frédéric Wang wrote: >> >>> Hi Ryosuke and Myles, >>> >>> Thank you for your reply. First, the exact