Re: [webkit-dev] [Styling] () for a lambda without arguments (Was Space between [] and () in C++ lambdas)
I've been using the short form in the layout code for a while now and never
mistaken it for code block start & end.
That being said I don't have strong preference on this.
Alan.
On Fri, Nov 1, 2019 at 4:37 PM Ryosuke Niwa wrote:
> On Fri, Nov 1, 2019 at 11:53 AM Michael Catanzaro
> wrote:
>
>> On Fri, Nov 1, 2019 at 11:19 am, Ryosuke Niwa wrote:
>> > Namely, some people write a lambda as:
>> > auto x = [] () { }
>> >
>> > with a space between [] and () while others would write it as:
>> >
>> > auto x = []() { }
>>
>> : I omit the () when there are no parameters, as in these examples.
>>
>
> I guess that's another thing we should decide. Should we, or should we not
> have () when there are no arguments.
>
> I think we usually err on the side of more concise form but I do prefer
> having () so that it's clear it's a function. Otherwise, it can look like a
> code block start & end.
>
> - R. Niwa
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] EWS Comments on Bugzilla (Was: EWS now parses error logs in case of build failure)
Sounds good. I prefer the single comment when the first failure occur. That way notification would be sent as soon as the first failure happens. I'll implement that (assuming it's acceptable to everyone). Thanks Aakash > On Nov 1, 2019, at 8:35 PM, Maciej Stachowiak wrote: > > > How about only a single comment when the first failure occurs? (Or else when > all bots pass, if there is never a failure.) > > This should help the author, the reviewer, and anyone else cc’d, without > being too spammy. > >> On Nov 1, 2019, at 5:20 PM, Aakash Jain wrote: >> >> Hi Ryosuke, >> >> Many people didn't like the noise by the EWS comments, and we removed the >> comments as per previous discussion in: >> https://lists.webkit.org/pipermail/webkit-dev/2019-June/030683.html. >> >> I agree with your point that having some kind of notification might be >> useful. >> >> I proposed some ideas in >> https://lists.webkit.org/pipermail/webkit-dev/2019-September/030798.html, >> but didn't get much feedback. If we can all agree on a solution, I can look >> into implementing it. >> >> Thanks >> Aakash >> >>> On Oct 30, 2019, at 1:03 AM, Ryosuke Niwa wrote: >>> >>> These enhancements are great. There is one feature of the old EWS that I >>> really miss, which is that I used to get emails when some EWS failed. With >>> new EWS, I have to keep checking back the bugzilla to see if any of them >>> have failed periodically. >>> >>> Can we add a feature to opt into such an email notification? Maybe a flag >>> on a patch or JSON configuration file somewhere. >>> >>> - R. Niwa >>> >>> On Tue, Oct 29, 2019 at 4:05 PM Aakash Jain wrote: >>> Hi Everyone, >>> >>> I am happy to announce another EWS feature. >>> >>> From now on, in case of build failure, EWS will parse the errors and >>> display them in a separate 'errors' log. You wouldn't have to search >>> through thousands of lines of logs to find the error message. >>> >>> For example, in https://ews-build.webkit.org/#/builders/16/builds/6054, in >>> step #7 WebKit failed to compile. Complete logs (stdio) are 38,000+ lines, >>> and the error is not at the end of the logs. Normally, it requires some >>> searching through the logs to find the relevant errors. But now, there is >>> another 'errors' log, which contains just the relevant 11 lines (containing >>> error and few related lines to provide additional context). >>> >>> Hopefully this would save some time and efforts previously spent on >>> searching through the large logs. >>> >>> Note that this information is not displayed in status-bubble tool-tip, >>> since this might be lot of text to display in the tooltip. My further plan >>> is to make this information more readily available, by adding it to a >>> custom designed page which will open on clicking the status bubble >>> https://webkit.org/b/197522 >>> >>> Please let me know if you notice any issues or have any feedback. >>> >>> Thanks >>> Aakash >>> >>> Reference: https://webkit.org/b/203418 >>> ___ >>> webkit-dev mailing list >>> webkit-dev@lists.webkit.org >>> https://lists.webkit.org/mailman/listinfo/webkit-dev >>> -- >>> - R. Niwa >> >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> https://lists.webkit.org/mailman/listinfo/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] EWS Comments on Bugzilla (Was: EWS now parses error logs in case of build failure)
How about only a single comment when the first failure occurs? (Or else when all bots pass, if there is never a failure.) This should help the author, the reviewer, and anyone else cc’d, without being too spammy. > On Nov 1, 2019, at 5:20 PM, Aakash Jain wrote: > > Hi Ryosuke, > > Many people didn't like the noise by the EWS comments, and we removed the > comments as per previous discussion in: > https://lists.webkit.org/pipermail/webkit-dev/2019-June/030683.html. > > I agree with your point that having some kind of notification might be useful. > > I proposed some ideas in > https://lists.webkit.org/pipermail/webkit-dev/2019-September/030798.html, but > didn't get much feedback. If we can all agree on a solution, I can look into > implementing it. > > Thanks > Aakash > >> On Oct 30, 2019, at 1:03 AM, Ryosuke Niwa wrote: >> >> These enhancements are great. There is one feature of the old EWS that I >> really miss, which is that I used to get emails when some EWS failed. With >> new EWS, I have to keep checking back the bugzilla to see if any of them >> have failed periodically. >> >> Can we add a feature to opt into such an email notification? Maybe a flag on >> a patch or JSON configuration file somewhere. >> >> - R. Niwa >> >> On Tue, Oct 29, 2019 at 4:05 PM Aakash Jain wrote: >> Hi Everyone, >> >> I am happy to announce another EWS feature. >> >> From now on, in case of build failure, EWS will parse the errors and display >> them in a separate 'errors' log. You wouldn't have to search through >> thousands of lines of logs to find the error message. >> >> For example, in https://ews-build.webkit.org/#/builders/16/builds/6054, in >> step #7 WebKit failed to compile. Complete logs (stdio) are 38,000+ lines, >> and the error is not at the end of the logs. Normally, it requires some >> searching through the logs to find the relevant errors. But now, there is >> another 'errors' log, which contains just the relevant 11 lines (containing >> error and few related lines to provide additional context). >> >> Hopefully this would save some time and efforts previously spent on >> searching through the large logs. >> >> Note that this information is not displayed in status-bubble tool-tip, since >> this might be lot of text to display in the tooltip. My further plan is to >> make this information more readily available, by adding it to a custom >> designed page which will open on clicking the status bubble >> https://webkit.org/b/197522 >> >> Please let me know if you notice any issues or have any feedback. >> >> Thanks >> Aakash >> >> Reference: https://webkit.org/b/203418 >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> https://lists.webkit.org/mailman/listinfo/webkit-dev >> -- >> - R. Niwa > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] EWS Comments on Bugzilla (Was: EWS now parses error logs in case of build failure)
Hi Ryosuke, Many people didn't like the noise by the EWS comments, and we removed the comments as per previous discussion in: https://lists.webkit.org/pipermail/webkit-dev/2019-June/030683.html. I agree with your point that having some kind of notification might be useful. I proposed some ideas in https://lists.webkit.org/pipermail/webkit-dev/2019-September/030798.html, but didn't get much feedback. If we can all agree on a solution, I can look into implementing it. Thanks Aakash > On Oct 30, 2019, at 1:03 AM, Ryosuke Niwa wrote: > > These enhancements are great. There is one feature of the old EWS that I > really miss, which is that I used to get emails when some EWS failed. With > new EWS, I have to keep checking back the bugzilla to see if any of them have > failed periodically. > > Can we add a feature to opt into such an email notification? Maybe a flag on > a patch or JSON configuration file somewhere. > > - R. Niwa > > On Tue, Oct 29, 2019 at 4:05 PM Aakash Jain wrote: > Hi Everyone, > > I am happy to announce another EWS feature. > > From now on, in case of build failure, EWS will parse the errors and display > them in a separate 'errors' log. You wouldn't have to search through > thousands of lines of logs to find the error message. > > For example, in https://ews-build.webkit.org/#/builders/16/builds/6054, in > step #7 WebKit failed to compile. Complete logs (stdio) are 38,000+ lines, > and the error is not at the end of the logs. Normally, it requires some > searching through the logs to find the relevant errors. But now, there is > another 'errors' log, which contains just the relevant 11 lines (containing > error and few related lines to provide additional context). > > Hopefully this would save some time and efforts previously spent on searching > through the large logs. > > Note that this information is not displayed in status-bubble tool-tip, since > this might be lot of text to display in the tooltip. My further plan is to > make this information more readily available, by adding it to a custom > designed page which will open on clicking the status bubble > https://webkit.org/b/197522 > > Please let me know if you notice any issues or have any feedback. > > Thanks > Aakash > > Reference: https://webkit.org/b/203418 > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev > -- > - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] [Styling] () for a lambda without arguments (Was Space between [] and () in C++ lambdas)
On Fri, Nov 1, 2019 at 11:53 AM Michael Catanzaro
wrote:
> On Fri, Nov 1, 2019 at 11:19 am, Ryosuke Niwa wrote:
> > Namely, some people write a lambda as:
> > auto x = [] () { }
> >
> > with a space between [] and () while others would write it as:
> >
> > auto x = []() { }
>
> : I omit the () when there are no parameters, as in these examples.
>
I guess that's another thing we should decide. Should we, or should we not
have () when there are no arguments.
I think we usually err on the side of more concise form but I do prefer
having () so that it's clear it's a function. Otherwise, it can look like a
code block start & end.
- R. Niwa
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] [Styling] Space between [] and () in C++ lambdas
> On Nov 1, 2019, at 11:53, Michael Catanzaro wrote:
>
> On Fri, Nov 1, 2019 at 11:19 am, Ryosuke Niwa wrote:
>> Namely, some people write a lambda as:
>> auto x = [] () { }
>> with a space between [] and () while others would write it as:
>> auto x = []() { }
>
> : I omit the () when there are no parameters, as in these examples.
>
> No preference on spacing.
I like having a space here, because this rule is simpler to me.
If we always have a space between them, this is clear that the above case is
written in `[] { }` instead of `[]{ }`.
-Yusuke
>
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] [Styling] Space between [] and () in C++ lambdas
On Fri, Nov 1, 2019 at 11:19 am, Ryosuke Niwa wrote:
Namely, some people write a lambda as:
auto x = [] () { }
with a space between [] and () while others would write it as:
auto x = []() { }
: I omit the () when there are no parameters, as in these examples.
No preference on spacing.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] [Styling] Space between [] and () in C++ lambdas
On Fri, Nov 1, 2019 at 11:19 AM Ryosuke Niwa wrote:
> Hi all,
>
> There seems to be inconsistency in our coding style with regards to
> spacing in lambdas.
>
> Namely, some people write a lambda as:
> auto x = [] () { }
>
> with a space between [] and () while others would write it as:
>
> auto x = []() { }
>
> without a space between the two. I'd like to require either style in our
> guideline so that things are consistent in our codebase. Which one should
> we use?
>
> FWIW, I mildly prefer having a space between [] and ().
>
I forgot to mention that according to Antti
, the existing code in
WebCore places no space between ] and ( with 2:1 ratio.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] [Styling] Space between [] and () in C++ lambdas
I mildly prefer without the space :)
--
Chris Dumez
> On Nov 1, 2019, at 11:19 AM, Ryosuke Niwa wrote:
>
> Hi all,
>
> There seems to be inconsistency in our coding style with regards to spacing
> in lambdas.
>
> Namely, some people write a lambda as:
> auto x = [] () { }
>
> with a space between [] and () while others would write it as:
>
> auto x = []() { }
>
> without a space between the two. I'd like to require either style in our
> guideline so that things are consistent in our codebase. Which one should we
> use?
>
> FWIW, I mildly prefer having a space between [] and ().
>
> - R. Niwa
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] [Styling] Space between [] and () in C++ lambdas
> On Nov 1, 2019, at 11:19 AM, Ryosuke Niwa wrote:
>
> Hi all,
>
> There seems to be inconsistency in our coding style with regards to spacing
> in lambdas.
I've noticed this too and the lack of consistency slightly annoys me.
>
> Namely, some people write a lambda as:
> auto x = [] () { }
>
> with a space between [] and () while others would write it as:
>
> auto x = []() { }
>
> without a space between the two. I'd like to require either style in our
> guideline so that things are consistent in our codebase. Which one should we
> use?
>
> FWIW, I mildly prefer having a space between [] and ().
Same. My vote is to have a space.
- Saam
>
> - R. Niwa
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] [Styling] Space between [] and () in C++ lambdas
Hi all,
There seems to be inconsistency in our coding style with regards to spacing
in lambdas.
Namely, some people write a lambda as:
auto x = [] () { }
with a space between [] and () while others would write it as:
auto x = []() { }
without a space between the two. I'd like to require either style in our
guideline so that things are consistent in our codebase. Which one should
we use?
FWIW, I mildly prefer having a space between [] and ().
- R. Niwa
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
