How about only a single comment when the first failure occurs? (Or else when all bots pass, if there is never a failure.)
This should help the author, the reviewer, and anyone else cc’d, without being too spammy. > On Nov 1, 2019, at 5:20 PM, Aakash Jain <aakash_j...@apple.com> wrote: > > Hi Ryosuke, > > Many people didn't like the noise by the EWS comments, and we removed the > comments as per previous discussion in: > https://lists.webkit.org/pipermail/webkit-dev/2019-June/030683.html. > > I agree with your point that having some kind of notification might be useful. > > I proposed some ideas in > https://lists.webkit.org/pipermail/webkit-dev/2019-September/030798.html, but > didn't get much feedback. If we can all agree on a solution, I can look into > implementing it. > > Thanks > Aakash > >> On Oct 30, 2019, at 1:03 AM, Ryosuke Niwa <rn...@webkit.org> wrote: >> >> These enhancements are great. There is one feature of the old EWS that I >> really miss, which is that I used to get emails when some EWS failed. With >> new EWS, I have to keep checking back the bugzilla to see if any of them >> have failed periodically. >> >> Can we add a feature to opt into such an email notification? Maybe a flag on >> a patch or JSON configuration file somewhere. >> >> - R. Niwa >> >> On Tue, Oct 29, 2019 at 4:05 PM Aakash Jain <aakash_j...@apple.com> wrote: >> Hi Everyone, >> >> I am happy to announce another EWS feature. >> >> From now on, in case of build failure, EWS will parse the errors and display >> them in a separate 'errors' log. You wouldn't have to search through >> thousands of lines of logs to find the error message. >> >> For example, in https://ews-build.webkit.org/#/builders/16/builds/6054, in >> step #7 WebKit failed to compile. Complete logs (stdio) are 38,000+ lines, >> and the error is not at the end of the logs. Normally, it requires some >> searching through the logs to find the relevant errors. But now, there is >> another 'errors' log, which contains just the relevant 11 lines (containing >> error and few related lines to provide additional context). >> >> Hopefully this would save some time and efforts previously spent on >> searching through the large logs. >> >> Note that this information is not displayed in status-bubble tool-tip, since >> this might be lot of text to display in the tooltip. My further plan is to >> make this information more readily available, by adding it to a custom >> designed page which will open on clicking the status bubble >> https://webkit.org/b/197522 >> >> Please let me know if you notice any issues or have any feedback. >> >> Thanks >> Aakash >> >> Reference: https://webkit.org/b/203418 >> _______________________________________________ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> https://lists.webkit.org/mailman/listinfo/webkit-dev >> -- >> - R. Niwa > > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
