Il giorno 14/giu/08, alle ore 01:26, Darin Adler ha scritto:
Use a less confusing name for the base class for all form controls.
It's hard to understand how HTMLGenericFormElement (a control within a
form) differs from HTMLFormElement (the form itself).
I can't agree more (for what my opinion
As with the JavaScriptCore renames, I have some WebCore renames I'd
like to do.
Take the K out of KURL.
"KURL" => "URL",
"KURLCFNet" => "URLCF",
"KURLMac" => "URLMac",
"KURL_H_" => "URL_h",
Use a less confusing name for the base class for all form controls.
It's hard to u
On Jun 13, 2008, at 4:16 PM, Maciej Stachowiak wrote:
> Should we also rename other files that use the old
> lowercase_underscore convention instead of the new MixedCase
> convention?
I do want to do those renames too.
One reason I didn't propose them yet is that many of those files
contai
These renames all sound good to me.
On Jun 13, 2008, at 3:44 PM, Darin Adler wrote:
> Change some filenames and header guards:
>
> "property_slot" => "PropertySlot",
> "scope_chain" => "ScopeChain",
> "scope_chain_mark" => "ScopeChainMark",
>
> "KJS_PROPERTY_SLOT_H" => "Property
These look good to me.
> Cut down on confusing uses of "Object" and "Imp".
Should we add the JS prefix to these, too?
Geoff
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> Do these also assume that we'd change the directory layout to match
> the SVN project folder layout? (That seems like a reasonably good
> starting point.)
Yeah.
Geoff
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/
I have some suggested name changes for JavaScriptCore code. I'll do
these with the do-webcore-rename script.
Use JS prefix and simpler names for basic types, to complement JSValue
and JSObject.
"GetterSetterImp" => "JSGetterSetter",
"NumberImp" => "JSNumberCell",
"StringImp" =>
On Jun 13, 2008, at 2:56 PM, Geoffrey Garen wrote:
>
> Thoughts on specific file moves:
Do these also assume that we'd change the directory layout to match
the SVN project folder layout? (That seems like a reasonably good
starting point.)
- Maciej
>
>
> kjs/
> -
> SourceProvider.h, S
Hi everyone,
A number of the WebKit layout tests are disabled, presumably because
at some point they would hang or crash the test tool. It's likely some
of these actually work ok now, but whoever disabled them neglected to
turn them on later. I recently re-enabled some of the disabled tests
On Jun 12, 2008, at 11:25 PM, Maciej Stachowiak wrote:
>
> Now that SquirrelFish has landed, I'd like to take a look at
> reorganizing JavaScriptCore's files and directories a bit.
>
> JavaScriptCore has the following subdirectories:
>
> API/
> VM/
> docs/
> icu/
> kjs/
> os-win32/
> pcre/
> prof
I debugged the WinLauncher http network error and it is always a
kCFErrorDomainCFNetwork error code -1001 from the CFNetwork library.
The crash on exit is at the line 235 in winlauncher.cpp: "delete gWebView;".
This pointer is being accessed with a COM call CoCreateInstance and the COM way
to fr
Hi Stephanie,
WebKit GTK+ doesn't use forks. Is it possible that you're running the
analysis tool on 'Programs/GtkLauncher'? On Unix-like platforms, this is
typically a shell script generated by libtool (part of our build system)
that invokes the real binary, which would show up as a fork in th
12 matches
Mail list logo
