[webkit-dev] Patents on WebKit?
Hello, Is there any possibility that I can accidentally infringe the patents of Apple if I create a browser based on WebKit? I know WebKit is licensed under LGPLv2, but it does not guarantee that the patents of Apple are automatically granted. So I am a bit worried. Regards, Kwang Yul Seo ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] renaming ASSERT macro
Darin Adler wrote: Well, this is a small change but also a very bad idea. Not because of compilation time, but because of the crappy Windows headers which define *a* *lot* of global stuff. E.g. the XSLT parser of WebKit won't build because there's a #define ERROR somenumber which breaks an enum definition. Or think of the famous MIN / MAX definitions, which drive every crossplatform developer insane. OK. Lets #undef those things. This solution is easy to do, leads to the smallest source diff but is a very dirty hack, which will lead to problems on WinCE, because we will include windows.h in public headers. One survival rule of Windows developers is: only include windows.h when it is really needed. So what's your argument against the clean solution (renaming)? Regards, Jörg ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] renaming ASSERT macro
On Jul 1, 2008, at 1:45 AM, Jörg Bornemann wrote: This solution is easy to do, leads to the smallest source diff but is a very dirty hack, which will lead to problems on WinCE, because we will include windows.h in public headers. Adding windows.h to Assertions.h will not cause it to be included in public headers. Assertions.h is not designed to be used in public headers; it's for internal use inside the WebKit project. And is a very dirty hack is not a technical argument. So what's your argument against the clean solution (renaming)? For one thing, I don't like the other names you suggested. We've used ASSERT for the lifetime of the WebKit project, many years. It appears in thousands of lines of code. I don't want to make a global change in that name because of a WinCE-specific issue unless there's no other solution. There are numerous examples where internal WebKit things conflict with platform headers or macros and we've been able to resolve them without renaming the WebKit things. To give one small example, we use id in WebKit even though that's a special reserved word on Mac OS X in Objective-C. We also manage to use min and max despite the definitions in windef.h. We work around these bugs in platform header design in ways that don't require us to change the bulk of the WebKit code. If your argument was that ASSERT is not a good name and you were making a case for a better name on the basis of clarity and coding style, I'd be happy to consider and debate that. Lets do the local solution in Assertions.h. Then we will have code that compiles and works on WinCE, and then we can debate the concrete merits of other solutions at our leisure. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] renaming ASSERT macro
On Jul 1, 2008, at 10:39 AM, Paul Pedriana wrote: On a related note, I would like to propose (possibly in a separate email) that the CRASH macro in Assertions.h that ASSERT uses be augmented to the following for improved debugging and portability across most platforms: That sounds like something you should put in a patch in bugs.webkit.org rather than in email! -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] How do do incremental build?
I made some changes to some GTK port-related code, specifically RenderThemeGtk.cpp. Simply running make did not cause it to be recompiled. How do I do incremental builds with proper dependency? The clean build takes forever. Josh ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] How do do incremental build?
The GTK page http://trac.webkit.org/wiki/BuildingGtk says to run autogen.sh and make. There's no mention of build-webkit. Also, when I try to run WebKitTools/Scripts/build-webkit, I get: Unsupported platform, can't determine built library locations. at /usr/local/google/WebKit2/WebKitTools/Scripts/webkitdirs.pm line 369. On Tue, Jul 1, 2008 at 2:29 PM, Mark Rowe [EMAIL PROTECTED] wrote: On 2008-07-01, at 13:36, Joshua Chia wrote: I made some changes to some GTK port-related code, specifically RenderThemeGtk.cpp. Simply running make did not cause it to be recompiled. How do I do incremental builds with proper dependency? The clean build takes forever. I would expect that re-running build-webkit would do an incremental build. - Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] How do do incremental build?
On 2008-07-01, at 14:57, Joshua Chia wrote: The GTK page http://trac.webkit.org/wiki/BuildingGtk says to run autogen.sh and make. There's no mention of build-webkit. Also, when I try to run WebKitTools/Scripts/build-webkit, I get: Try build-webkit --gtk. - Mark smime.p7s Description: S/MIME cryptographic signature ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] How do do incremental build?
Hi, could someone tell me what's the name of the main XCode project file for WebKit? Thanks, -Conrad ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] What is the Main Xcode project file for WebKit?
Conrad, You'll notice that the subject line of your message has nothing to do with the question you asked, and that your email is grouped in with the thread that you replied to. When starting a new thread, please don't hit Reply on an existing message. Create a new message instead. And to answer your question, there are three main Xcode project files: JavaScriptCore/JavaScriptCore.xcodeproj, WebCore/WebCore.xcodeproj, and WebKit/WebKit.xcodeproj. - Mark On 2008-07-01, at 15:27, Conrad Taylor wrote: Hi, could someone tell me what's the name of the main XCode project file for WebKit? Thanks, -Conrad ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev smime.p7s Description: S/MIME cryptographic signature ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Build fails on PowerMac G5 with Mac OS 10.5.4
Hi, I'm attempting to build webkit-dev from the command (i.e. build-webkit) on G5 with Mac OS X 10.5.4 I'm getting the following error message: /bin/sh -c /Users/conradwt/java.dir/projects/discover/classes/WebKit.build/Release/WebKit.build/Script-1C395DE20C6BE8ED1E52.sh ** BUILD FAILED ** The following build commands failed: WebKit: CompileC /Users/conradwt/java.dir/projects/discover/classes/WebKit.build/Release/WebKit.build/Objects-normal/ppc/WebView.o /Users/conradwt/webkit.dir/projects/WebKit/WebKit/mac/WebView/WebView.mm normal ppc objective-c++ com.apple.compilers.gcc.4_0 (1 failure) It appears that it's picking up an existing directory: /Users/conradwt/java.dir/projects/discover Thus, if anyone has any ideas, please feel free to post to the mailing list. Thanks, -Conrad ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Where's the Xcode project file for WebKit?
On Jul 1, 2008, at 3:29 PM, Conrad Taylor wrote: Hi, could someone tell me what's the name of the main Xcode project file for WebKit? Each of the projects has a separate project file. There's no overall one for the entire project. That's one of the reasons the build-webkit script exists. The most important project files are: JavaScriptCore/JavaScriptCore.xcodeproj JavaScriptGlue/JavaScriptGlue.xcodeproj WebCore/WebCore.xcodeproj WebKit/WebKit.xcodeproj -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] WebKit Fails to build in XCode 3.1
Hello, Hallo, Hei, Hola, I have been trying to build WebKit (http://webkit.org/) on my local machine and the build process keeps failing with the following reason: --- === BUILDING AGGREGATE TARGET All OF PROJECT JavaScriptCore WITH CONFIGURATION Release === Checking Dependencies... ** BUILD FAILED ** The following build commands failed: JavaScriptCore: Ld /Users/samueljd/WebKit/WebKitBuild/Release/ JavaScriptCore.framework/Versions/A/JavaScriptCore normal i386 jsc: Ld /Users/samueljd/WebKit/WebKitBuild/Release/jsc normal i386 (2 failures) --- Procedure: 1) Check out WebKit source from the SVN repository: svn checkout http://svn.webkit.org/repository/webkit/trunk WebKit Build revision that was checked out: 34932 2) Build Source on local machine: WebKit/WebKitTools/Scripts/build-webkit This command run's a perl script that should build the target. Result: The build process fails and gives the aforementioned reason above as the cause of failure :-( According the the build status information at http://build.webkit.org/one_box_per_builder build 34932 has failed. - Does this mean that it's not possible to do a local build? - Also, does anyone know what the general problem could be? Kindest regards, Sam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] WebKit Fails to build in XCode 3.1
On 2008-07-01, at 16:12, Samuel Davis wrote: Hello, Hallo, Hei, Hola, I have been trying to build WebKit (http://webkit.org/) on my local machine and the build process keeps failing with the following reason: === BUILDING AGGREGATE TARGET All OF PROJECT JavaScriptCore WITH CONFIGURATION Release === Checking Dependencies... ** BUILD FAILED ** The following build commands failed: JavaScriptCore: Ld /Users/samueljd/WebKit/WebKitBuild/Release/ JavaScriptCore.framework/Versions/A/JavaScriptCore normal i386 jsc: Ld /Users/samueljd/WebKit/WebKitBuild/Release/jsc normal i386 (2 failures) These are not error messages themselves, they are only indicative of errors earlier in the build process. To see the error messages themselves you should find where the two failing commands were executed earlier in the build. According the the build status information at http://build.webkit.org/one_box_per_builder build 34932 has failed. - Does this mean that it's not possible to do a local build? Yes, that means the build was broken in that revision. It has since been fixed, so after svn uping you should be good to go. - Mark smime.p7s Description: S/MIME cryptographic signature ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] How do do incremental build?
On 2008-07-01, at 16:49, Christian Dywan wrote: Am Tue, 01 Jul 2008 15:20:31 -0700 schrieb Mark Rowe [EMAIL PROTECTED]: On 2008-07-01, at 14:57, Joshua Chia wrote: The GTK page http://trac.webkit.org/wiki/BuildingGtk says to run autogen.sh and make. There's no mention of build-webkit. Also, when I try to run WebKitTools/Scripts/build-webkit, I get: Try build-webkit --gtk. - Mark Actually running ./autogen.sh and make in the root folder is the recommended way of building the gtk port of WebKit. This is exactly what build-webkit --gtk does, only it doesn't clutter the tree with build gunk. What reason is there for the Gtk port to be different in this build step than all of the other ports? - Mark smime.p7s Description: S/MIME cryptographic signature ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Clarification on developing an embedded browser in PPC platform
Hi, I am assigned to develop an embedded web browser in PPC platform. I would like to know the feasibility of the same, the support for HTML 4.01(except for cross frames),XHTML,CSS,JavaScript,AJAX,DOM(basic) etc are needed. Can you guys please help me in finding out a place to get the source and the possible places where I can tweak in this to compile for PPC ? Any points on customizing for the specific hardware with framebuffer manipulation, is also highly appreciated. Thanks, DSai ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] How do do incremental build?
Josh, Perhaps you should find out why this command is failing: rm: cannot remove `/usr/local/WebKit2/WebKitBuild/Release/WebCore': Is a directory I'd suggest running rm -rf WebKitBuild, then trying to build again. Dave On Tue, 7/1/08, Joshua Chia [EMAIL PROTECTED] wrote: That didn't work either: Josh [EMAIL PROTECTED]:/usr/local/WebKit2/WebKitTools/Scripts$* ./build-webkit --gtk rm: cannot remove `/usr/local/WebKit2/WebKitBuild/Release/WebCore': Is a directory Calling configure in /usr/local/WebKit2/WebKitBuild/Release checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for gawk... gawk checking whether make sets $(MAKE)... yes configure: error: source directory already configured; run make distclean there first Failed to setup build environment using 'autotools'! [EMAIL PROTECTED]:/usr/local/WebKit2/WebKitTools/Scripts$* pushd ../.. /usr/local/WebKit2 /usr/local/WebKit2/WebKitTools/Scripts [EMAIL PROTECTED]:/usr/local/WebKit2$* WebKitTools/Scripts/build-webkit --gtk rm: cannot remove `/usr/local/WebKit2/WebKitBuild/Release/WebCore': Is a directory Calling configure in /usr/local/WebKit2/WebKitBuild/Release checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for gawk... gawk checking whether make sets $(MAKE)... yes configure: error: source directory already configured; run make distclean there first Failed to setup build environment using 'autotools'! On Tue, Jul 1, 2008 at 3:20 PM, Mark Rowe [EMAIL PROTECTED] wrote: On 2008-07-01, at 14:57, Joshua Chia wrote: The GTK page http://trac.webkit.org/wiki/BuildingGtk says to run autogen.sh and make. There's no mention of build-webkit. Also, when I try to run WebKitTools/Scripts/build-webkit, I get: Try build-webkit --gtk. - Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] How do do incremental build?
I wasn't expecting to have to run autogen.sh for incremental builds, so I just ran make at first. It works if I run autogen.sh followed by make, so I have a solution. On Tue, Jul 1, 2008 at 7:30 PM, David Kilzer [EMAIL PROTECTED] wrote: Josh, Perhaps you should find out why this command is failing: rm: cannot remove `/usr/local/WebKit2/WebKitBuild/Release/WebCore': Is a directory I'd suggest running rm -rf WebKitBuild, then trying to build again. Dave On Tue, 7/1/08, Joshua Chia [EMAIL PROTECTED] wrote: That didn't work either: Josh [EMAIL PROTECTED]:/usr/local/WebKit2/WebKitTools/Scripts$* ./build-webkit --gtk rm: cannot remove `/usr/local/WebKit2/WebKitBuild/Release/WebCore': Is a directory Calling configure in /usr/local/WebKit2/WebKitBuild/Release checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for gawk... gawk checking whether make sets $(MAKE)... yes configure: error: source directory already configured; run make distclean there first Failed to setup build environment using 'autotools'! [EMAIL PROTECTED]:/usr/local/WebKit2/WebKitTools/Scripts$* pushd ../.. /usr/local/WebKit2 /usr/local/WebKit2/WebKitTools/Scripts [EMAIL PROTECTED]:/usr/local/WebKit2$* WebKitTools/Scripts/build-webkit --gtk rm: cannot remove `/usr/local/WebKit2/WebKitBuild/Release/WebCore': Is a directory Calling configure in /usr/local/WebKit2/WebKitBuild/Release checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for gawk... gawk checking whether make sets $(MAKE)... yes configure: error: source directory already configured; run make distclean there first Failed to setup build environment using 'autotools'! On Tue, Jul 1, 2008 at 3:20 PM, Mark Rowe [EMAIL PROTECTED] wrote: On 2008-07-01, at 14:57, Joshua Chia wrote: The GTK page http://trac.webkit.org/wiki/BuildingGtk says to run autogen.sh and make. There's no mention of build-webkit. Also, when I try to run WebKitTools/Scripts/build-webkit, I get: Try build-webkit --gtk. - Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
