Re: [webkit-dev] JavaScript bindings changed to call scriptExecutionContext virtual function?

2009-08-02 Thread Maciej Stachowiak
On Aug 2, 2009, at 2:44 AM, Adam Barth wrote: On Sun, Aug 2, 2009 at 2:09 AM, Darin Adler wrote: On Aug 2, 2009, at 2:05 AM, Adam Barth wrote: In any case: https://bugs.webkit.org/show_bug.cgi?id=27931 I'll have a patch shortly. Please let me know if there are other call sites you'd

Re: [webkit-dev] JavaScript bindings changed to call scriptExecutionContext virtual function?

2009-08-02 Thread Dimitri Glazkov
In this case, we could probably reuse the isNodeSubType from CodeGeneratorV8.pm (http://trac.webkit.org/browser/trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm#L337), which in turn uses FindParentsRecursively from CodeGenerator.pm (http://trac.webkit.org/browser/trunk/WebCore/bindings/scripts/Cod

[webkit-dev] what's purpose of the functions Branch(Add Sub Mul)32 in MacroAssembler ?

2009-08-02 Thread Felix long
Hi: I'm trying to port jit of JavaScriptCore to mips, but I failed to implement Branch(Add Sub Mul)32 for mips since I don't know a simple way to do overflow detection on MIPS like ARM or X86. is it possible to remove these Overflow detect in jit runtime? or who can tell me a simple way to do O

Re: [webkit-dev] JavaScript bindings changed to call scriptExecutionContext virtual function?

2009-08-02 Thread Adam Barth
On Sun, Aug 2, 2009 at 2:09 AM, Darin Adler wrote: > On Aug 2, 2009, at 2:05 AM, Adam Barth wrote: > >> In any case: >> >>    https://bugs.webkit.org/show_bug.cgi?id=27931 >> >> I'll have a patch shortly. Please let me know if there are other call >> sites you'd like changed. > > Thanks! Once you p

Re: [webkit-dev] JavaScript bindings changed to call scriptExecutionContext virtual function?

2009-08-02 Thread Darin Adler
On Aug 2, 2009, at 2:05 AM, Adam Barth wrote: In any case: https://bugs.webkit.org/show_bug.cgi?id=27931 I'll have a patch shortly. Please let me know if there are other call sites you'd like changed. Thanks! Once you pointed out this was not due to a recent change, I had resolved to

Re: [webkit-dev] JavaScript bindings changed to call scriptExecutionContext virtual function?

2009-08-02 Thread Adam Barth
On Sun, Aug 2, 2009 at 1:45 AM, Adam Barth wrote: > On Sun, Aug 2, 2009 at 1:41 AM, Adam Barth wrote: >> On Sun, Aug 2, 2009 at 1:13 AM, Darin Adler wrote: >>> I noticed that many JavaScript binding implementations are now calling the >>> virtual function scriptExecutionContext on DOM nodes. This s

Re: [webkit-dev] JavaScript bindings changed to call scriptExecutionContext virtual function?

2009-08-02 Thread Adam Barth
On Sun, Aug 2, 2009 at 1:41 AM, Adam Barth wrote: > On Sun, Aug 2, 2009 at 1:13 AM, Darin Adler wrote: >> I noticed that many JavaScript binding implementations are now calling the >> virtual function scriptExecutionContext on DOM nodes. This should never be >> done! That's a virtual function, so i

Re: [webkit-dev] JavaScript bindings changed to call scriptExecutionContext virtual function?

2009-08-02 Thread Adam Barth
On Sun, Aug 2, 2009 at 1:13 AM, Darin Adler wrote: > I noticed that many JavaScript binding implementations are now calling the > virtual function scriptExecutionContext on DOM nodes. This should never be > done! That's a virtual function, so it's not as fast as calling document(). > The virtual No

[webkit-dev] JavaScript bindings changed to call scriptExecutionContext virtual function?

2009-08-02 Thread Darin Adler
I noticed that many JavaScript binding implementations are now calling the virtual function scriptExecutionContext on DOM nodes. This should never be done! That's a virtual function, so it's not as fast as calling document(). The virtual Node::scriptExecutionContext() function should be mad