Re: [webkit-dev] Towards a commit-queue

2009-08-03 Thread Eric Seidel
OK, per the discussion, I will add a commit-queue=? flag for Adam's testing. If we like it, we can keep it. If not, we can kill it. -eric On Mon, Aug 3, 2009 at 9:43 AM, Maciej Stachowiak wrote: > > On Aug 1, 2009, at 8:41 PM, Adam Barth wrote: > > On Sat, Aug 1, 2009 at 1:13 PM, David Kilzer

Re: [webkit-dev] initializing protected variable in a subclass

2009-08-03 Thread David Hyatt
Make your base class constructor take the role as an argument. Then the subclasses can just pass in the value they want to use to initialize it e.g., AccessibilityObject(AccessibilityRole role) : m_role(role) { } and then in the subclass AccessibilityImageMapLink() : AccessibilityObject(W

[webkit-dev] initializing protected variable in a subclass

2009-08-03 Thread Chris Fleizach
I have added protected: AccessibilityRole m_role; to AccessibilityObject.h I want to initialize that variable in subclasses of AccessibilityObject, like so AccessibilityImageMapLink::AccessibilityImageMapLink() : m_role(WebCoreLinkRole) but the compiler says /Volumes/data/WebKit

Re: [webkit-dev] SLL_Pop list is not checked for NULL

2009-08-03 Thread Luka Napotnik
Dne 03.08.2009 (pon) ob 09:51 -0700 je Darin Adler zapisal(a): > On Aug 3, 2009, at 5:00 AM, Luka Napotnik wrote: > > > In JavaScriptCore/wtf/FastMalloc.cpp:696 > > > > The list should be checked for NULL. > > No, that’s incorrect. The code is fine as it is. There’s only one > caller and that c

Re: [webkit-dev] SLL_Pop list is not checked for NULL

2009-08-03 Thread Darin Adler
On Aug 3, 2009, at 5:00 AM, Luka Napotnik wrote: In JavaScriptCore/wtf/FastMalloc.cpp:696 The list should be checked for NULL. No, that’s incorrect. The code is fine as it is. There’s only one caller and that caller guarantees that neither list nor *list is 0. Is there some reason you thi

Re: [webkit-dev] Towards a commit-queue

2009-08-03 Thread Maciej Stachowiak
On Aug 1, 2009, at 8:41 PM, Adam Barth wrote: On Sat, Aug 1, 2009 at 1:13 PM, David Kilzer wrote: Either we should change the review process to only set the review+ flag if the patch is ready to go with zero modifications, or we should use the commit+ flag to signify that. I could go eit

Re: [webkit-dev] Reporting exceptions from worker context to users

2009-08-03 Thread Patrick Mueller
Drew Wilson wrote: OK, I really wanted to gloss over this, but now Jeremy's going to make me elaborate :) There are a few things I think we will eventually need to support worker development: 1) Some way to print out the values of things in a worker's global scope. 2) Similar debugging support f

Re: [webkit-dev] Towards a commit-queue

2009-08-03 Thread Joe Mason
Adam Barth wrote: On Sat, Aug 1, 2009 at 1:13 PM, David Kilzer wrote: Either we should change the review process to only set the review+ flag if the patch is ready to go with zero modifications, or we should use the commit+ flag to signify that. I could go either way on this. I don't like th

[webkit-dev] SLL_Pop list is not checked for NULL

2009-08-03 Thread Luka Napotnik
In JavaScriptCore/wtf/FastMalloc.cpp:696 The list should be checked for NULL. Eg. static inline void *SLL_Pop(void **list) { if (!list || !(*list)) return NULL; void *result = *list; *list = SLL_Next(*list); return result; } Greets, Luka _

[webkit-dev] click() method for anchor and img elements in WebKit API

2009-08-03 Thread Piotr Dobrogost
Hi According to https://developer.mozilla.org/en/DOM/element.click Gecko does not support click() method on some elements (like anchor or img). Does WebKit support click() method on anchor and img elements? If not are there any plans to support it and is it possible to implement this functionalit