Re: [webkit-dev] Invoking script from NPAPI plugin

2010-03-10 Thread Ohayon, Gil
Thanks Darin. Can you please give me a pointer in WebCore where to look for the bug, so I can start look into it myself. Thanks, Gil On 3/10/10 3:23 PM, "Darin Adler" wrote: On Mar 10, 2010, at 12:57 PM, Ohayon, Gil wrote: > I have a NPAPI plugin which I wish to use to push updates into a w

Re: [webkit-dev] Invoking script from NPAPI plugin

2010-03-10 Thread Darin Adler
On Mar 10, 2010, at 12:57 PM, Ohayon, Gil wrote: > I have a NPAPI plugin which I wish to use to push updates into a web page. > The plugin get’s updates from a remote process and generate JS code which is > passed back to the web page using NPN_Invoke or NPN_Evaluate. My problem is > that page

Re: [webkit-dev] what is sentencegranularity?

2010-03-10 Thread Darin Adler
On Mar 10, 2010, at 1:05 PM, Ojan Vafai wrote: > The topic of sentence granularity selections came up in > https://bugs.webkit.org/show_bug.cgi?id=33413. I'm trying to understand, > moving forward, how to test the correct behavior for sentence granularity. > > As best I can tell, it's not a Mac

Re: [webkit-dev] what is sentencegranularity?

2010-03-10 Thread Maciej Stachowiak
On Mar 10, 2010, at 1:05 PM, Ojan Vafai wrote: The topic of sentencegranularity selections came up in https://bugs.webkit.org/show_bug.cgi?id=33413 . I'm trying to understand, moving forward, how to test the correct behavior for sentencegranularity. As best I can tell, it's not a Mac platfo

Re: [webkit-dev] Why I'm reviewing patches outside my area (and why you should too)

2010-03-10 Thread Alex Milowski
On Tue, Mar 9, 2010 at 1:17 PM, David Hyatt wrote: > > On Mar 9, 2010, at 1:45 PM, Adam Barth wrote: > >> >>  (1) The patch needs to be reviewed by David Hyatt.   David Hyatt >> appears to be a bottleneck in the project because he's an expert on a >> number of components that no one else understan

[webkit-dev] what is sentencegranularity?

2010-03-10 Thread Ojan Vafai
The topic of sentencegranularity selections came up in https://bugs.webkit.org/show_bug.cgi?id=33413. I'm trying to understand, moving forward, how to test the correct behavior for sentencegranularity. As best I can tell, it's not a Mac platform-ism. SentenceGranularity is not supported in NSTextV

[webkit-dev] Invoking script from NPAPI plugin

2010-03-10 Thread Ohayon, Gil
Hi, I am not sure this is the right place for this type of question, so please let me know... I have a NPAPI plugin which I wish to use to push updates into a web page. The plugin get's updates from a remote process and generate JS code which is passed back to the web page using NPN_Invoke or

Re: [webkit-dev] Why I'm reviewing patches outside my area (and why you should too)

2010-03-10 Thread Peter Kasting
On Tue, Mar 9, 2010 at 11:45 PM, Zoltan Herczeg wrote: > > It's also a big help when peers (which aren't necessarily WebKit > > reviewers) > > look over it and give review-style feedback as well. Especially when > said > > peers know more about that code than any of the official reviewers. > > Is

Re: [webkit-dev] Questions regarding memory debugging

2010-03-10 Thread Darin Adler
On Mar 10, 2010, at 11:48 AM, Zoltan Herczeg wrote: > I have a technique to capture ref/deref problems with gdb. When the object is > created (inside the object constructor), I just put a write break point > to the address of m_refCount: "watch this->m_refCount" in gdb. The backtrace > can be in

Re: [webkit-dev] Questions regarding memory debugging

2010-03-10 Thread Zoltan Herczeg
> But in cases like the SharedBuffer one, there is no mystery about who > allocated the memory. The mystery is typically who is holding on to a > reference to it. I have a technique to capture ref/deref problems with gdb. When the object is created (inside the object constructor), I just put a wr

Re: [webkit-dev] Questions regarding memory debugging

2010-03-10 Thread David Levin
On Wed, Mar 10, 2010 at 11:27 AM, Darin Adler wrote: > On Mar 10, 2010, at 11:15 AM, Mike Marchywka wrote: > > > I haven't looked at this code but is SharedBuffer thread safe etc? > > SharedBuffer uses RefCounted, an implementation that works only on a single > thread, as opposed to the slower Cr

Re: [webkit-dev] Questions regarding memory debugging

2010-03-10 Thread Darin Adler
On Mar 10, 2010, at 11:15 AM, Mike Marchywka wrote: > I haven't looked at this code but is SharedBuffer thread safe etc? SharedBuffer uses RefCounted, an implementation that works only on a single thread, as opposed to the slower CrossThreadRefCounted. We can test your guess about the memory pr

Re: [webkit-dev] Questions regarding memory debugging

2010-03-10 Thread Mike Marchywka
 But more importantly, how would this help with the SharedBuffer problem? It seems like a separate topic. > > We have memory tools on Mac OS X that group allocations by the call stack > when an object is allocated, and we have come up with scripts that help us > put allocations into “areas” a

Re: [webkit-dev] Questions regarding memory debugging

2010-03-10 Thread Greg Simon
While we post the source code to every release of webOS, we have held back in posting the changes directly to webkit org for several reasons: * webOS versions 1.0.x-1.3.x have been based on webkit3, and the code on webkit-trunk has changed significantly since then * many changes we have

Re: [webkit-dev] Non adjacent cells selection in HTML tables

2010-03-10 Thread Alexey Proskuryakov
On 10.03.2010, at 0:49, Davide Ficano wrote: I can do that on Firefox using document.createRange() and window.getSelection().addRange() but it seems not supported on Webkit. WebKit doesn't support disjoint selections, that's correct. The addRange method is exposed, but its behavior is some

Re: [webkit-dev] Questions regarding memory debugging

2010-03-10 Thread Darin Adler
On Mar 10, 2010, at 10:06 AM, Greg Simon wrote: > This would be a really great topic for the webkit meeting in April. At Palm > we spend a significant amount of development time dealing with memory > “growth” (not so much leaks). Google perf tools has worked very well for us > on desktop as it

Re: [webkit-dev] Questions regarding memory debugging

2010-03-10 Thread Greg Simon
This would be a really great topic for the webkit meeting in April. At Palm we spend a significant amount of development time dealing with memory "growth" (not so much leaks). Google perf tools has worked very well for us on desktop as it gives the complete call stack showing how the allocatio

Re: [webkit-dev] Questions regarding memory debugging

2010-03-10 Thread Darin Adler
On Mar 9, 2010, at 8:56 PM, Holger Freyther wrote: > Now SharedBuffer is refcounted and can only "leak" if someone is holding a > reference to it and this is where stuff gets tricky. Besides manually > searching the tree and adding printf's all over has anyone found a better way > of doing this

Re: [webkit-dev] gdb 7.0 [Re: Questions regarding memory debugging]

2010-03-10 Thread Evan Martin
On Wed, Mar 10, 2010 at 9:06 AM, Darin Adler wrote: > On Mar 10, 2010, at 8:47 AM, Evan Martin wrote: > >> I guess this file should probably live in the WebCore tree somewhere. I >> hadn't gotten around to it because I wasn't sure where it belonged. If >> anyone has a good idea where it should g

Re: [webkit-dev] gdb 7.0 [Re: Questions regarding memory debugging]

2010-03-10 Thread Darin Adler
On Mar 10, 2010, at 8:47 AM, Evan Martin wrote: > I guess this file should probably live in the WebCore tree somewhere. I > hadn't gotten around to it because I wasn't sure where it belonged. If anyone > has a good idea where it should go I'll commit it. In WebKitTools, either at the top level,

Re: [webkit-dev] Implementation of 3d transforms in webkit ?

2010-03-10 Thread Simon Fraser
On Mar 10, 2010, at 1:38 AM, Aneesh Bhasin wrote: > Hi all, > > I am new to webkit code-base and am trying to delve a bit deeper into > webkit code and could see that webkit 3d transformations are > implemented in > WebCore/platform/graphics/transforms/TransformationMatrix.cpp. > > Is there any

[webkit-dev] gdb 7.0 [Re: Questions regarding memory debugging]

2010-03-10 Thread Evan Martin
On Wed, Mar 10, 2010 at 12:07 AM, Holger Freyther wrote: > Zoltan has mentioned gdb on irc and I started to wonder how far we can get > with GDB's python support in 7.0. Maybe we could create a set of scripts to > track lifetime using GDB? I'm going to explore this option maybe later today > but w

Re: [webkit-dev] Unofficial reviews (WAS: Why I'm reviewing patches outside my area (and why you should too))

2010-03-10 Thread Jeremy Orlow
On Wed, Mar 10, 2010 at 1:16 PM, Adam Treat wrote: > On Wednesday 10 March 2010 07:06:16 am Jeremy Orlow wrote: > > I can give you a success story though: michaeln is probably the most > > qualified reviewer of WebSQLDatabase code these days. He looks at most > > patches that go by, and I think

Re: [webkit-dev] Unofficial reviews (WAS: Why I'm reviewing patches outside my area (and why you should too))

2010-03-10 Thread Adam Treat
On Wednesday 10 March 2010 07:06:16 am Jeremy Orlow wrote: > I can give you a success story though: michaeln is probably the most > qualified reviewer of WebSQLDatabase code these days. He looks at most > patches that go by, and I think on average he offers more and better > comments than the offi

Re: [webkit-dev] JavaScriptCore and the V8 debugger protocol

2010-03-10 Thread jamey.hicks
Hi Jonathan, If you're only using JavaScriptCore, then it's probably better only to use support from the JavaScriptCore directory. In terms of defining a debug protocol, you're right -- it would be helpful if the debug portion of the protocol was focused on the javascript engines. WebCore is

[webkit-dev] Unofficial reviews (WAS: Why I'm reviewing patches outside my area (and why you should too))

2010-03-10 Thread Jeremy Orlow
On Wed, Mar 10, 2010 at 7:45 AM, Zoltan Herczeg wrote: > Hi, > > > It's also a big help when peers (which aren't necessarily WebKit > > reviewers) > > look over it and give review-style feedback as well. Especially when > said > > peers know more about that code than any of the official reviewers

Re: [webkit-dev] Announcing new port: EFL

2010-03-10 Thread Miroslaw Szymanski
Hello, I'm Mirek and I'm a software engineer at Samsung Poland R&D Center. My team is also involved in the WebKit-EFL port development. I've been personally working with Gustavo and Rafael from ProFUSION and I think it has been a productive cooperation so far. We believe that the EFL platform h

[webkit-dev] Implementation of 3d transforms in webkit ?

2010-03-10 Thread Aneesh Bhasin
Hi all, I am new to webkit code-base and am trying to delve a bit deeper into webkit code and could see that webkit 3d transformations are implemented in WebCore/platform/graphics/transforms/TransformationMatrix.cpp. Is there any reason for not using a library (e.g. clutter) to perform these tran

[webkit-dev] Non adjacent cells selection in HTML tables

2010-03-10 Thread Davide Ficano
I would like to be able to select *non* adjacent cells inside a . I can do that on Firefox using document.createRange() and window.getSelection().addRange() but it seems not supported on Webkit. On WebKit I was able to **only** select adjacent cells for a table row using the technique discussed (

Re: [webkit-dev] Questions regarding memory debugging

2010-03-10 Thread Holger Freyther
On Wednesday 10 March 2010 05:56:27 Holger Freyther wrote: > HI All, > > I'm currently running the iexploder tests on GtkLauncher and I'm observing > a growth in memory usage of that process. I have used the GNOME memprof > utilitiy to look at it and the best candidate for the "leak" is > SharedBu