Re: [webkit-dev] Review tool changes

2010-09-19 Thread Adam Barth
On Thu, Sep 16, 2010 at 5:33 PM, Darin Adler wrote: >    3) I suggest you make your review tool the default at "...&action=review" > and move the old style review tool to another URL; we can put a link in yours. I've moved the new tool from Pretty Diff to Review Patch. Let me know if you still

Re: [webkit-dev] Review tool changes

2010-09-19 Thread David Kilzer
On Sep 17, 2010, at 6:38 AM, Mike Pinkerton wrote: > On Fri, Sep 17, 2010 at 2:39 AM, Adam Barth wrote: > >> The tool has some problems on iPad. The issue is the bottom toolbar >> uses position: fixed, which seems to be frozen to the initial viewport >> on iPad. When you scroll, the bar stays

Re: [webkit-dev] Canvas component in Bugzilla

2010-09-19 Thread David Kilzer
On Sep 14, 2010, at 10:22 PM, Darin Adler wrote: > On Sep 14, 2010, at 5:54 PM, Andreas Kling wrote: > >> I propose we add a "Canvas" component in Bugzilla. Thoughts? > > Sounds OK to me. Done. Dave -- Sent from my iPhone 4 ___ webkit-dev mailing l

Re: [webkit-dev] map.d.co.il broken - back out r66156?

2010-09-19 Thread Andy Estes
Hi Jeremy, I'm working on this. Thanks for bringing it to my attention! -Andy On Sep 19, 2010, at 2:17 AM, Jeremy Moskovich wrote: > Thanks Maciej, > > The original bug had no information on the sites that were fixed, very good > to hear that this improves compatibility! > > Can you comment

Re: [webkit-dev] Path::createEllipse() - why not leverage port paths?

2010-09-19 Thread Andreas Kling
On 09/19/2010 11:28 AM, ext Nikolas Zimmermann wrote: To summarize: Let's go for platform specific variants of Path::createCircle/Path::createEllipse, but change the DRT dumps. For primitive shapes, we shouldn't dump any path data _at all_ (eg. circle / ellipse / rect etc) but instead just dump "

Re: [webkit-dev] Path::createEllipse() - why not leverage port paths?

2010-09-19 Thread Nikolas Zimmermann
Am 19.09.2010 um 09:41 schrieb Dirk Schulze: Am Sonntag, den 19.09.2010, 09:32 +0200 schrieb Dirk Schulze: The main reason is DumpRenderTree. Let me rephrase it: The only reason why we still use this logic is DumpRenderTree. If we use the Path::createEllipse logic of the different platforms

Re: [webkit-dev] map.d.co.il broken - back out r66156?

2010-09-19 Thread Jeremy Moskovich
Thanks Maciej, The original bug had no information on the sites that were fixed, very good to hear that this improves compatibility! Can you comment on whether this is being actively worked on? Or is this waiting for someone to pick it up? Just want to make sure we can fix this regression ASAP.

Re: [webkit-dev] Path::createEllipse() - why not leverage port paths?

2010-09-19 Thread Dirk Schulze
Am Sonntag, den 19.09.2010, 09:32 +0200 schrieb Dirk Schulze: > The main reason is DumpRenderTree. Let me rephrase it: The only reason why we still use this logic is DumpRenderTree. > If we use the Path::createEllipse > logic of the different platforms, we end up with different LayoutTest > result

Re: [webkit-dev] Path::createEllipse() - why not leverage port paths?

2010-09-19 Thread Dirk Schulze
The main reason is DumpRenderTree. If we use the Path::createEllipse logic of the different platforms, we end up with different LayoutTest results on SVG between platform, since we create them by traversing the path data of the certain platform. So changing this is painful and causes a lot of new p