Re: [webkit-dev] An update on new-run-webkit-tests

2011-04-07 Thread Dirk Pranke
Hi Maciej, Thanks for clarifying your concerns. I will address them a little out-of-order, because I think we probably agree on the important things even if we disagree on the less-important or more theoretical things. First, as far as the "future" discoveries go, I agree we should try to fix as

Re: [webkit-dev] Disallowing modal dialogs during unload events

2011-04-07 Thread Sreeram Ramachandran
On Thu, Apr 7, 2011 at 10:54, Maciej Stachowiak wrote: > Is there data on: > - The user impact of modal dialogs being fired from before unload, unload or > page hide - how often does this happen? > - The Web compatibility impact of removing this functionality (are the sites > that do it using it

Re: [webkit-dev] Disallowing modal dialogs during unload events

2011-04-07 Thread Maciej Stachowiak
Is there data on: - The user impact of modal dialogs being fired from before unload, unload or page hide - how often does this happen? - The Web compatibility impact of removing this functionality (are the sites that do it using it for seemingly legitimate reasons)? I can think of two ways to

Re: [webkit-dev] Disallowing modal dialogs during unload events

2011-04-07 Thread Darin Fisher
As you know, I'm a very strong advocate of this change. I think even if other ports aren't interested in experimenting with this change at the current time, that we should proceed to experiment with it in Chromium. I would very much like us to have data about how many sites are impacted, so that

Re: [webkit-dev] An update on new-run-webkit-tests

2011-04-07 Thread Maciej Stachowiak
On Apr 6, 2011, at 10:33 PM, Dirk Pranke wrote: > > I'm not sure I understand you, but if I do, this is what I was > attempting to talk about in the paragraph above, about expecting some > tests to be flaky or failing under NRWT simply because NRWT isn't > exactly identical to ORWT. NRWT may be

Re: [webkit-dev] An update on new-run-webkit-tests

2011-04-07 Thread Andras Becsi
Great to see the progress with new-run-webkit-tests! We have been testing the new script for a while now on the QtWebKit: http://webkit.sed.hu/buildbot/waterfall?show=x86-32%20Linux%20Qt%20Release%20new-run-webkit-tests We do not have a test_expectations file yet, but this should change soon. O