[webkit-dev] How to change an .exp file?

[王显著]

Hi,

I'm developing on Linux. One of my patch failed to build on Windows because
I haven't changed the related .exp file (e.g. JavaScriptCore.exp).

I just did the following on Linux to update the file:
  1. nm xx.o | grep  T  | sed 's/^.\{19\}/_/'
  2. replace related lines in the .exp file with the above output

Though it works I guess it's not the correct way. What's the correct way?

Thanks,
Xianzhu
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Building Chromium port of WebKit on Windows

[Mikhail Naganov]

OK, following setup instructions for the buildbot, I was able to
compile the port under Windows. Thanks again, Dimirti!

I've updated the Wiki page: https://trac.webkit.org/wiki/Chromium

On Thu, Aug 25, 2011 at 20:53, Peter Kasting pkast...@chromium.org wrote:
 On Thu, Aug 25, 2011 at 10:31 AM, Dimitri Glazkov dglaz...@chromium.org
 wrote:

 FWIW, I use the former exclusively on Mac.

 Yes, please regard my comments as only applying to Windows.
 PK
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] How to change an .exp file?

[Darin Adler]

On Aug 26, 2011, at 1:50 AM, Xianzhu Wang (王显著) wrote:

 I'm developing on Linux. One of my patch failed to build on Windows because I 
 haven't changed the related .exp file (e.g. JavaScriptCore.exp).
 
 I just did the following on Linux to update the file:
   1. nm xx.o | grep  T  | sed 's/^.\{19\}/_/'
   2. replace related lines in the .exp file with the above output
 
 Though it works I guess it's not the correct way. What's the correct way?

Those exp files are used only on Mac. You’ll need to get someone to compile on 
Mac or take advantage of the EWS to get a compile on Mac. The linker errors can 
tell you the symbols that should be in the .exp file.

-- Darin

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] How to change an .exp file?

[Scott Graham]

I believe the Windows ones are the .def files. I had to make a similar
change here: https://bugs.webkit.org/attachment.cgi?id=102529action=prettypatch
(e.g. Source/WebKit2/win/WebKit2.def and similar)

You have to be able mangle in your head it seems. I found the easiest
way was to make a simple program with the same
namespaces/classes/empty functions and then use dumpbin to see the
appropriate name. :( Maybe there's a better way someone can point out
though.

On Fri, Aug 26, 2011 at 1:50 AM, Xianzhu Wang (王显著)
wangxian...@chromium.org wrote:
 Hi,
 I'm developing on Linux. One of my patch failed to build on Windows because
 I haven't changed the related .exp file (e.g. JavaScriptCore.exp).
 I just did the following on Linux to update the file:
   1. nm xx.o | grep  T  | sed 's/^.\{19\}/_/'
   2. replace related lines in the .exp file with the above output
 Though it works I guess it's not the correct way. What's the correct way?
 Thanks,
 Xianzhu

 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] How to change an .exp file?

[Darin Adler]

On Aug 26, 2011, at 10:14 AM, Scott Graham wrote:

 Maybe there's a better way someone can point out though.

I believe that using the Windows EWS server you can get error messages that 
tell you the symbols that need to be in the def files.

-- Darin

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] How to change an .exp file?

[王显著]

Thanks everyone.

My patch already successfully builds on Mac, because of my updated .exp file
which I thought for Windows :)

I got the impression that the not updated .exp file breaks Windows build
because I saw the following error on win-ews (now I know I should fix the
.def file):

3Linking...
3 Creating library
C:\cygwin\home\buildbot\WebKitBuild\Debug\lib\JavaScriptCore.lib and object
C:\cygwin\home\buildbot\WebKitBuild\Debug\lib\JavaScriptCore.exp
3JavaScriptCore.exp : error LNK2001: unresolved external symbol private:
void __thiscall WTF::StringBuilder::reifyString(void)
(?reifyString@StringBuilder@WTF@@AAEXXZ)
3C:\cygwin\home\buildbot\WebKitBuild\Debug\bin\JavaScriptCore.dll : fatal
error LNK1120: 1 unresolved externals

On Sat, Aug 27, 2011 at 1:00 AM, Darin Adler da...@apple.com wrote:

 On Aug 26, 2011, at 1:50 AM, Xianzhu Wang (王显著) wrote:

  I'm developing on Linux. One of my patch failed to build on Windows
 because I haven't changed the related .exp file (e.g. JavaScriptCore.exp).
 
  I just did the following on Linux to update the file:
1. nm xx.o | grep  T  | sed 's/^.\{19\}/_/'
2. replace related lines in the .exp file with the above output
 
  Though it works I guess it's not the correct way. What's the correct way?

 Those exp files are used only on Mac. You’ll need to get someone to compile
 on Mac or take advantage of the EWS to get a compile on Mac. The linker
 errors can tell you the symbols that should be in the .exp file.

-- Darin


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev