[webkit-dev] Invitation to connect on LinkedIn

2011-09-29 Thread Alexander Shabanov via LinkedIn
LinkedIn Alexander Shabanov requested to add you as a connection on LinkedIn: -- stevin, I'd like to add you to my professional network on LinkedIn. Accept invitation from Alexander Shabanov http://www.linkedin.com/e/-jnbvix-gt6sy9n

Re: [webkit-dev] XCode > 4.0

2011-09-29 Thread Levi Weintraub
I know some people have been building WebKit with the 4.1 IDE, but after a cursory attempt I was only able to build from the command line. I'd also love tips from those more familiar with it :) -Levi On Thu, Sep 29, 2011 at 3:04 PM, lcerveau wrote: > HI > Apologies in advance for this newbie que

[webkit-dev] XCode > 4.0

2011-09-29 Thread lcerveau
HIApologies in advance for this newbie question. I started to have a deeper look into WebKit code for some bugs I would like to fix . In order to grasp the develop/compile/debug cycle for webkit, I did follow the instructions at https://ebkit.org/building/debug.htmlHowever it looks like Xcode 4

Re: [webkit-dev] Compile-time assertions for object sizes

2011-09-29 Thread Antti Koivisto
On Thu, Sep 29, 2011 at 9:40 PM, Andreas Kling wrote: > One idea is to add a file that would only be built on (for example) 64-bit > Mac and then at least that bot would break if an object changes size. That's > obviously not ideal though. > I like that approach as it allows you to explicitly as

Re: [webkit-dev] Compile-time assertions for object sizes

2011-09-29 Thread Darin Adler
On Sep 29, 2011, at 1:48 PM, Andreas Kling wrote: > Right, but those keywords would pertain to the struct containing the > bitfields, not InlineBox itself. Or maybe I'm misunderstanding you? Yes, I was wrong, you are right. I had lost the thread. I’m not sure we need to group bit fields in a st

Re: [webkit-dev] Compile-time assertions for object sizes

2011-09-29 Thread Andreas Kling
On Thu, Sep 29, 2011 at 10:43 PM, Darin Adler wrote: > On Sep 29, 2011, at 1:40 PM, Andreas Kling wrote: > > > Good idea in general, though it doesn't work for InlineBox since its bits > are spread across public, protected and private. > > I'm not sure it's worth losing those classifications for

Re: [webkit-dev] Compile-time assertions for object sizes

2011-09-29 Thread Darin Adler
On Sep 29, 2011, at 1:40 PM, Andreas Kling wrote: > Good idea in general, though it doesn't work for InlineBox since its bits are > spread across public, protected and private. > I'm not sure it's worth losing those classifications for the sake of the > anti-bloat mechanism. We wouldn’t have to

Re: [webkit-dev] Compile-time assertions for object sizes

2011-09-29 Thread Andreas Kling
On Thu, Sep 29, 2011 at 9:11 PM, Simon Fraser wrote: > > On Sep 29, 2011, at 11:40 AM, Andreas Kling wrote: > > > Dear WebKittens, > > > > I'd like to add some compile-time assertions for the sizes of various > objects. The motivation comes a patch fixing bloat in InlineBox[1]. > > > > There are t

Re: [webkit-dev] Compile-time assertions for object sizes

2011-09-29 Thread Simon Fraser
On Sep 29, 2011, at 11:40 AM, Andreas Kling wrote: > Dear WebKittens, > > I'd like to add some compile-time assertions for the sizes of various > objects. The motivation comes a patch fixing bloat in InlineBox[1]. > > There are two major problems with this: > > 1. The sizes will differ on 32-

Re: [webkit-dev] Compile-time assertions for object sizes

2011-09-29 Thread David Levin
On Thu, Sep 29, 2011 at 12:11 PM, Simon Fraser wrote: > > On Sep 29, 2011, at 11:40 AM, Andreas Kling wrote: > > > Dear WebKittens, > > > > I'd like to add some compile-time assertions for the sizes of various > objects. The motivation comes a patch fixing bloat in InlineBox[1]. > > > > There are

[webkit-dev] Compile-time assertions for object sizes

2011-09-29 Thread Andreas Kling
Dear WebKittens, I'd like to add some compile-time assertions for the sizes of various objects. The motivation comes a patch fixing bloat in InlineBox[1]. There are two major problems with this: 1. The sizes will differ on 32- and 64-bit platforms. 2. The sizes will differ based on compiler flag

Re: [webkit-dev] Making top-level style changes through window.internals

2011-09-29 Thread W. James MacLean
All of this discussion started with my wanting to write a layout test that changes pageScaleFactor, without incurring scroll bars in the process. The documentElement.style method below seems to be able to change, for example, background colour, but it doesn't seem to work for documentElement.style.

Re: [webkit-dev] Making top-level style changes through window.internals

2011-09-29 Thread Simon Fraser
On Sep 29, 2011, at 8:41 AM, Adam Roben wrote: > On Sep 29, 2011, at 11:37 AM, Fady Samuel wrote: > >> pageScaleFactor is a document level CSS scaling style. Often times, we'd >> like to be able to apply style at the document level when writing layout >> tests. As far as I'm aware, there's no w

Re: [webkit-dev] Making top-level style changes through window.internals

2011-09-29 Thread Adam Roben
On Sep 29, 2011, at 11:37 AM, Fady Samuel wrote: > pageScaleFactor is a document level CSS scaling style. Often times, we'd like > to be able to apply style at the document level when writing layout tests. As > far as I'm aware, there's no way to do this in javascript in a layout test? > Is thi

[webkit-dev] Making top-level style changes through window.internals

2011-09-29 Thread Fady Samuel
Hi all, pageScaleFactor is a document level CSS scaling style. Often times, we'd like to be able to apply style at the document level when writing layout tests. As far as I'm aware, there's no way to do this in javascript in a layout test? Is this correct? If so, would anyone object to exposing do