Re: [webkit-dev] Common build system (was Re: WebKit Wishes)

2013-02-05 Thread Simon Hausmann
On Monday, February 04, 2013 10:57:46 AM Maciej Stachowiak wrote: On Feb 4, 2013, at 10:46 AM, Mark Mentovai m...@chromium.org wrote: GYP was written in Python to address point (b). Python was already part of the baseline requirements on all platforms, so we already had Python available

Re: [webkit-dev] Common build system (was Re: WebKit Wishes)

2013-02-05 Thread Mark Mentovai
The parser (and the grammar) works the way it does because it’s just Python—the whole thing can be slurped in quickly by the interpreter and made available to GYP as data. It’s faster than a parser written in Python for a similar language would be, and it’d likely take a binary Python module to

Re: [webkit-dev] Gated trunk, experiences from OpenStack

2013-02-05 Thread Adam Barth
Do you know how they got rid of flakiness in their tests? We've spent a bunch of effort fixing flaky tests (and in marking the remaining flaky tests as flaky), but there's still a long tail of flakiness. I wonder if that sort of thing might be different for OpenStack if they have a different

Re: [webkit-dev] Gated trunk, experiences from OpenStack

2013-02-05 Thread Martin Robinson
On Tue, Feb 5, 2013 at 9:28 AM, Adam Barth aba...@webkit.org wrote: Do you know how they got rid of flakiness in their tests? We've spent a bunch of effort fixing flaky tests (and in marking the remaining flaky tests as flaky), but there's still a long tail of flakiness. I wonder if that

Re: [webkit-dev] Common build system (was Re: WebKit Wishes)

2013-02-05 Thread Ryosuke Niwa
On Tue, Feb 5, 2013 at 6:09 AM, Mark Mentovai m...@chromium.org wrote: The parser (and the grammar) works the way it does because it’s just Python This works great for people who like Python syntax but not for someone like myself who dislikes Python syntax. I also find it particularly

Re: [webkit-dev] Common build system (was Re: WebKit Wishes)

2013-02-05 Thread Mark Mentovai
You’re not supposed to use arbitrary Python, it’s highly discouraged. We have a linter that keeps you from doing things you’re not supposed to do (like this), but it slows things down, so it’s not part of the “standard” GYP run that developers normally use. It can run as a pre-commit script or

Re: [webkit-dev] Common build system (was Re: WebKit Wishes)

2013-02-05 Thread Eric Seidel
I'm curious if YAML was ever considered? I have very limited experience with YAML, except for Google App Engine config files. It's very python parse-able? :) On Tue, Feb 5, 2013 at 11:55 AM, Mark Mentovai m...@chromium.org wrote: You’re not supposed to use arbitrary Python, it’s highly

Re: [webkit-dev] Gated trunk, experiences from OpenStack

2013-02-05 Thread Dirk Pranke
On Tue, Feb 5, 2013 at 9:46 AM, Martin Robinson mrobin...@webkit.org wrote: On Tue, Feb 5, 2013 at 9:28 AM, Adam Barth aba...@webkit.org wrote: Do you know how they got rid of flakiness in their tests? We've spent a bunch of effort fixing flaky tests (and in marking the remaining flaky tests

Re: [webkit-dev] Common build system (was Re: WebKit Wishes)

2013-02-05 Thread Nico Weber
http://www.haskell.org/haskellwiki/Wadlers_Law On Tue, Feb 5, 2013 at 12:16 PM, Eric Seidel e...@webkit.org wrote: I'm curious if YAML was ever considered? I have very limited experience with YAML, except for Google App Engine config files. It's very python parse-able? :) On Tue, Feb 5,

Re: [webkit-dev] Common build system (was Re: WebKit Wishes)

2013-02-05 Thread Martin Robinson
On Tue, Feb 5, 2013 at 12:20 PM, Nico Weber tha...@chromium.org wrote: http://www.haskell.org/haskellwiki/Wadlers_Law I've started working on an experimental gyp build for GTK+, so I have first-hand experience as a gyp newbie editing .gyp and .gypi files. While the aesthetics of the files

Re: [webkit-dev] Gated trunk, experiences from OpenStack

2013-02-05 Thread Benjamin Poulain
On Tue, Feb 5, 2013 at 12:17 PM, Dirk Pranke dpra...@chromium.org wrote: There are two other related aspects that make our tests flaky: 1) They're very high level integration tests (mostly), which, as they cover large swaths of code in each test, are much more susceptible to flakiness than

Re: [webkit-dev] Common build system (was Re: WebKit Wishes)

2013-02-05 Thread Maciej Stachowiak
On Feb 5, 2013, at 6:09 AM, Mark Mentovai m...@chromium.org wrote: The parser (and the grammar) works the way it does because it’s just Python—the whole thing can be slurped in quickly by the interpreter and made available to GYP as data. It’s faster than a parser written in Python for a

Re: [webkit-dev] Common build system (was Re: WebKit Wishes)

2013-02-05 Thread Benjamin Poulain
On Tue, Feb 5, 2013 at 12:59 PM, Maciej Stachowiak m...@apple.com wrote: I have to say that the syntax weight of gyp files (quotes, commas, braces, brackets) makes them feel harder to read and edit than other build file formats designed for human consumption (obviously Xcode is worse). As

Re: [webkit-dev] Common build system (was Re: WebKit Wishes)

2013-02-05 Thread Mark Mentovai
The run time comparisons were based on actual comparison with available Python modules at the time. JSON was substantially slower than having the Python interpreter slurp it up on its own. In fact, GYP started out reading JSON input and we switched it to Python once we learned this. It was four

Re: [webkit-dev] Common build system (was Re: WebKit Wishes)

2013-02-05 Thread Per Bothner
On 02/05/2013 12:59 PM, Maciej Stachowiak wrote: I have to say that the syntax weight of gyp files (quotes, commas, braces, brackets) makes them feel harder to read and edit than other build file formats designed for human consumption (obviously Xcode is worse). Ant is pretty verbose as

[webkit-dev] Better syntax for GYP (Was Common build system; was Re: WebKit Wishes)

2013-02-05 Thread Ryosuke Niwa
On Tue, Feb 5, 2013 at 1:36 PM, Mark Mentovai m...@chromium.org wrote: In the end, I don’t think that the actual syntax (as opposed to the structured data that it contains) is all that important. GYP input files are fairly simple structured data consisting of very few types: dicts, lists,

Re: [webkit-dev] Better syntax for GYP (Was Common build system; was Re: WebKit Wishes)

2013-02-05 Thread Gregory Szorc
I work on the build system for Firefox and have some experience that might be worth sharing. We (Mozilla) evaluated GYP as the replacement for Makefile.in files. While we generally love the concept of GYP (assemble data structures then transform them N ways to whatever build backend/tool

Re: [webkit-dev] Gated trunk, experiences from OpenStack

2013-02-05 Thread Tim Ansell
On 6 February 2013 07:17, Dirk Pranke dpra...@chromium.org wrote: On Tue, Feb 5, 2013 at 9:46 AM, Martin Robinson mrobin...@webkit.org wrote: On Tue, Feb 5, 2013 at 9:28 AM, Adam Barth aba...@webkit.org wrote: Do you know how they got rid of flakiness in their tests? We've spent a bunch

Re: [webkit-dev] Better syntax for GYP (Was Common build system; was Re: WebKit Wishes)

2013-02-05 Thread Maciej Stachowiak
On Feb 5, 2013, at 2:01 PM, Ryosuke Niwa rn...@webkit.org wrote: Using a YAML-like syntax, we can rewrite it as: XMLName: inputs: (SHARED_INTERMEDIATE_DIR)/../dom/make_names.pl (SHARED_INTERMEDIATE_DIR)/../xml/xmlattrs.in outputs: XMLNames.cpp

Re: [webkit-dev] Common build system (was Re: WebKit Wishes)

2013-02-05 Thread Dirk Pranke
I have looked at YAML off and on over the years, and I'm not sure that it would be much of an improvement in this case. I do believe that dropping the strict python syntax could make some things easier to read. I don't have a fully-baked proposal in mind, and I don't know what the perf hit would

Re: [webkit-dev] Common build system (was Re: WebKit Wishes)

2013-02-05 Thread Ryosuke Niwa
On Tue, Feb 5, 2013 at 5:33 PM, Dirk Pranke dpra...@chromium.org wrote: I have looked at YAML off and on over the years, and I'm not sure that it would be much of an improvement in this case. I do believe that dropping the strict python syntax could make some things easier to read. I don't

Re: [webkit-dev] Gated trunk, experiences from OpenStack

2013-02-05 Thread Dirk Pranke
On Tue, Feb 5, 2013 at 3:34 PM, Tim Ansell mit...@mithis.com wrote: On 6 February 2013 07:17, Dirk Pranke dpra...@chromium.org wrote: On Tue, Feb 5, 2013 at 9:46 AM, Martin Robinson mrobin...@webkit.org wrote: On Tue, Feb 5, 2013 at 9:28 AM, Adam Barth aba...@webkit.org wrote: Do you know

Re: [webkit-dev] Gated trunk, experiences from OpenStack

2013-02-05 Thread Tim Ansell
testr is already a great way to record test runs and collect stats on them. I'd really love it if we could contribute to testr some of our flakyness stuff. Flakyness plagues all projects and having awesome tools would help a lot of people, not just us. Tim On 6 February 2013 12:55, Dirk Pranke