Re: [webkit-dev] Adding new entries to TestExpectations can be harmful

2013-05-23 Thread Dirk Pranke
I may be missing context, or just slow, but how does that link illustrate things being harmful ? It looks like you're mostly adding the bug numbers inline and/or taking skipped tests and making them flaky ? -- Dirk On Wed, May 22, 2013 at 6:11 PM, Ryosuke Niwa wrote: > And there is an overwhel

Re: [webkit-dev] Use BlinkMergeCandidate to merge/back port Blink changes

2013-05-23 Thread Ryosuke Niwa
I always post patches as my patch saying I'm merging some patch with a chromium.googlesource.com URL as in: http://trac.webkit.org/changeset/150416 In a lot of cases, I find myself fixing the patch or rewriting the patch because either the patch is wrong, doesn't conform to the WebKit style, or it

[webkit-dev] LAST CALL: Re: Unprefixing Page Visibility

2013-05-23 Thread Simon Fraser
On May 20, 2013, at 6:28 PM, Simon Fraser wrote: > Does anyone object to supporting the Page Visibility API unprefixed? > https://bugs.webkit.org/show_bug.cgi?id=102340 > > Should we keep support for the prefixed version? I hear no requests to keep the prefixed version. Does any port want it? I

Re: [webkit-dev] Use BlinkMergeCandidate to merge/back port Blink changes

2013-05-23 Thread Andreas Kling
On May 23, 2013, at 6:26 PM, Darin Adler wrote: > On May 23, 2013, at 8:42 AM, Sergio Villar Senin wrote: > >> There is an interesting question about merging fixes from Blink. Should we >> keep the original author in the ChangeLog appending the name of the merger >> maybe? > > Generally spea

Re: [webkit-dev] Use BlinkMergeCandidate to merge/back port Blink changes

2013-05-23 Thread Darin Adler
On May 23, 2013, at 8:42 AM, Sergio Villar Senin wrote: > There is an interesting question about merging fixes from Blink. Should we > keep the original author in the ChangeLog appending the name of the merger > maybe? Generally speaking, the person committing to WebKit is responsible for the

Re: [webkit-dev] Use BlinkMergeCandidate to merge/back port Blink changes

2013-05-23 Thread Sergio Villar Senin
En 21/05/13 06:06, Ryosuke Niwa escribiu: > Hi, > > We’ve added BlinkMergeCandidate keyword to Bugzilla to track any Blink > changes we might want to merge. Please add this keyword when you’re > filing a bug or posting a patch to merge a Blink change. There is an interesting question about mergi

[webkit-dev] NPOT Textures

2013-05-23 Thread SzymanskiPrzemyslaw
Hello. In WebGLRenderingContext::setupFlags() there is a line: m_isGLES2NPOTStrict = !m_context->getExtensions()->isEnabled("GL_OES_texture_npot"); My question is: why is this negation? Now NPOT textures doesn't work in WebKit but without this negation NPOT textures works fine. Is this disabli