Re: [webkit-dev] Can we disable "control reaches end of non-void function" warning on Qt?

2013-09-13 Thread Darin Adler
On Sep 13, 2013, at 10:28 AM, Alexey Proskuryakov wrote: > 13 сент. 2013 г., в 10:13, Darin Adler написал(а): > >> Since there’s no runtime guarantee that the enum will have a valid value, I >> think there needs to be a return statement outside the switch, even if we >> have ASSERT_NOT_REACHE

Re: [webkit-dev] (no subject)

2013-09-13 Thread Bem Jones-Bey
On Sep 13, 2013, at 13:12 , Ryosuke Niwa mailto:rn...@webkit.org>> wrote: Unsubscribe at https://lists.webkit.org/mailman/listinfo/webkit-dev I'm getting really tired of seeing these emails. How hard is it to open the URL attached on every email sent to this mailing list? I wonder if this is

Re: [webkit-dev] Changes in QtWebKit development

2013-09-13 Thread Brent Fulgham
On Sep 13, 2013, at 10:22 AM, Benjamin Poulain wrote: > On 9/13/13, 4:50 AM, Albisser Zeno wrote: >> As many of you have probably noticed already, we have recently been focusing >> on a project called Qt WebEngine. Our WebKit efforts have therefore been >> reduced significantly over the past w

Re: [webkit-dev] Changes in QtWebKit development

2013-09-13 Thread Benjamin Poulain
On 9/13/13, 4:50 AM, Albisser Zeno wrote: > As many of you have probably noticed already, we have recently been > focusing on a project called Qt WebEngine. Our WebKit efforts have > therefore been reduced significantly over the past weeks. > While we will keep shipping QtWebKit with Qt for the for

Re: [webkit-dev] Changes in QtWebKit development

2013-09-13 Thread Darin Adler
Oh, I see, this is about Qt joining the Blink project. I am disappointed to hear it, but now I understand. I think that once Qt WebKit reaches the point where it is not actively being worked on, it would be best to remove it. -- Darin ___ webkit-dev m

Re: [webkit-dev] Can we disable "control reaches end of non-void function" warning on Qt?

2013-09-13 Thread Darin Adler
On Sep 12, 2013, at 2:07 PM, Ryosuke Niwa wrote: > http://trac.webkit.org/changeset/155643 broke Qt build with an error saying: > > Source/JavaScriptCore/dfg/DFGGPRInfo.h:169:5: error: control reaches end of > non-void function [-Werror=return-type] > cc1plus: all warnings being treated as erro

Re: [webkit-dev] Changes in QtWebKit development

2013-09-13 Thread Alexis Menard
Hi Darin, I think he forgot to paste the link which add a bit of meat to the conversation. http://blog.qt.digia.com/blog/2013/09/12/introducing-the-qt-webengine/ Thanks. On Fri, Sep 13, 2013 at 2:03 PM, Darin Adler wrote: > On Sep 13, 2013, at 4:50 AM, Albisser Zeno > wrote: > > Qt WebEngin

Re: [webkit-dev] Changes in QtWebKit development

2013-09-13 Thread Zeno Albisser
Hi Benjamin, On Sep 13, 2013, at 7:22 PM, Benjamin Poulain wrote: > This is sad. I can understand very well, that you are not very happy about this. And I don't think anybody here took this decision lightly. > > When "modules" of Qt are put on "maintenance", it is basically a synonym to > "i

Re: [webkit-dev] Can we disable "control reaches end of non-void function" warning on Qt?

2013-09-13 Thread Darin Adler
Can someone make this more concrete by pointing to an example in WebKit where we are getting that warning with gcc, but no warning with clang? -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/web

Re: [webkit-dev] (no subject)

2013-09-13 Thread Ryosuke Niwa
Unsubscribe at https://lists.webkit.org/mailman/listinfo/webkit-dev I'm getting really tired of seeing these emails. How hard is it to open the URL attached on every email sent to this mailing list? On Fri, Sep 13, 2013 at 1:08 PM, Kabeer Kalra wrote: > I DO NOT WANT TO BE IN THE MAILING LIST >

[webkit-dev] (no subject)

2013-09-13 Thread Kabeer Kalra
I DO NOT WANT TO BE IN THE MAILING LIST ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Can we disable "control reaches end of non-void function" warning on Qt?

2013-09-13 Thread Filip Pizlo
On Sep 13, 2013, at 10:33 AM, Darin Adler wrote: > On Sep 13, 2013, at 10:31 AM, Oliver Hunt wrote: > >> We may want to hunt through the other cases of default: ASSERT_NOT_REACHED() >> and clobber those with RELEASE_ASSERT_NOT_REACHED() as well. >> >> I wonder if it would be easier to have D

Re: [webkit-dev] Announcing new port: Nix

2013-09-13 Thread Anders Carlsson
On Sep 12, 2013, at 1:58 PM, Hugo Lima wrote: > On Thu, Sep 12, 2013 at 4:14 PM, Ryosuke Niwa wrote: >> Interesting. That sounds a lot like Chromium's WebKit API layer. If I >> remember correctly, that layer had to be modified constantly as >> WebCore/WebKit code was refactored so I'm a bit wo

Re: [webkit-dev] TimerWindowWndProc and dangling page instances

2013-09-13 Thread Brent Fulgham
Hi Vincent, On Sep 13, 2013, at 1:34 AM, Van Den Berghe, Vincent wrote: > I’m embedding the Wincairo build of WebKit to generate PDF files from web > pages in an ASP.NET application. Yay! > Webkit isn’t really designed for such a scenario but with some careful > patching, a solution can be

Re: [webkit-dev] Announcing new port: Nix

2013-09-13 Thread Hugo Lima
On Fri, Sep 13, 2013 at 4:31 PM, Antonio Gomes wrote: > So will you advocate your users to use your external GitHub version or > the one in > WebKit? > > Please consider not being half upstream. It wont be half upstream, but the github repository will be for example a fallback for a working bleed

Re: [webkit-dev] Changes in QtWebKit development

2013-09-13 Thread Darin Adler
On Sep 13, 2013, at 4:50 AM, Albisser Zeno wrote: > Qt WebEngine What is that? Is it based on a fork of WebKit? -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Announcing new port: Nix

2013-09-13 Thread Antonio Gomes
So will you advocate your users to use your external GitHub version or the one in WebKit? Please consider not being half upstream. On Fri, Sep 13, 2013 at 2:37 PM, Hugo Lima wrote: > On Fri, Sep 13, 2013 at 3:00 PM, Anders Carlsson wrote: >> >> On Sep 12, 2013, at 1:58 PM, Hugo Lima wrote: >>

Re: [webkit-dev] Announcing new port: Nix

2013-09-13 Thread Hugo Lima
On Fri, Sep 13, 2013 at 3:00 PM, Anders Carlsson wrote: > > On Sep 12, 2013, at 1:58 PM, Hugo Lima wrote: > >> On Thu, Sep 12, 2013 at 4:14 PM, Ryosuke Niwa wrote: >>> Interesting. That sounds a lot like Chromium's WebKit API layer. If I >>> remember correctly, that layer had to be modified con

Re: [webkit-dev] Can we disable "control reaches end of non-void function" warning on Qt?

2013-09-13 Thread Darin Adler
On Sep 13, 2013, at 10:36 AM, Oliver Hunt wrote: > I guess there's no nice automate-able to handle everything magically. We could require either default: or DEFAULT_NOT_REACHED at ends of switches. To use DEFAULT_NOT_REACHED after a switch the cases need to use return, not break. I’m sure we c

Re: [webkit-dev] Can we disable "control reaches end of non-void function" warning on Qt?

2013-09-13 Thread Oliver Hunt
Hurk :-/ I guess there's no nice automate-able to handle everything magically. Still it would probably be good to replace the default:ASSERT_NOT_REACHED() cases at least. --Oliver On Sep 13, 2013, at 10:33 AM, Darin Adler wrote: > On Sep 13, 2013, at 10:31 AM, Oliver Hunt wrote: > >> We ma

Re: [webkit-dev] Can we disable "control reaches end of non-void function" warning on Qt?

2013-09-13 Thread Darin Adler
On Sep 13, 2013, at 10:31 AM, Oliver Hunt wrote: > We may want to hunt through the other cases of default: ASSERT_NOT_REACHED() > and clobber those with RELEASE_ASSERT_NOT_REACHED() as well. > > I wonder if it would be easier to have DEFAULT_NOT_REACHED() and > DEFAULT_OKAY() macros, and convi

Re: [webkit-dev] Can we disable "control reaches end of non-void function" warning on Qt?

2013-09-13 Thread Oliver Hunt
We may want to hunt through the other cases of default: ASSERT_NOT_REACHED() and clobber those with RELEASE_ASSERT_NOT_REACHED() as well. I wonder if it would be easier to have DEFAULT_NOT_REACHED() and DEFAULT_OKAY() macros, and convince the style bot to require ether a default: block or one of

Re: [webkit-dev] TimerWindowWndProc and dangling page instances

2013-09-13 Thread Brent Fulgham
Hi Vincent and Mark: On Sep 13, 2013, at 1:06 AM, Salisbury, Mark wrote: > Vincent, > > Maybe some tips I’ve learned could be of help to you or others: > ·Calling DestroyWindow will cause WebView::close() to be called (when > WM_DESTROY is received), but it does not cause WebView’s de

Re: [webkit-dev] Announcing new port: Nix

2013-09-13 Thread Geoffrey Garen
>> Thank you for this list. I started reading through it, but I noticed a high >> percentage of patches that were port-specific build fixes or port-specific >> features like support for legacy ARM chips. For example, “...on ARM >> traditional” (). Those

Re: [webkit-dev] Can we disable "control reaches end of non-void function" warning on Qt?

2013-09-13 Thread Konstantin Tokarev
13.09.2013, 06:54, "Ryosuke Niwa" : > Hm... it appears that I was wrong about this.  It appears that this is the > intended feature in gcc:http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28236 > > Regardless, I don't think we should have this warning enabled. We're > generating some unused code ever

[webkit-dev] Changes in QtWebKit development

2013-09-13 Thread Albisser Zeno
Hello WebKittens As many of you have probably noticed already, we have recently been focusing on a project called Qt WebEngine. Our WebKit efforts have therefore been reduced significantly over the past weeks. While we will keep shipping QtWebKit with Qt for the foreseeable future, we want to c

Re: [webkit-dev] Announcing new port: Nix

2013-09-13 Thread Thomas Fletcher
Geoffrey Garen wrote: Sure. We at University of Szeged who work on WebKitNix from this year contributed many fixes to various part of WebKit: JavaScriptCore, WebCore, Tools, … Thank you for this list. I started reading through it, but I noticed a high percentage of patches that were port-spe

Re: [webkit-dev] TimerWindowWndProc and dangling page instances

2013-09-13 Thread Van Den Berghe, Vincent
Hello Mark, Thank you for your tips. I am painfully aware of #1 and have compensated for it in much the same way you have. Tip #2 doesn't really apply to my scenario. I'm embedding the Wincairo build of WebKit to generate PDF files from web pages in an ASP.NET application. Webkit isn't really de

Re: [webkit-dev] TimerWindowWndProc and dangling page instances

2013-09-13 Thread Salisbury, Mark
Vincent, I've also embedded WebKit in a .NET application, and I've seen similar issues - not exactly what you're seeing though. Maybe some tips I've learned could be of help to you or others: *Calling DestroyWindow will cause WebView::close() to be called (when WM_DESTROY is received),

Re: [webkit-dev] TimerWindowWndProc and dangling page instances

2013-09-13 Thread Darin Adler
On Sep 13, 2013, at 12:42 AM, "Van Den Berghe, Vincent" wrote: > And call this method as the first line of Page’s destructor: > > Page::~Page() > { > m_settings->clearPage(); > m_mainFrame->setView(0); You’ve got it exactly right. This issue is not at all specific to Windows. Page do

[webkit-dev] TimerWindowWndProc and dangling page instances

2013-09-13 Thread Van Den Berghe, Vincent
Hello, Background --- I'm currently embedding WebKit in a .NET application, which required me to solve a whole set of issues that are not relevant here. However, I've stumbled upon a scenario which I suspect is *really* problematic (but I can be wrong). Before patching anything, I'd