Re: [webkit-dev] Proposal: Use ICU in WebKit code

2013-10-06 Thread Alexey Proskuryakov
05.10.2013, в 04:09, Konstantin Tokarev написал(а): > There is an issue with ICU: it uses UTF16 as its internal representation, > while most of the Web nowadays is UTF8. Therefore, page text goes through > unnecessary encoding conversion, and takes more memory than in UTF8 (for most > of lang

Re: [webkit-dev] GCC version consistency on EFL bots?

2013-10-06 Thread Gyuyoung Kim
Hello Karen, Thank you for good information. However, as Andreas said, it is important to have the same compiler version both on EWS and bots. So, I feel I need that the problem bot has the same gcc version as soon as possible. Because I don't want to do something against WebKit(or common) develop

Re: [webkit-dev] GCC version consistency on EFL bots?

2013-10-06 Thread Karen Shaeffer
Hi Gyuyoung, Be aware: Ubuntu 12.10 (gnu 4.7.2) expires April 2014. Ubuntu 13.04 (gnu 4.7.3) expires Jan 2014. Ubunut 13.10 (gnu 4.8.1) scheduled release date Oct 17 2013. End of life Jul 2014. Ubuntu 14.04 (gnu 4.8.x) scheduled release date Apr 17 2014. LTS release I would avoid 13.04, because

Re: [webkit-dev] GCC version consistency on EFL bots?

2013-10-06 Thread Andreas Kling
We can keep using FINAL and OVERRIDE macros for a while longer. That should keep the GCC 4.6 build trucking along. It’s still important that we use the same compiler on EWS and real bots, since the whole point is to avoid situations like this :) On Oct 7, 2013, at 3:19 AM, ryuan Choi wrote: > H

Re: [webkit-dev] GCC version consistency on EFL bots?

2013-10-06 Thread ryuan Choi
Hi gyuyoung and Andreas, If then, does it mean that webkit will drop support of gcc 4.6? Just for curiousity. Thanks. 2013. 10. 7. 오전 10:26에 "Gyuyoung Kim" 님이 작성: > Hi Andreas, > > Ah, I only talked on EFL ews bots. Yes, we're running an ubuntu 32bit > machine only for a 32bit buildbot. And, it

Re: [webkit-dev] GCC version consistency on EFL bots?

2013-10-06 Thread Gyuyoung Kim
Hi Andreas, Ah, I only talked on EFL ews bots. Yes, we're running an ubuntu 32bit machine only for a 32bit buildbot. And, it is based on Ubuntu 12.04 and has gcc 4.6.3 version. I think the 32bit buildbot needs to be upgraded. I will do it. Thanks, Gyuyoung. On Mon, Oct 7, 2013 at 10:07 AM, Andr

Re: [webkit-dev] GCC version consistency on EFL bots?

2013-10-06 Thread Andreas Kling
Hi Gyuyoung, Then why is final/override working on EWS but not on the main build bots? Are they using different compiler flags? According to wtf/Compiler.h, GCC should support override control since at least 4.7.0. Errors here: http://build.webkit.org/builders/EFL%20Linux%2032-bit%20Release%20%

Re: [webkit-dev] GCC version consistency on EFL bots?

2013-10-06 Thread Gyuyoung Kim
Hi Andreas, > Are the main/EWS bots running different versions of GCC? No, EFL ews bots have same gcc version. EFL ews and buildbots are being ran on two machines. As far as I know, those are based on Ubuntu 13.04 and have same gcc 4.7.3. Thanks, Gyuyoung. On Mon, Oct 7, 2013 at 4:56 AM, Andre

Re: [webkit-dev] Please install shellwords on the bots

2013-10-06 Thread Filip Pizlo
On Oct 6, 2013, at 2:00 PM, Benjamin Poulain wrote: > On 10/6/13, 1:54 PM, Filip Pizlo wrote: >> This bug: https://bugs.webkit.org/show_bug.cgi?id=120696 >> >> Is for making run-javascriptcore-tests run all of the tests in >> parallel and in a way that is aware of our multiple tiers. It vastly

Re: [webkit-dev] Please install shellwords on the bots

2013-10-06 Thread Benjamin Poulain
On 10/6/13, 1:54 PM, Filip Pizlo wrote: > This bug: https://bugs.webkit.org/show_bug.cgi?id=120696 > > Is for making run-javascriptcore-tests run all of the tests in > parallel and in a way that is aware of our multiple tiers. It vastly > improves JSC test coverage. > > Right now, the script wil

[webkit-dev] Please install shellwords on the bots

2013-10-06 Thread Filip Pizlo
This bug: https://bugs.webkit.org/show_bug.cgi?id=120696 Is for making run-javascriptcore-tests run all of the tests in parallel and in a way that is aware of our multiple tiers. It vastly improves JSC test coverage. Right now, the script will refuse to do anything if your machine doesn't have

Re: [webkit-dev] Proposal: Use ICU in WebKit code

2013-10-06 Thread Geoffrey Garen
> "Since ICU uses Unicode (UTF-16) internally, all converters convert > between UTF-16 (with the endianness according to the current platform) > and another encoding.” The claim I would like to verify is that this design is slower and "takes more memory” due to "unnecessary encoding conversion”.

[webkit-dev] GCC version consistency on EFL bots?

2013-10-06 Thread Andreas Kling
Hi folks, I recently landed a patch that makes use of lowercased “override” and “final” in WebKit, and now the EFL build is failing. The EFL EWS bots didn’t have any problem with the patch however, which brings me to my question: Are the main/EWS bots running different versions of GCC? And if so

Re: [webkit-dev] Proposal: Use ICU in WebKit code

2013-10-06 Thread Benjamin Poulain
I think the question was about the performance impact of using UTF-16 as an internal representation of characters. The original claim was in effect that the encoding conversion to UTF-16 is so costly that it offsets any gain of doing codepoint operations on UTF-16 instead of UTF-8. It is a very s

Re: [webkit-dev] Proposal: Use ICU in WebKit code

2013-10-06 Thread Alp Toker
Geoffrey, http://userguide.icu-project.org/conversion/converters says: "Since ICU uses Unicode (UTF-16) internally, all converters convert between UTF-16 (with the endianness according to the current platform) and another encoding." That said, I don't think it's a major concern because ICU works

Re: [webkit-dev] Proposal: Use ICU in WebKit code

2013-10-06 Thread Geoffrey Garen
> There is an issue with ICU: it uses UTF16 as its internal representation, > while most of the Web nowadays is UTF8. Therefore, page text goes through > unnecessary encoding conversion, and takes more memory than in UTF8 (for most > of languages). So it might be not a good development direction