Re: [webkit-dev] When to use "auto"? (I usually consider it harmful)
>>> If I had to describe this algorithm in English, I’d say, “Collect and >>> retain all the [auto] from the list of parsed parameters.” I think that >>> explanation would be stronger if “[auto]” were a concrete noun. >> >> The variable and the function are both named pattern and I would use that as >> the noun. > > Question for Geoff or anyone who knows: is it contextually useful to know > that it's specifically a "DeconstructionPatternNode*" beyond knowing that > it's a "pattern”? For me, knowing that it’s a “DeconstructionPatternNode” tells me where to go in source code to find out more. Namely: - Why do we need manual reference counting here? (Answer: DeconstructionPatternNode allocates variable-sized storage within itself, and aliases that storage as untyped memory.) - Is this normal reference counting, or something weird? (Answer: DeconstructionPatternNode inherits from RefCounted, so this is normal reference counting.) Geoff___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Apple Mac EWS 10.9 upgrade?
Hi, On Jan 6, 2014, at 1:53 PM, Alexey Proskuryakov wrote: > 06 янв. 2014 г., в 12:51, Lucas Forschler написал(а): > >> The Apple Mac EWS bots are currently running 10.8.5. >> I would like to see if there is any opposition (or support) for upgrading >> them to 10.9 / Mavericks. > > Mavericks bots are substantially less reliable at this point, so this will > degrade EWS performance. E.g. Mavericks WK2 Release was completely > dysfunctional for two days recently for unclear reasons. This is troubling. Why are they less reliable? -Brent ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] When to use "auto"? (I usually consider it harmful)
On Mon, Jan 6, 2014 at 11:49 PM, Geoffrey Garen wrote:
>
> (2) ApplyStyleCommand.cpp:
>
> auto children = elementChildren(*dummySpanAncestor);
> for (auto child = children.begin(), end = children.end(); child !=
> end; ++child) {
> *if (isSpanWithoutAttributesOrUnstyledStyleSpan(&*child))*
> *toRemove.append(&*child);*
> }
>
You are looking at a pretty old revision. In ToT this looks like
for (auto& child : childrenOfType(*dummySpanAncestor)) {
if (isSpanWithoutAttributesOrUnstyledStyleSpan(&child))
toRemove.append(&child);
}
antti
>
> Thanks,
> Geoff
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Guideline for nullptr
El lun, 06-01-2014 a las 14:19 -0800, Martin Robinson escribió: > On Mon, Jan 6, 2014 at 1:16 PM, Ryosuke Niwa wrote: > > Sounds like a great idea to me. > > Seconding this. nullptr also has much better compatibility with varargs than > 0. Yeah, with nullptr we don't need the coding style exceptions for C API using NULL as a sentinel. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
