Re: [webkit-dev] EFL EWS Bot output
Hello Oliver, I'm really sorry about the inconvenience to you. Let me try to fix it within a few days. Gyuyoung. On Wed, Jan 29, 2014 at 8:09 AM, Alexey Proskuryakov wrote: > > 28 янв. 2014 г., в 14:59, Oliver Hunt написал(а): > > > Could whoever is responsible for the EFL EWS bot please make the bot set > the correct mimetype on the build output. > > > > I've requested this before, but i'm trying again. It is really annoying > that it triggers a download rather than just opening in the browser like > the output from every other bot. > > What needs to be fixed is that the output shouldn't have escape sequences. > The MIME type of text/plain is set by webkit-queues server, but then > networking code in the browser sees a resource without an extension and > that has binary data in it, so it overrides the type. > > Another solution would be for webkitpy or webkit-queues to automagically > strip escape sequences from the output. > > - WBR, Alexey Proskuryakov > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] EFL WK2 bot / ews start to work again
Hi WebKitten, First of all, I'm so sorry for broken EFL WK2 bot and ews during one week. I didn't manage them during last week, because we was holidays. Additionally my co-workers also couldn't maintain them due to some internal issues. Now I restart them, and try to keep them work well. Thanks, Gyuyoung. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Remove ENABLE(SVG)
On 2/4/14, 7:08 AM, Steven Coul (scoul) wrote: > My big worry about that, is that somewhere somebody is thinking about > using that argument to add Flash and/or Moonlight to Webkit - and > down that path madness lies ;-) > > There really aren’t any “size-hogs” in WK other than SVG itself - but > it’s been a while since I looked I admit. > > I tend to think of “fork it” as a last desperate measure rather than > first plan - but whatever - I was just interested in others opinions > since I don’t have a horse in this race anyhow. We do worry about binary size, but removing a core feature is not a solution. There are plenty of other opportunities to improve the WebKit binary. Patches for that are welcome too ;) Cheers, Benjamin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Remove ENABLE(SVG)
My big worry about that, is that somewhere somebody is thinking about using that argument to add Flash and/or Moonlight to Webkit - and down that path madness lies ;-) There really aren’t any “size-hogs” in WK other than SVG itself - but it’s been a while since I looked I admit. I tend to think of “fork it” as a last desperate measure rather than first plan - but whatever - I was just interested in others opinions since I don’t have a horse in this race anyhow. Steve "Harry" Coul sc...@cisco.com On Feb 4, 2014, at 8:52 AM, Dirk Schulze wrote: > > On Feb 4, 2014, at 5:20 AM, Steven Coul (scoul) wrote: > >> I agree, the time taken to build is not really a good reason for the change >> or lack of - as you point out there, are many other ways to optimize the >> build process/server which will have wider benefits. >> >> But does anybody consider size to be an issue? SVG adds a fair chunk to the >> size of a binary - especially in debug builds - which is not very friendly >> to embedded systems. >> >> ( Real embedded, not just a small form factor $500 PC running Windows etc ) >> >> I know in general WK seems to be aimed at desktop, big mobile etc - and we >> tend to ignore anything not directly related to the the main builds, but >> even on a desktop I wouldn’t mind seeing a crusade to make things smaller. >> One day I’ll see my whole OS in L1 Cache…….. > > In this case you may want to branch WebKit and remove more than just SVG. > > WebKit is a browser engine and should display web content. There is no doubt > anymore that SVG is an integral part of the web. That is the the only > decision that matters here IMO. > > Greetings, > Dirk > >> >> Steve "Harry" Coul >> sc...@cisco.com >> >> >> >> On Feb 4, 2014, at 6:11 AM, Osztrogonác Csaba wrote: >> >>> Xabier Rodríguez Calvar írta: Sorry for the late answer, but I was in Brussels at FOSDEM. O Ven, 31-01-2014 ás 14:01 +0100, Alberto Garcia escribiu: > Not in the GTK+ port at least, I've been able to do builds without > SVG perfectly fine, so there's probably something else wrong in your > environment or the port you're using. > > Anyway, I'm also fine with removing it. It saves some times in our builds and I always use it unless I have to do something with SVG. I would keep it unless it doesn't pay off the effort of maintaining it. Br. >>> >>> I've checked the full clean build time of GTK port on a quad core i5-2320 >>> (3GHz) machine with icecc buildfarm and -j30 makeflag: >>> - with SVG disabled:"WebKit is now built (11m:58s)." >>> - with SVG enabled: "WebKit is now built (13m:38s)." >>> >>> The difference isn't so big. But it was clean build, I don't think if >>> developers always do clean builds. If you don't touch SVG related files, >>> the build time shouldn't depend on enabled/disabled SVG. >>> >>> In my opinion the ENABLE(SVG) flag is not to speed up clean builds, but >>> disable SVG if you don't want to ship it. There are so many way to speed >>> up builds: >>> - use more cores, use icecc buildfarm, use ccache >>> - get rid of include paths and use module relative includes >>> (But it can be a separated thread if anybody is interested in it.) >>> >>> Ossy >>> ___ >>> webkit-dev mailing list >>> webkit-dev@lists.webkit.org >>> https://lists.webkit.org/mailman/listinfo/webkit-dev >> >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> https://lists.webkit.org/mailman/listinfo/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Remove ENABLE(SVG)
On Feb 4, 2014, at 5:20 AM, Steven Coul (scoul) wrote: > I agree, the time taken to build is not really a good reason for the change > or lack of - as you point out there, are many other ways to optimize the > build process/server which will have wider benefits. > > But does anybody consider size to be an issue? SVG adds a fair chunk to the > size of a binary - especially in debug builds - which is not very friendly to > embedded systems. > > ( Real embedded, not just a small form factor $500 PC running Windows etc ) > > I know in general WK seems to be aimed at desktop, big mobile etc - and we > tend to ignore anything not directly related to the the main builds, but even > on a desktop I wouldn’t mind seeing a crusade to make things smaller. One day > I’ll see my whole OS in L1 Cache…….. In this case you may want to branch WebKit and remove more than just SVG. WebKit is a browser engine and should display web content. There is no doubt anymore that SVG is an integral part of the web. That is the the only decision that matters here IMO. Greetings, Dirk > > Steve "Harry" Coul > sc...@cisco.com > > > > On Feb 4, 2014, at 6:11 AM, Osztrogonác Csaba wrote: > >> Xabier Rodríguez Calvar írta: >>> Sorry for the late answer, but I was in Brussels at FOSDEM. >>> O Ven, 31-01-2014 ás 14:01 +0100, Alberto Garcia escribiu: Not in the GTK+ port at least, I've been able to do builds without SVG perfectly fine, so there's probably something else wrong in your environment or the port you're using. Anyway, I'm also fine with removing it. >>> It saves some times in our builds and I always use it unless I have to >>> do something with SVG. >>> I would keep it unless it doesn't pay off the effort of maintaining it. >>> Br. >> >> I've checked the full clean build time of GTK port on a quad core i5-2320 >> (3GHz) machine with icecc buildfarm and -j30 makeflag: >> - with SVG disabled:"WebKit is now built (11m:58s)." >> - with SVG enabled: "WebKit is now built (13m:38s)." >> >> The difference isn't so big. But it was clean build, I don't think if >> developers always do clean builds. If you don't touch SVG related files, >> the build time shouldn't depend on enabled/disabled SVG. >> >> In my opinion the ENABLE(SVG) flag is not to speed up clean builds, but >> disable SVG if you don't want to ship it. There are so many way to speed >> up builds: >> - use more cores, use icecc buildfarm, use ccache >> - get rid of include paths and use module relative includes >> (But it can be a separated thread if anybody is interested in it.) >> >> Ossy >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> https://lists.webkit.org/mailman/listinfo/webkit-dev > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] call JS function using JSValue object
My javascript code looks like
>> function Player() { this.speed = 5; this.x = 50; this.y = 50;
this.getType = function(){
return this.x;
}
>> }
var p = new Player();
setObject(p);
i have exposed function setObject() through webkit idl and i am getting the p
object as JSValue object.
How can i call getType() through this JSValue object??
Thanks in advance.
Sent from my iPad___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Anonymous style (inheritance and dynamic update)
Hi all, I'm trying to refactor the MathML code to follow what seems the clean way to add style to elements and prepare for future improvements. Hence I have tried to do some experiments with anonymous style and that seems to work in some cases, but sometimes the style is not applied correctly. I don't know much about the WebKit layout code and just tried to copy what was done elsewhere. So I would appreciate if someone more familiar with the code base could check if the code makes sense and suggest the right way to implement that otherwise? In https://bugs.webkit.org/show_bug.cgi?id=124838 I have attached a big patch that shares some code between the , and the elements (which uses anonymous ), cleans up more things and tries to fix other rendering bugs. For convenience, I have extracted the changes that are only relevant to in a smaller patch: https://bug-124838-attachments.webkit.org/attachment.cgi?id=223101 (see in the new nsRenderMathMLToken class). The basic test case https://bug-44208-attachments.webkit.org/attachment.cgi?id=219653 renders correctly with that patch but as I said above, other reftests fail for some reason. Note that you don't need to know anything about MathML, but the following info might be helpful: 1) Single variables like x should be italic while multiple-char identifier like sin should be upright ; the plan is thus to map this to CSS font-style (this is not quite what the MathML spec says but this approximation has been used in Gecko for a long time, so that's ok to use it in WebKit for now). Also in theory, whitespace should be collapsed in MathML tokens, sox is equivalent to x. 2) Operators like + or ( may have different spacing. The default being indicated by the operator dictionary (http://www.w3.org/TR/MathML3/appendixc.html). The idea is to map this to margin-left/margin-right. This is what I try to do in the bigger patch https://bug-124838-attachments.webkit.org/attachment.cgi?id=222977 as well as in the follow-up bug https://bugs.webkit.org/show_bug.cgi?id=99620. Thank you, -- Frédéric Wang MathML Crowdfunding: ulule.com/mathematics-ebooks ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Remove ENABLE(SVG)
I agree, the time taken to build is not really a good reason for the change or lack of - as you point out there, are many other ways to optimize the build process/server which will have wider benefits. But does anybody consider size to be an issue? SVG adds a fair chunk to the size of a binary - especially in debug builds - which is not very friendly to embedded systems. ( Real embedded, not just a small form factor $500 PC running Windows etc ) I know in general WK seems to be aimed at desktop, big mobile etc - and we tend to ignore anything not directly related to the the main builds, but even on a desktop I wouldn’t mind seeing a crusade to make things smaller. One day I’ll see my whole OS in L1 Cache…….. Steve "Harry" Coul sc...@cisco.com On Feb 4, 2014, at 6:11 AM, Osztrogonác Csaba wrote: > Xabier Rodríguez Calvar írta: >> Sorry for the late answer, but I was in Brussels at FOSDEM. >> O Ven, 31-01-2014 ás 14:01 +0100, Alberto Garcia escribiu: >>> Not in the GTK+ port at least, I've been able to do builds without >>> SVG perfectly fine, so there's probably something else wrong in your >>> environment or the port you're using. >>> >>> Anyway, I'm also fine with removing it. >> It saves some times in our builds and I always use it unless I have to >> do something with SVG. >> I would keep it unless it doesn't pay off the effort of maintaining it. >> Br. > > I've checked the full clean build time of GTK port on a quad core i5-2320 > (3GHz) machine with icecc buildfarm and -j30 makeflag: > - with SVG disabled:"WebKit is now built (11m:58s)." > - with SVG enabled: "WebKit is now built (13m:38s)." > > The difference isn't so big. But it was clean build, I don't think if > developers always do clean builds. If you don't touch SVG related files, > the build time shouldn't depend on enabled/disabled SVG. > > In my opinion the ENABLE(SVG) flag is not to speed up clean builds, but > disable SVG if you don't want to ship it. There are so many way to speed > up builds: > - use more cores, use icecc buildfarm, use ccache > - get rid of include paths and use module relative includes > (But it can be a separated thread if anybody is interested in it.) > > Ossy > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Remove ENABLE(SVG)
Xabier Rodríguez Calvar írta: Sorry for the late answer, but I was in Brussels at FOSDEM. O Ven, 31-01-2014 ás 14:01 +0100, Alberto Garcia escribiu: Not in the GTK+ port at least, I've been able to do builds without SVG perfectly fine, so there's probably something else wrong in your environment or the port you're using. Anyway, I'm also fine with removing it. It saves some times in our builds and I always use it unless I have to do something with SVG. I would keep it unless it doesn't pay off the effort of maintaining it. Br. I've checked the full clean build time of GTK port on a quad core i5-2320 (3GHz) machine with icecc buildfarm and -j30 makeflag: - with SVG disabled:"WebKit is now built (11m:58s)." - with SVG enabled: "WebKit is now built (13m:38s)." The difference isn't so big. But it was clean build, I don't think if developers always do clean builds. If you don't touch SVG related files, the build time shouldn't depend on enabled/disabled SVG. In my opinion the ENABLE(SVG) flag is not to speed up clean builds, but disable SVG if you don't want to ship it. There are so many way to speed up builds: - use more cores, use icecc buildfarm, use ccache - get rid of include paths and use module relative includes (But it can be a separated thread if anybody is interested in it.) Ossy ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Remove ENABLE(SVG)
Alberto Garcia írta: On Fri, Jan 31, 2014 at 12:43:16PM +0100, Osztrogonác Csaba wrote: The --no-svg build is broken now, and the change broke it is 11 months old change Not in the GTK+ port at least, I've been able to do builds without SVG perfectly fine, so there's probably something else wrong in your environment or the port you're using. Good point, I haven't checked GTK port, only EFL and Apple Mac and got the same build failure on both pof them. Anyway, I'm also fine with removing it. Berto ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
