Re: [webkit-dev] *.webkit.org downtime Tuesday, 3/11
Hi, There are still issues after downtime: - Apple EWS bots are still broken (Last Pass: 1 day, 16 hours ago) - login on build.webkit.org is broken: The username or password you entered were not correct. Please go back and try again. Ossy Lucas Forschler írta: FYI, I'm currently working on fixing the commit queue and the EWS bots. Lucas ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] *.webkit.org downtime Tuesday, 3/11
On Mon, 2014-03-10 at 10:35 -0700, Lucas Forschler wrote: Hello Webkit developers, Apple will be upgrading our network infrastructure starting Tuesday morning at 8am. The webkit.org services will be affected for approximately 4 hours. This includes all *.webkit.org domains. We expect them to be back online before 12. BTW I've been wondering if a Bugzilla upgrade is planned? We currently use 3.2.3 but the latest release seems to be 4.2. If at least we could have a nice CSS like in bugzilla.mozilla.org it'd be great :) Philippe ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] *.webkit.org downtime Tuesday, 3/11
En 13/03/14 09:56, Osztrogonác Csaba escribiu: Hi, There are still issues after downtime: - Apple EWS bots are still broken (Last Pass: 1 day, 16 hours ago) - login on build.webkit.org is broken: The username or password you entered were not correct. Please go back and try again. I'd add: - login on the Wiki is not possible either (Internal Server Error). BR ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] *.webkit.org downtime Tuesday, 3/11
It seems the whole authentication is broken (except bugs.webkit.org), because commit to svn.webkit.org is broken too. :-/ On 03/13/2014 11:25 AM, Sergio Villar Senin wrote: En 13/03/14 09:56, Osztrogonác Csaba escribiu: Hi, There are still issues after downtime: - Apple EWS bots are still broken (Last Pass: 1 day, 16 hours ago) - login on build.webkit.org is broken: The username or password you entered were not correct. Please go back and try again. I'd add: - login on the Wiki is not possible either (Internal Server Error). ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Table layout does not clear setNeedsLayout flag for rows?
Hi, I am checking the layout and rendering of the table element in webkit. In the process I figured out that the link of renderers is as follows: RenderTable has RenderTableSection has RenderTableRow has RenderTableCell The layout of the table rows is done in RenderTableSection::layoutRows. I did not see any code to specifically set RenderTableRow::setNeedsLayout(false) at the end of the function. While there is a call to RenderTableCell::layout , which will then clear the layout flag for RenderTableCell. So is a RenderTableRow::setNeedsLayout(false) needed at the end of the layout of each row in RenderTableSection::layoutRows? If not then where is the RenderTableRow layout flag cleared? Regards, Mayur Kankanwadi. -- Symbiangeek,Codekata Webkitwiki all in one - http://flaminghorns.com ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] *.webkit.org downtime Tuesday, 3/11
Hi, The Apple owned style queue and feeder queue bots are still broken. I started a style queue and a feeder queue bot on one of our machine until fixing the issues caused by the downtime. Now there isn't any pending task in the style queue and patches are automatically submitted to EWS, you don't have to push submit to EWS button manually. Unfortunately the broken webkit-misc-style sometimes tries to pick up a patch from the queue and holds their lock forever. :-/ In this case I have to remove the patch from the queue, submit it to the queue again and trust if my style bot is faster then the broken one. Is it possible to shut down the webkit-misc-style but until proper fix? Thanks, Ossy On 03/13/2014 09:56 AM, Osztrogonác Csaba wrote: There are still issues after downtime: - Apple EWS bots are still broken (Last Pass: 1 day, 16 hours ago) - login on build.webkit.org is broken: The username or password you entered were not correct. Please go back and try again. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] *.webkit.org downtime Tuesday, 3/11
On Mar 13, 2014, at 1:56 AM, Osztrogonác Csaba o...@inf.u-szeged.hu wrote: - login on build.webkit.org is broken: The username or password you entered were not correct. Please go back and try again.” Please try again. The db that stores that info got overloaded and needed to be kicked. -Bill ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] *.webkit.org downtime Tuesday, 3/11
Try this again too. All auth was broken (except for bugs) and should now be fixed. -Bill On Mar 13, 2014, at 4:11 AM, Osztrogonác Csaba o...@inf.u-szeged.hu wrote: It seems the whole authentication is broken (except bugs.webkit.org), because commit to svn.webkit.org is broken too. :-/ On 03/13/2014 11:25 AM, Sergio Villar Senin wrote: En 13/03/14 09:56, Osztrogonác Csaba escribiu: Hi, There are still issues after downtime: - Apple EWS bots are still broken (Last Pass: 1 day, 16 hours ago) - login on build.webkit.org is broken: The username or password you entered were not correct. Please go back and try again. I'd add: - login on the Wiki is not possible either (Internal Server Error). ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] *.webkit.org downtime Tuesday, 3/11
The issue is reoccurring. We’re investigating. -Bill On Mar 13, 2014, at 8:36 AM, William Siegrist wsiegr...@apple.com wrote: Try this again too. All auth was broken (except for bugs) and should now be fixed. -Bill On Mar 13, 2014, at 4:11 AM, Osztrogonác Csaba o...@inf.u-szeged.hu wrote: It seems the whole authentication is broken (except bugs.webkit.org), because commit to svn.webkit.org is broken too. :-/ On 03/13/2014 11:25 AM, Sergio Villar Senin wrote: En 13/03/14 09:56, Osztrogonác Csaba escribiu: Hi, There are still issues after downtime: - Apple EWS bots are still broken (Last Pass: 1 day, 16 hours ago) - login on build.webkit.org is broken: The username or password you entered were not correct. Please go back and try again. I'd add: - login on the Wiki is not possible either (Internal Server Error). ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] *.webkit.org downtime Tuesday, 3/11
This issue should be solved as of 6:20pm PST. The network folks needed to change some magic. Please let me know if the bots are misbehaving… it may take a few minutes for them to catch up. Lucas On Mar 13, 2014, at 7:56 AM, Osztrogonác Csaba o...@inf.u-szeged.hu wrote: Hi, The Apple owned style queue and feeder queue bots are still broken. I started a style queue and a feeder queue bot on one of our machine until fixing the issues caused by the downtime. Now there isn't any pending task in the style queue and patches are automatically submitted to EWS, you don't have to push submit to EWS button manually. Unfortunately the broken webkit-misc-style sometimes tries to pick up a patch from the queue and holds their lock forever. :-/ In this case I have to remove the patch from the queue, submit it to the queue again and trust if my style bot is faster then the broken one. Is it possible to shut down the webkit-misc-style but until proper fix? Thanks, Ossy On 03/13/2014 09:56 AM, Osztrogonác Csaba wrote: There are still issues after downtime: - Apple EWS bots are still broken (Last Pass: 1 day, 16 hours ago) - login on build.webkit.org is broken: The username or password you entered were not correct. Please go back and try again. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Table layout does not clear setNeedsLayout flag for rows?
Since I don't understand table layout well, I'm sorry if I said wrong. RenderTable::layout() calls RenderTableSection::layout() at [1]. RenderTableSection::layout() calls RenderTableRow::layout() at [2]. RenderTableRow::layout() clears its setNeedsLayout flag at [3]. Therefore, I think the flag is cleared. [1]: http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderTable.cpp#L465 [2]: http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderTableSection.cpp#L420 [3]: http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderTableRow.cpp#L192 On Thu, Mar 13, 2014 at 11:39 PM, Mayur K emineme...@gmail.com wrote: Hi, I am checking the layout and rendering of the table element in webkit. In the process I figured out that the link of renderers is as follows: RenderTable has RenderTableSection has RenderTableRow has RenderTableCell The layout of the table rows is done in RenderTableSection::layoutRows. I did not see any code to specifically set RenderTableRow::setNeedsLayout(false) at the end of the function. While there is a call to RenderTableCell::layout , which will then clear the layout flag for RenderTableCell. So is a RenderTableRow::setNeedsLayout(false) needed at the end of the layout of each row in RenderTableSection::layoutRows? If not then where is the RenderTableRow layout flag cleared? Regards, Mayur Kankanwadi. -- Symbiangeek,Codekata Webkitwiki all in one - http://flaminghorns.com ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev -- . The contents of this e-mail message and any attachments are confidential and are intended solely for the addressee. The information may also be legally privileged. This transmission is sent in trust, and the sole purpose of delivery to the intended recipient. If you have received this transmission in error, any use, reproduction or dissemination of this transmission is strictly prohibited. If you are not the intended recipient, please immediately notify the sender by reply e-mailer and delete this message and its attachments, if any. Thank you for your cooperation. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev