Re: [webkit-dev] Rename wtf/unicode/UTF8.h

2018-10-31 Thread Fujii Hironori
Thank you for the feedback, Konstantin and Darin. On Thu, Nov 1, 2018 at 1:52 AM Darin Adler wrote: > > With a few seconds thought I am thinking that maybe UTF8Conversion.h or > UTF8Transcoding.h are possible better ideas for new names. Neither is > completely accurate. If we were going to add t

Re: [webkit-dev] Rename wtf/unicode/UTF8.h

2018-10-31 Thread Darin Adler
> On Oct 31, 2018, at 7:52 AM, Konstantin Tokarev wrote: > > 31.10.2018, 05:18, "Fujii Hironori" >: >> wtf/unicode/UTF8.h is conflicting with ICU header in MSVC builds. I'd like >> to rename wtf/unicode/UTF8.h to wtf/unicode/WTFUTF8.h. >> Any suggestion? > > Wh

Re: [webkit-dev] Rename wtf/unicode/UTF8.h

2018-10-31 Thread Konstantin Tokarev
31.10.2018, 05:18, "Fujii Hironori" : > wtf/unicode/UTF8.h is conflicting with ICU header in MSVC builds. I'd like to > rename wtf/unicode/UTF8.h to wtf/unicode/WTFUTF8.h. > Any suggestion? What about Unicode.h or UnicodeHelpers.h? UTF8.h deals with UTF16 as well > > Here is ICU's #include "un

Re: [webkit-dev] Rename wtf/unicode/UTF8.h

2018-10-31 Thread Fujii Hironori
Oh no. I didn't know that. Thank you for letting me know. Then, how about ? There is which has '-' in the name. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev