I’m measuring from “engineer tells GitHub to land a change”, not “Merge-Queue
checks out the change”. The basic steps of the process are:
- GitHub sends hook to buildbot
- buildbot validates hook and PR
- buildbot checks out PR
- buildbot inserts reviewer to commit message and ChangeLog
-
> On May 11, 2022, at 11:56 AM, Jonathan Bedard via webkit-dev
> wrote:
>
> Trying to embed previous replies is going to get messy, will be referencing
> those replies but not embedding them.
>
> Unsafe-Merge-Queue should be very fast, I haven’t seen anything take longer
> than 10 minutes
Trying to embed previous replies is going to get messy, will be referencing
those replies but not embedding them.
Unsafe-Merge-Queue should be very fast, I haven’t seen anything take longer
than 10 minutes from label application to landing or rejection. The average
case is 3-4 minutes. We’re
On Wed, May 11, 2022 at 08:12 Chris Dumez wrote:
>
> On May 11, 2022, at 12:13 AM, Ryosuke Niwa via webkit-dev <
> webkit-dev@lists.webkit.org> wrote:
>
> On Tue, May 10, 2022 at 9:27 PM Ryosuke Niwa wrote:
>
>
>
> On Tue, May 10, 2022 at 20:36 Chris Dumez wrote:
>
>
> [Not sure why Apple Mail
> On May 11, 2022, at 12:13 AM, Ryosuke Niwa via webkit-dev
> wrote:
>
> On Tue, May 10, 2022 at 9:27 PM Ryosuke Niwa wrote:
>>
>>
>> On Tue, May 10, 2022 at 20:36 Chris Dumez wrote:
>>>
>>> [Not sure why Apple Mail sent Ryosuke’s replies to the Junk folder but I
>>> finally noticed.]
>>
On Wed, May 11 2022 at 12:16:46 AM -0700, Ryosuke Niwa via webkit-dev
wrote:
No, I'm using Github clones to write patches then using Subversion
checkout to commit those patches.
If you use the old git repo via git-svn, not the GitHub repo, then you
can use 'git svn dcommit'.
Another idea (not formally proposing): Safari extension to bring Bugzilla's
good points to GitHub UI.
I tried writing random userscripts, and while threaded comments for commit
message / conversation view while reviewing are still missing,
I got some UI to make comment on commit message easier
On Tue, May 10, 2022 at 10:04 PM Chris Dumez wrote:
>
> On May 10, 2022, at 9:27 PM, Ryosuke Niwa wrote:
>>
>> Well, that's precisely my use case. I don't even write a patch in a pure
>> Subversion checkout anymore these days.
>
> Also, I didn’t fully understand this comment. Did you mean that
On Tue, May 10, 2022 at 9:27 PM Ryosuke Niwa wrote:
>
>
> On Tue, May 10, 2022 at 20:36 Chris Dumez wrote:
>>
>> [Not sure why Apple Mail sent Ryosuke’s replies to the Junk folder but I
>> finally noticed.]
>
>
> It's something to do with @webkit.org not being able to send a proper sender
> ID
9 matches
Mail list logo
