On 6/8/22 02:40, Elliott Williams via webkit-dev wrote:
>
>> On Jun 7, 2022, at 10:27, Olmstead, Don via webkit-dev
>> wrote:
>>
>> If we wanted to try any tooling around identifying when an include or
>> forward declaration should be used we need a functioning non-unified build.
>> We could
On 6/7/22 01:39, Geoffrey Garen via webkit-dev wrote:
>> As such, I also think that the non-unified EWS being green should not be a
>> blocker to landing a patch. But I think having it there for information will
>> help the situation. At minimum, even if every engineer simply ignores the
>>
> On Jun 7, 2022, at 10:27, Olmstead, Don via webkit-dev
> wrote:
>
> If we wanted to try any tooling around identifying when an include or forward
> declaration should be used we need a functioning non-unified build. We could
> try IWYU on the codebase,
>
I agree with everything Mark said in his reply I just wanted to add another
benefit of having a non-unified build specifically to support build time
optimization.
> > 2) In my contributions, I don’t just want to add missing includes, I want
> > to remove unnecessary ones taking full advantage
4 matches
Mail list logo
