Re: [webkit-dev] Using GitHub to Contribute to WebKit (Experimental)

On Fri, Mar 16, 2012 at 12:20 PM, John Yani wrote: > On 16 March 2012 18:34, Ryosuke Niwa wrote: >> If some reviewer and committer decide to use this process, where can I see >> review comments and other discussions? > > See point 3  of "Landing your code". Reviewer adds a link to pull > request

Re: [webkit-dev] Upstreaming Support for W3C Sensor API

The specification appears to be here: http://dvcs.w3.org/hg/dap/raw-file/tip/sensor-api/Overview.html Has this specification reached FPWD yet? http://www.w3.org/TR/sensor/ returns a 404. Adam 2012/3/16 Dominik Röttsches : > Hello webkit-dev, > > We would like to upstream our implementation of

[webkit-dev] Using GitHub to Contribute to WebKit (Experimental)

Hi webkit-dev, After reading last week's discussion about switching the project to git, I wondered if it would be possible to get some of the benefits of git-style development without forcing everyone to switch to git. One of the benefits of git-style development is the ability to review a series

Re: [webkit-dev] WebKitIDL syntax: unsigned int

I recommend posting a patch and getting the appropriate folks to review it rather than emailing all of webkit-dev for such a small detail. Adam On Thu, Mar 15, 2012 at 10:34 AM, Seo Sanghyeon wrote: > "unsigned int" is an invalid Type in WebIDL. > > {Int8,Uint8,Uint8Clamped,Int16,Uint16,Int32,U

Re: [webkit-dev] Removing Custom bindings for type array.

It looks like you're getting some good comments on the bug. Thanks for working on removing custom bindings code. Adam On Wed, Mar 14, 2012 at 5:30 AM, Vineet Chaudhary wrote: > Hi All, > > I am trying to remove the custom bindings for the type Array.(ref > : Bug 80696) > Below is list of idls

Re: [webkit-dev] Separating ENABLE(NOTIFICATIONS) and ENABLE(LEGACY_NOTIFICATIONS)

That sounds like a good approach. Chromium will likely need to remember to disable NOTIFICATIONS on any upcoming release branches (until the work is complete). Adam On Mon, Mar 12, 2012 at 6:58 PM, Jon Lee wrote: > Hi WebKit! > > In order to ease the migration path for the nascent notification

Re: [webkit-dev] exporting symbols for building .so/.dll's

On Sun, Mar 11, 2012 at 5:16 PM, Ami Fischman wrote: > Adam wrote: >> I'm not sure I understand your proposal fully.  Specifically, how would >> these macros work for, say, the Chromium, Apple-Mac, and Apple-Win ports, >> which export overlapping, but not identical, sets of symbols? > > I do not h

Re: [webkit-dev] exporting symbols for building .so/.dll's

On Sun, Mar 11, 2012 at 11:13 AM, Adam Barth wrote: > On Sun, Mar 11, 2012 at 10:49 AM, Ami Fischman wrote: >> I'm inclined to give this thread one more business day and then call it >> Tuesday morning pacific time. >> On current showing I think the approach in

Re: [webkit-dev] exporting symbols for building .so/.dll's

On Sun, Mar 11, 2012 at 10:49 AM, Ami Fischman wrote: > I'm inclined to give this thread one more business day and then call it > Tuesday morning pacific time. > On current showing I think the approach in the patch on the bug (incl. > morrita@'s preference for WEBCORE_EXPORT_PRIVATE) is the way to

Re: [webkit-dev] Version control survey

Can you add an option for folks who use both git and SVN? I use both frequently. Thanks, Adam On Fri, Mar 9, 2012 at 10:20 PM, Maciej Stachowiak wrote: > > Since the answer to this factual question seems to be of interest to some > people, here's a survey about what version control tools peop

Re: [webkit-dev] Test conversion to use W3C testharness.js

e results when they are dumped as text obscures the > difference between the test result and description - this is something I > can address in a number of ways depending on everyone's preference.  I'll > investigate further and come up with some suggested fixes. > > > &

Re: [webkit-dev] Test conversion to use W3C testharness.js

he > testharness.css file formats the output into a slightly more readable > output.  Since we are dumping as text, that isn't possible, but other > customizations in testharnessreport.js are.  I will look into this further. > > > > > > On 3/9/12 3:21 PM, "Adam Barth

Re: [webkit-dev] Test conversion to use W3C testharness.js

I looked at the patch you uploaded, but it wasn't clear from the text dump whether the subtests passed or failed. Maybe testharness.js uses a table and/or colors to present that information? It's important that we can easily determine which subtests pass or fail from a text dump. Adam On Fri,

Re: [webkit-dev] About BrowsingContext and WindowProxy spec

I might be misunderstanding your question, but WebKit already implements most (if not all) of this section. WindowProxy and BrowsingContext are internal concepts to the spec. They aren't visible as such in the platform. In particular, a nested BrowsingContext is created by the element and the W

Re: [webkit-dev] PageCache and modularization (was Re: The Care and Feeding of WebCore Modules)

On Fri, Mar 2, 2012 at 3:10 PM, Adam Barth wrote: > I've just started investigating that issue (which is why the patch is > labeled "work-in-progress").  Is there a reason SQLDatabase is special > cased in PageCache?  Most features interact with the PageCache via >

Re: [webkit-dev] PageCache and modularization (was Re: The Care and Feeding of WebCore Modules)

2012/3/5 Alexey Proskuryakov : > 05.03.2012, в 11:29, Adam Barth написал(а): >> For better or worse, Geolocation doesn't support suspend/resume >> (yet?) > > <https://bugs.webkit.org/show_bug.cgi?id=43956> Pages that use Geolocation > should be able to use the p

Re: [webkit-dev] PageCache and modularization (was Re: The Care and Feeding of WebCore Modules)

On Mon, Mar 5, 2012 at 8:47 AM, Brady Eidson wrote: > On Mar 2, 2012, at 3:10 PM, Adam Barth wrote: >> 2012/3/2 Alexey Proskuryakov : >>> It seems that we have some agreement on what to modularize, but not >>> necessarily agreement on what the modularization sh

Re: [webkit-dev] Looking forward to get an advice about event listeners for navigator.battery.

There's likely a better design for your patch. For example, each BatterManager could register itself with the BatteryController. When one of these events occurs, the BatteryController could fire the event on all the BatterManager class, regardless of whether they have listeners added. That would

[webkit-dev] PageCache and modularization (was Re: The Care and Feeding of WebCore Modules)

2012/3/2 Alexey Proskuryakov : > It seems that we have some agreement on what to modularize, but not > necessarily agreement on what the modularization should encompass. > > For example, I think that > that moves some knowledge of what makes a page

Re: [webkit-dev] scoping Node destruction during DOM modifications

Do we understand what's causing the performance regression? For example, there are other implementation approaches where we try to transfer the last ref rather than churning it or where we could use a free list rather than a vector. I just wonder if there's a way to get the benefits with a lower

Re: [webkit-dev] Implementing the Speech JavaScript API

Hi Hans, On Thu, Mar 1, 2012 at 4:17 AM, Hans Wennborg wrote: > Currently, there is some limited support for speech recognition in > WebKit, by means of the x-webkit-speech attribute to input elements. > We would like to continue the development of this to allow web apps to > better utilize the p

Re: [webkit-dev] The Care and Feeding of WebCore Modules

On Wed, Feb 29, 2012 at 11:49 PM, Kentaro Hara wrote: > Thank you very much for the organization. Your suggestion sounds great to me. > > Just for clarification, I would like to confirm what action we should > take for each item from now: > > == Existing Modules == > > gamepad => KEEP > geolocatio

Re: [webkit-dev] The Care and Feeding of WebCore Modules

On Wed, Feb 29, 2012 at 11:31 PM, Maciej Stachowiak wrote: > > Here's an update of my lists based on the notes from you, Adam and others: > > == Existing Modules == > > gamepad > geolocation > indexeddb (work in progress) > intents > mediastream > vibration > websockets > > > == Likely Future Modu

Re: [webkit-dev] The Care and Feeding of WebCore Modules

revert back patches that have already committed around this. IMHO, the changes to Page have been valuable. Does anyone really think we should undo, for example, these changes: http://trac.webkit.org/changeset/108446/trunk/Source/WebCore/page/Page.h http://trac.webkit.org/changeset/108446/trunk/Source/WebCore

Re: [webkit-dev] Moving WTF out of JavaScriptCore

2012/2/28 Mark Rowe : > > On 2012-02-28, at 07:38, Osztrogonac Csaba wrote: > >> Hi, >> >> I uploaded the necessary buildfix for Qt to the bugzilla: >> https://bugs.webkit.org/show_bug.cgi?id=79783 . >> >> Please be careful with moving JavaScriptCore/wtf to WTF, because we >> need zillion trivial

Re: [webkit-dev] The Care and Feeding of WebCore Modules

On Tue, Feb 28, 2012 at 1:59 PM, Maciej Stachowiak wrote: > On Feb 28, 2012, at 12:20 PM, Adam Barth wrote: >> On Tue, Feb 28, 2012 at 11:52 AM, Maciej Stachowiak wrote: >>> But it seems like what is actually happening is wholesale rapid application >>> of thi

Re: [webkit-dev] The Care and Feeding of WebCore Modules

On Tue, Feb 28, 2012 at 11:52 AM, Maciej Stachowiak wrote: > From the initial mail about modules, I got the (perhaps mistaken) impression > that it would be used only for selected features that had very loose > coupling and were perhaps not even of interest to every port. That seemed > like a fine

Re: [webkit-dev] The Care and Feeding of WebCore Modules

2012/2/28 Alexey Proskuryakov : > - separation of concerns seems incorrect (not all code with "WebSocket" in > the name is WebSocket code is the concern of engineers who solely focus on > WebSocket). Do you have a concrete example of this sort of code? It's easier to talk concretely about specifi

Re: [webkit-dev] The Care and Feeding of WebCore Modules

On Tue, Feb 28, 2012 at 11:52 AM, Maciej Stachowiak wrote: > But it seems like what is actually happening is wholesale rapid application > of this pattern to all of WebCore, including even things that aren't in the > Modules directory. So it's starting to seem more like a major restructuring > of

Re: [webkit-dev] The Care and Feeding of WebCore Modules

he > mechanics are for turning something into a Module. > > Regards, > Maciej > > On Feb 28, 2012, at 12:29 AM, Adam Barth wrote: > >> I wrote up a short wiki page explaining how the modules system works >> and how to use it when building new features: >> >&g

Re: [webkit-dev] The Care and Feeding of WebCore Modules

that a better approach would be to figure out how to simplify > Settings (do we still need them all?), and if we do, perhaps to break it up > somehow. > > Simon > > On Feb 28, 2012, at 10:27 AM, Darin Fisher wrote: > > Good idea! > -Darin > > On Tue, Feb 28, 2012 at 8:46

Re: [webkit-dev] The Care and Feeding of WebCore Modules

2012 at 7:40 AM, Darin Fisher wrote: > Nice.  Is there a plan for modularizing Settings? > > On Feb 28, 2012 12:30 AM, "Adam Barth" wrote: >> >> I wrote up a short wiki page explaining how the modules system works >> and how to use it when building new

[webkit-dev] The Care and Feeding of WebCore Modules

I wrote up a short wiki page explaining how the modules system works and how to use it when building new features: https://trac.webkit.org/wiki/Modules We've been making good progress refactoring some existing features to use the system. This refactoring both improves the hackability of WebCore

Re: [webkit-dev] WebKit modularization

2012/2/27 Alexey Proskuryakov : > 27.02.2012, в 11:54, Adam Barth написал(а): >> Huh?  I'm sorry, I thought I addressed all the issues you spotted. >> Are there more I missed?  I certainly don't have any wish (or >> motivation) to mess up the copyright blocks

Re: [webkit-dev] WebKit modularization

2012/2/27 Adam Barth : > 2012/2/27 Alexey Proskuryakov : >> >> 24.02.2012, в 10:00, Adam Barth написал(а): >> >>> I'm happy to re-check them for license errors.  If you can send me a >>> list of the license errors you've noticed, I'll make sur

Re: [webkit-dev] WebKit modularization

2012/2/27 Alexey Proskuryakov : > > 24.02.2012, в 10:00, Adam Barth написал(а): > >> I'm happy to re-check them for license errors.  If you can send me a >> list of the license errors you've noticed, I'll make sure they get >> addressed. > > For the

Re: [webkit-dev] Making DOMWindow less epic (was Re: WebKit modularization)

On Fri, Feb 24, 2012 at 12:07 PM, Maciej Stachowiak wrote: > > On Feb 24, 2012, at 11:58 AM, Adam Barth wrote: > >> On Fri, Feb 24, 2012 at 11:50 AM, Maciej Stachowiak wrote: >>> On Feb 24, 2012, at 10:27 AM, Adam Barth wrote: >>>> 2012/2/24 Maciej Stachowiak

Re: [webkit-dev] Making DOMWindow less epic (was Re: WebKit modularization)

On Fri, Feb 24, 2012 at 11:50 AM, Maciej Stachowiak wrote: > On Feb 24, 2012, at 10:27 AM, Adam Barth wrote: >> 2012/2/24 Maciej Stachowiak : >>> I too am surprised that HTML-related APIs would be refactored as a result >>> of modularization. This change may be justifi

[webkit-dev] Making DOMWindow less epic (was Re: WebKit modularization)

2012/2/24 Maciej Stachowiak : > I too am surprised that HTML-related APIs would be refactored as a result of > modularization. This change may be justifiable on its own merits, but it > doesn't seem like a logical part of a project to make self-contained features > more modular. At the very leas

Re: [webkit-dev] WebKit modularization

2012/2/24 Alexey Proskuryakov : > 22.02.2012, в 22:08, Kentaro Hara написал(а): > >> TL;DR: We are starting WebKit modularization. Self-contained features >> like WebAudio, WebSocket, IndexedDB, File APIs ...etc will be moved >> from WebCore/ to WebCore/Modules/. > > Looking at patches that are act

Re: [webkit-dev] WebKit modularization

On Thu, Feb 23, 2012 at 10:36 AM, Simon Fraser wrote: > On Feb 23, 2012, at 10:24 AM, Adam Barth wrote: >> On Thu, Feb 23, 2012 at 10:07 AM, Simon Fraser >> wrote: >>> On Feb 22, 2012, at 10:08 PM, Kentaro Hara wrote: >>>> TL;DR: We are starting WebKit mod

Re: [webkit-dev] WebKit modularization

On Thu, Feb 23, 2012 at 10:07 AM, Simon Fraser wrote: > On Feb 22, 2012, at 10:08 PM, Kentaro Hara wrote: >> TL;DR: We are starting WebKit modularization. Self-contained features >> like WebAudio, WebSocket, IndexedDB, File APIs ...etc will be moved >> from WebCore/ to WebCore/Modules/. > > What a

Re: [webkit-dev] How to prevent conditional interfaces from being added as supplemental interfaces

Hi Sergio, This sounds like a bug in the code generator. The intent is that supplemental interfaces can be disabled using the Conditional attribute, just like other interfaces. Would you be willing to file a bug at bugs.webkit.org and CC Kentaro and myself? Thanks! Adam On Thu, Feb 23, 2012 a

Re: [webkit-dev] WebKit modularization

On Thu, Feb 23, 2012 at 12:18 AM, Ashod Nakashian wrote: >> TL;DR: We are starting WebKit modularization. Self-contained features > like WebAudio, WebSocket, IndexedDB, File APIs ...etc will be moved > from WebCore/ to WebCore/Modules/. > > Are there plans to split the project build files as well

Re: [webkit-dev] WebKit modularization

Here are a couple example of a patches that are part of this project: https://bugs.webkit.org/attachment.cgi?id=128395&action=review https://bugs.webkit.org/attachment.cgi?id=128247&action=review Notice that we've removed a bunch of feature-spec code from "core" classes like DOMWindow and Page.

Re: [webkit-dev] style queue

Yeah, the problem was it was spamming bugs with git errors. I'm going to make it more robust so it (hopefully!) won't spam before turning it back on. Adam On Wed, Feb 22, 2012 at 4:34 AM, Osztrogonac Csaba wrote: > Hi All, > > Style queue dead long time ago: > > Style Queue > 5 days, 16 hours

Re: [webkit-dev] Adding ENABLE_HTML_MEDIA_CAPTURE to WebCore

How does this feature relate to WebRTC ? Adam On Sun, Feb 19, 2012 at 8:44 PM, JongSeok Yang wrote: > > Hi webkit-dev! > > I want to let you know that I plan to add HTML Media Capture to WebKit. > HTML Media Capture : http://www.w3.org/TR/2011/WD-html-media-ca

Re: [webkit-dev] Always enabling ENABLE(CLIENT_BASED_GEOLOCATION) ?

ks of WebKit constrain the development of trunk. As far as I can tell, the iOS port is not part of trunk, and, if the iOS port were to merge with trunk, it seems likely that it would need to adopt the same architecture used by everyone else. Adam On Thu, Feb 16, 2012 at 4:02 PM, Adam Barth wrote:

Re: [webkit-dev] Always enabling ENABLE(CLIENT_BASED_GEOLOCATION) ?

I've posted a patch in https://bugs.webkit.org/show_bug.cgi?id=78853 . Adam On Thu, Feb 16, 2012 at 2:40 PM, Adam Barth wrote: > Is there anyone who uses Geolocation and doesn't enable > ENABLE(CLIENT_BASED_GEOLOCATION) ?  A quick grep through the build > systems see

[webkit-dev] Always enabling ENABLE(CLIENT_BASED_GEOLOCATION) ?

Is there anyone who uses Geolocation and doesn't enable ENABLE(CLIENT_BASED_GEOLOCATION) ? A quick grep through the build systems seems to indicate that everyone enables it. Should we remove the non-Client-based code path? See https://bugs.webkit.org/show_bug.cgi?id=40373 for context. (All of i

Re: [webkit-dev] Regarding enabling Accelerated 2D Canvas for Android Webkit

On Thu, Feb 16, 2012 at 4:25 AM, Avi D wrote: > Hi, > I am fairly new to Webkit. I am currently trying to Enable > ACCELERATED_2D_CANVAS flag for my build. > When the Flag was enabled (changed in Platform.h -> #define > ENABLE_ACCELERATED_2D_CANVAS 1), I got some build errors related to > Graphics

Re: [webkit-dev] Case typo in fast/js/script-tests/date-constructor.js?

I would use "svn blame" on the file you're modifying to see who changed or reviewed changes to the file in the past. Adam On Thu, Feb 16, 2012 at 6:04 AM, Seo Sanghyeon wrote: > Thanks. Who are appropriate folks? > > 2012/2/16, Adam Barth : >> One approach to answ

Re: [webkit-dev] Case typo in fast/js/script-tests/date-constructor.js?

One approach to answering this question is to file a bug and upload a patch to fix the typo and get it reviewed by the appropriate folks. Adam On Wed, Feb 15, 2012 at 4:35 AM, Seo Sanghyeon wrote: > It defines "toSTring" (not "toString") method on "object". Is it a typo? > > I discovered this w

Re: [webkit-dev] How does the WebRTC project going on?

All the work is happening in WebKit trunk. Take a look at the mediastream folders if you want to see the current progress. Adam On Feb 15, 2012 1:54 AM, "Victor LI" wrote: > How does the WebRTC project going on? > When will it be released to the Webkit trunk repository? > Thanks! > > Victor LI

[webkit-dev] -webkit-overflow-scrolling

As part of the work on the Chromium Android port of WebKit, Sami Kyostila is planning to implement the -webkit-overflow-scrolling CSS property in behind an ENABLE(OVERFLOW_SCROLLING) flag. This feature is non-standard but has been shipping in Mobile

Re: [webkit-dev] Layout issue with fieldset legend element

The preferred way to approach this kind of issue is to file a new bug that describes the problem. This email list isn't for discussing individual bugs. Adam On Tue, Feb 14, 2012 at 8:46 PM, Sravan wrote: > Hi, > > While working on webkit bug#:50287 > (https://bugs.webkit.org/show_bug.cgi?id=50

Re: [webkit-dev] Including new IETestCenter tests in the LayoutTests

On Tue, Feb 14, 2012 at 3:03 PM, Dave Tharp wrote: > I am currently looking at the WebKit CSS3  failures on IETestCenter > (http://samples.msdn.microsoft.com/ietestcenter/ ). > > I’m making some progress, and getting ready to submit a patch.  I’ve > contacted Beth Dakin about my approach on the fi

Re: [webkit-dev] Web Notifications API

lieve they use text-based notifications, but I haven't debugged them. I just noticed the notifications being used. > Are notifications trigger from the web site or Chrome App extension? These are web sites, not Chrome apps/extensions. Adam > On Mon, Feb 13, 2012 at 6:05 PM, Adam Barth wrote

Re: [webkit-dev] Is the style bot OK?

Sorry about that. I tried to fix it last night but apparently was unsuccessful. I'll try again. Adam On Feb 14, 2012 8:43 AM, "Raphael Kubo da Costa" wrote: > I've been trying to send a patch to bug 78600 for a few hours, but the > style bot is always rejecting [1] it when trying to apply a s

Re: [webkit-dev] Web Notifications API

On Mon, Feb 13, 2012 at 5:31 PM, David Levin wrote: > On Mon, Feb 13, 2012 at 5:29 PM, Adam Barth wrote: >> On Mon, Feb 13, 2012 at 5:23 PM, Jon Lee wrote: >> > I also have concerns about backwards compatibility support. Aside from >> > Gmail, what other we

Re: [webkit-dev] Web Notifications API

On Mon, Feb 13, 2012 at 5:23 PM, Jon Lee wrote: > I also have concerns about backwards compatibility support. Aside from > Gmail, what other web sites have integrated the notifications feature? I > could only find example pages, one of which was using already an outdated > API. IRCCloud is an exa

Re: [webkit-dev] When should we turn on new features?

On Mon, Feb 13, 2012 at 1:02 PM, Maciej Stachowiak wrote: > > On Feb 10, 2012, at 4:09 PM, Ryosuke Niwa wrote: > >> Hi all, >> >> In general, the decision of whether a given feature is enabled or not is >> made by each port. However, at last year's W3C TPAC, there were complaints >> from other p

Re: [webkit-dev] Subpixel Layout Update

On Fri, Feb 10, 2012 at 6:22 PM, Levi Weintraub wrote: > On Fri, Feb 10, 2012 at 6:14 PM, Adam Barth wrote: >> >> On Fri, Feb 10, 2012 at 6:09 PM, Levi Weintraub wrote: >> > On Fri, Feb 10, 2012 at 6:03 PM, Adam Barth wrote: >> >> >> >>

Re: [webkit-dev] Subpixel Layout Update

On Fri, Feb 10, 2012 at 6:09 PM, Levi Weintraub wrote: > On Fri, Feb 10, 2012 at 6:03 PM, Adam Barth wrote: >> >> On Fri, Feb 10, 2012 at 5:49 PM, Levi Weintraub wrote: >> > WebKittens, >> > >> > We're planning to wrap up our conversion of the R

Re: [webkit-dev] Subpixel Layout Update

On Fri, Feb 10, 2012 at 5:49 PM, Levi Weintraub wrote: > WebKittens, > > We're planning to wrap up our conversion of the RenderTree to subpixel units > next week. We've created a the following wiki page to help explain the > changes we are making: https://trac.webkit.org/wiki/LayoutUnit If you wor

Re: [webkit-dev] Removing HTML notifications from WebKit (Was: Web Notifications API)

On Wed, Feb 8, 2012 at 7:50 PM, Maciej Stachowiak wrote: > On Feb 8, 2012, at 6:15 PM, Aaron Boodman wrote: >> On Wed, Feb 8, 2012 at 4:58 PM, Jon Lee wrote: >>> 2. Remove HTML notifications. >>> >>> It has been removed from the spec, and we don't intend on ever supporting >>> HTML notifications.

Re: [webkit-dev] ninja build available for chromium/mac, empty builds up to 20x as fast

Nico, correct me if I'm wrong, but I believe you need to "rm -rf out" if you're switching between the make build and the ninja build. Adam On Tue, Feb 7, 2012 at 1:42 PM, Nico Weber wrote: > Hi, > > we recently made the webkit/chromium/mac port buildable with ninja, a > new build system focused

Re: [webkit-dev] What is the license policy of a reviewing patch on Bugzilla (not yet landed to main trunk)?

IANAL, but here's what the bugs.webkit.org attachment page says: == WebKit Contribution Terms: Hello and thank you for contributing a patch. Here is our licensing policy and terms for contributing code to the WebKit project. If you are sending in a patch to existing WebKit code, you agree by

Re: [webkit-dev] Double posting of review comments when using Preview button at bugs.webkit.org

Thanks. I'll investigate. On Fri, Feb 3, 2012 at 10:38 AM, Darin Adler wrote: > This bug report https://bugs.webkit.org/show_bug.cgi?id=77750 describes a > problem I’ve been seeing that is causing me to double post large comments in > many bugs. Really annoying! > > -- Darin >

Re: [webkit-dev] Style bot needs kick

Done. Thanks. On Tue, Jan 31, 2012 at 12:12 PM, Kenneth Russell wrote: > Looks like the workspace on the style bot is messed up. Example failure: > > http://queues.webkit.org/results/11388080 > > Could someone please take a look? > > Thanks, > > -Ken > ___

Re: [webkit-dev] Users of PlatformGestureRecognizer?

On Mon, Jan 30, 2012 at 2:35 PM, Robert Kroeger wrote: > As best as I can tell, only Chromium uses PlatformGestureRecognizer > and its Chromium-specific implementation. Since Chromium no longer > needs the code, would anybody object if I removed it? If it's used only by Chromium, then it seems sa

Re: [webkit-dev] Changing the implementation of KURL

On Sat, Jan 28, 2012 at 5:51 PM, Benjamin Poulain wrote: > On Sat, Jan 28, 2012 at 4:59 PM, Brett Wilson wrote: >> So to clarify, I think we need to keep the current architecture. >> Obviously WebKit needs a URL class that uses its String class, so >> WTFURL would probably be a wrapper around som

Re: [webkit-dev] Changing the implementation of KURL

On Fri, Jan 27, 2012 at 9:44 PM, Darin Fisher wrote: > On Fri, Jan 27, 2012 at 2:39 AM, Adam Barth wrote: >> On Fri, Jan 27, 2012 at 1:49 AM, Maciej Stachowiak wrote: >> > That said, this plan was based on the premise that Chromium folks were >> > willing to cooperat

Re: [webkit-dev] Changing the implementation of KURL

On Fri, Jan 27, 2012 at 1:49 AM, Maciej Stachowiak wrote: > That said, this plan was based on the premise that Chromium folks were > willing to cooperate with the unforking effort, and would be happy to use a > WebKit-integrated URL library based on GoogleURL. If that is no longer the > case, then

Re: [webkit-dev] mac-ews for contributors

On Fri, Jan 27, 2012 at 1:14 AM, wrote: > I am a non-committer yet and I would like to see that my patches are working > correctly on Mac platform as well when I upload them to bugzilla, but the > mac-ews does not work for non-committers. It is laborious work to get r+ > because I do not see if m

Re: [webkit-dev] Changing the implementation of KURL

>> > Also, be mindful that if your goal is to avoid having two implementions >> > of >> > KURL, then part of accomplishing that goal is also switching Chromium >> > over >> > to WTFURL.  I'm guessing that is probably not in your plans.  Do you >>

Re: [webkit-dev] does anyone use the advanced --print options to new-run-webkit-tests besides me?

The EWS configures some custom logging: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/ports.py#L269 Adam On Tue, Jan 24, 2012 at 5:37 PM, Dirk Pranke wrote: > Hi all, > > new-run-webkit-tests, in addition to the --verbose flag, offers the > ability to turn on or off

Re: [webkit-dev] Mac and Chromium Mac EWS

d leave the other 4 as normal EWS machines, and hopefully we can > catch up quickly. > > Thoughts? > Lucas > > > On Jan 25, 2012, at 10:54 AM, Adam Barth wrote: > >> +lforschler >> >> 2012/1/25 Osztrogonac Csaba : >>> Adam Barth írta: >>>&g

Re: [webkit-dev] Mac and Chromium Mac EWS

+lforschler 2012/1/25 Osztrogonac Csaba : > Adam Barth írta: >> On Sat, Jan 21, 2012 at 9:32 AM, Osztrogonac Csaba >> wrote: >>> >>> Something happened with Mac EWS again and now there are 375 >>> stucked patch. Could anyone from Apple check and fix

Re: [webkit-dev] optimising png files in LayoutTests - an experiment

On Tue, Jan 24, 2012 at 10:43 PM, Mike Lawther wrote: > Just thought I'd share the results of an experiment I did in optimising the > png files in LayoutTests. > > I used a tool on Mac called ImageOptim (http://imageoptim.pornel.net/) which > tries a set of different png lossless optimising tools

Re: [webkit-dev] ProgressEvents for Images

On Mon, Jan 23, 2012 at 4:02 PM, Hans Muller wrote: > There's a brief discussion of the cross-origin case in the > ""ProgressEvents for Images" WhatWG thread: > http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-January/034362.htm > l and the WebKit bug about this proposed feature: > https:/

Re: [webkit-dev] Commit-queue

On Mon, Jan 23, 2012 at 11:12 AM, Adam Barth wrote: > On Mon, Jan 23, 2012 at 11:07 AM, Konrad Piascik wrote: >> I'm seeing the commit-queue bot >> http://webkit-commit-queue.appspot.com/queue-status/commit-queue/bots/ec2-cq-02 >> consistently rebooting about every

Re: [webkit-dev] Commit-queue

On Mon, Jan 23, 2012 at 11:07 AM, Konrad Piascik wrote: > I'm seeing the commit-queue bot > http://webkit-commit-queue.appspot.com/queue-status/commit-queue/bots/ec2-cq-02 > consistently rebooting about every hour.  I know I'm not the only one with a > patch that has commit-queue+ waiting for t

Re: [webkit-dev] Top 100 sites browsing tests proprosal

On Sun, Jan 22, 2012 at 3:06 AM, Pablo Flouret wrote: > On Sun, Jan 22, 2012 at 2:52 AM, Sergio Villar Senin > wrote: >> En 21/01/12 14:31, Zoltan Herczeg escribiu: >>> Just be careful with copyright issues. >> >> Could you elaborate on that? > > I believe you'd need explicit permission from eac

Re: [webkit-dev] Mac and Chromium Mac EWS

On Sat, Jan 21, 2012 at 9:32 AM, Osztrogonac Csaba wrote: > Something happened with Mac EWS again and now there are 375 > stucked patch. Could anyone from Apple check and fix it? Lucas and I have been working to enable running the tests on the mac-ews. Unfortunately, there are too many failures

Re: [webkit-dev] Top 100 sites browsing tests proprosal

Go for it. Adam On Sat, Jan 21, 2012 at 2:12 AM, Sergio Villar Senin wrote: > Hi, > > I've been thinking about this for some time now, but only a recent bug > I'm constantly hitting these days > (https://bugs.webkit.org/show_bug.cgi?id=76574) triggered this email > [1]. What I would like to pro

Re: [webkit-dev] Introducing run-perf-tests and Adding Performance Bots

On Thu, Jan 19, 2012 at 3:20 PM, Ryosuke Niwa wrote: > Hi WebKittens, > > Executive Summary > > I've added Tools/Scripts/run-perf-test, try out > Please add --no-timeout and --timeout options to your DRT > Perf-o-matic coming on webkit-perf.appspot.com, a clone of > graphs.mozilla.org > Chromium M

Re: [webkit-dev] Removing deprecatedFrameEncoding

On Thu, Jan 19, 2012 at 1:38 PM, Geoffrey Garen wrote: >>> We don't typically add #ifdefs to cross-platform WebKit code solely to make >>> different choices about web standards and web compatibility in different >>> ports. (Have we ever done that before?) It strikes me as destructive to >>> Web

Re: [webkit-dev] Removing deprecatedFrameEncoding

2012/1/18 Julian Reschke : > If you can write down what you think needs to be done, and can get > Chrome/Firefox/IE/Opera on board, this may be worth documenting. I think > that's what Adam tried ~ 15 months ago. By the way, this my long-term goal. My plan has been to align browser behavior befor

Re: [webkit-dev] Removing deprecatedFrameEncoding

2012/1/18 Alexey Proskuryakov : > 18.01.2012, в 16:23, Julian Reschke написал(а): >> My understanding is that Safari, as shipping, does not use the referring >> page's charset for decoding the C-D filename. Or am I missing something? So >> what default is left? The client's locale? > > Yes, someo

Re: [webkit-dev] Removing deprecatedFrameEncoding

2012/1/18 Alexey Proskuryakov : > 18.01.2012, в 11:26, Geoffrey Garen написал(а): >> Once again, I think the best option is to make a decision about >> deprecatedFrameEncoding based on its merits. > > Most browsers respect default encoding when parsing Content-Disposition (*), > which is against

Re: [webkit-dev] Removing deprecatedFrameEncoding

On Wed, Jan 18, 2012 at 11:26 AM, Geoffrey Garen wrote: >> All that being said, if you don't wish to comply with this standard at >> this time, that's your choice.  I'm just asking for an ifdef so I can >> turn this non-standards compliant code off in the Chromium port. > > We don't typically add

Re: [webkit-dev] Removing deprecatedFrameEncoding

On Mon, Jan 16, 2012 at 3:15 PM, Geoffrey Garen wrote: > I just read through the Bugzilla bugs on this topic. Hopefully, I'm a mostly > neutral observer. > >> We should remove deprecatedFrameEncoding.  Removing the code has the >> following benefits: >> >> 1) Standards compliance. > > To me, this

Re: [webkit-dev] HTML notification usage

I haven't followed all the details, but I believe there are two kinds of notifications: text notifications and HTML notifications. Historically, HTML notifications have been more controversial than text notifications. Jon's patch removes support for HTML notifications but appears to leave support

[webkit-dev] Removing deprecatedFrameEncoding

We've previously discussed this topic in Bug 67882 and Bug 75905. We should remove deprecatedFrameEncoding. Removing the code has the following benefits: 1) Standards compliance. There was a discussion in the HTTP working group about whether the requesting context should be a factor in determin

Re: [webkit-dev] ietestcenter tests

Sure: https://bugs.webkit.org/show_bug.cgi?id=76198 On Thu, Jan 12, 2012 at 11:36 AM, Ojan Vafai wrote: > Could we use a meta bug to track fixes for these tests so others can follow > along? > > On Thu, Jan 12, 2012 at 10:22 AM, Alexey Proskuryakov wrote: >> >> >

[webkit-dev] ietestcenter tests

Hi webkit-dev, As you're probably aware, our friend at Microsoft have posted a bunch of standards compliance tests on . In the spirit of good-natured competition, I thought we might try to get a higher score than the latest beta of IE10. (WebKit's

Re: [webkit-dev] [PATCH] Use 'Ok' and 'Cancel' buttons in JavaScript confirm box.

Thanks, but we don't usually accept patches via the mailing list. Instead, we use . Please see http://www.webkit.org/coding/contributing.html for more information about how to contribute patches to the project. Adam On Tue, Jan 10, 2012 at 11:29 AM, Johannes Obermayr

Re: [webkit-dev] chromium-cg-mac results

To update webkit-dev: chromium-cg-mac is now gone. Thanks everyone, Adam On Wed, Jan 4, 2012 at 8:05 AM, Elliot Poger wrote: > Filed https://bugs.webkit.org/show_bug.cgi?id=75548 ('[rollup] remove > chromium-cg-mac baselines') > > > On Wed, Jan 4, 2012 at 10:37 AM, Ad

Re: [webkit-dev] Understanding WebKit layering and layering violations

rlier in this thread. Platform can depend on third-party libraries (e.g., SQLite) or on operating system facilities. Platform can depend on WTF, but no other code in the WebKit project. Adam > On Thu, Jan 5, 2012 at 7:39 PM, Adam Barth wrote: >> >> On Thu, Jan 5, 2012 at 4:18 PM, Fad

<    1   2   3   4   5   6   7   8   9   10   >