Re: [webkit-dev] Towards a unified build system

On Tue, Mar 1, 2011 at 1:38 AM, Patrick R. Gansterer wrote: >> Looking around the web, there are a handful of systems that could do >> the job.  Dimitri, Eric, and I have started experimenting with one >> such system, GYP.  There are various trade-offs between GYP and other >> systems, such as CMa

[webkit-dev] Towards a unified build system

As we've discussed off-and-on for a while, one of the larger pain-points in working on WebKit today is the large number of build systems. Simple things, like adding, removing, or renaming a file take a lot more effort than they should. There are a number of approaches we could take to addressing

Re: [webkit-dev] Test Expectations: A Pipe Dream

Some thoughts on the below: 1) An incremental step towards the below is getting the EWS bots to run the tests in the first place. That would be useful even if they didn't know how to add new expectations to attachments. 2) Architecturally, this will require some changes to how the EWS works. Th

[webkit-dev] Leopard Debug

As far I as I can tell, Leopard Debug is not consistently green: http://build.webkit.org/waterfall?show=Leopard%20Intel%20Debug%20(Build) In fact, it's been failing to build much more often than not for an extended period of time (i.e., several weeks). Based on these observations, it should not

Re: [webkit-dev] beforeload & link (esp rel prefetch)

2011/2/23 Alexey Proskuryakov : > 23.02.2011, в 17:06, Adam Barth написал(а): >>> I think that adding beforeload to META-based prefetch and icon types makes >>> a lot of sense. For subresource rel type, we may want to register it first, >>> as mentioned by Julia

Re: [webkit-dev] beforeload & link (esp rel prefetch)

2011/2/23 Alexey Proskuryakov : > I think that adding beforeload to META-based prefetch and icon types makes a > lot of sense. For subresource rel type, we may want to register it first, as > mentioned by Julian. Looks like Gavin already registered it on 5 November 2010, so we're all set in that

Re: [webkit-dev] Is this a possible source of test flakiness?

On Mon, Feb 21, 2011 at 3:42 PM, Darin Adler wrote: > On Feb 20, 2011, at 8:19 PM, Xianzhu Wang wrote: >> My question is: Is this kind of usage (referencing a later-defined function >> in onload event handler) correct in theory? > > Yes. > > The contents of the onload attribute don’t matter until

Re: [webkit-dev] Every build is crashing

On Tue, Feb 15, 2011 at 1:11 AM, Alexey Proskuryakov wrote: > 15.02.2011, в 00:04, Adam Barth написал(а): >> /me is sad >> >> Since: 02/14/2011 13:13:56 (11 hours ago) >> >> http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r78502%20(25324

[webkit-dev] Every build is crashing

/me is sad Since: 02/14/2011 13:13:56 (11 hours ago) http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r78502%20(25324)/http/tests/xmlhttprequest/cache-override-crash-log.txt Thread 0 Crashed: Dispatch queue: com.apple.main-thread 0 libSystem.B.dylib 0x

Re: [webkit-dev] Which MIME type is best for JavaScript in WebKit?

MIME types for JavaScript have a sad, painful history, largely related to the JavaScript/ECMAScript name fight and the IETF being unhelpful. For example, here's a note about this topic in the HTML5 specification: 8< Note: The term "JavaScript" is used to refer to ECMA262, rather than the o

Re: [webkit-dev] Enable ArrayBuffer by default?

On Fri, Feb 11, 2011 at 11:45 AM, Adam Barth wrote: > On Fri, Feb 11, 2011 at 10:00 AM, Chris Marrin wrote: >> On Feb 11, 2011, at 9:09 AM, Alex Milowski wrote: >>> On Fri, Feb 11, 2011 at 1:41 AM, Adam Barth wrote: >>>> How would folks feel about enabling Arr

Re: [webkit-dev] Enable ArrayBuffer by default?

On Fri, Feb 11, 2011 at 10:00 AM, Chris Marrin wrote: > On Feb 11, 2011, at 9:09 AM, Alex Milowski wrote: >> On Fri, Feb 11, 2011 at 1:41 AM, Adam Barth wrote: >>> How would folks feel about enabling ArrayBuffer by default?  It seems >>> to be a basic data type that

[webkit-dev] Enable ArrayBuffer by default?

How would folks feel about enabling ArrayBuffer by default? It seems to be a basic data type that's used by a bunch of stuff today and likely to be used by more stuff in the future. The API seems pretty stable and it's implemented by Firefox as well. Adam

Re: [webkit-dev] Preload Scanner in WebKit

On Thu, Feb 10, 2011 at 11:09 PM, ROSE-nd-ASH wrote: > While trying to understand preload scanning in WebKit code, I got to know > that it only starts when HTMLTokenizer encounters JavaScript. Am I right in > concluding so? > If yes, why it's not started if when CSS files or other sub-resources  a

Re: [webkit-dev] Moving WTF out of JavaScriptCore

On Wed, Feb 9, 2011 at 1:30 PM, Mark Rowe wrote: > On 2011-02-09, at 13:06, Adam Barth wrote: >> On Thu, Dec 23, 2010 at 1:32 PM, Maciej Stachowiak wrote: >>> On Dec 22, 2010, at 12:06 PM, Adam Barth wrote: >>>> On Wed, Dec 22, 2010 at 10:40 AM, Mark Rowe wrote:

Re: [webkit-dev] Moving WTF out of JavaScriptCore

On Thu, Dec 23, 2010 at 1:32 PM, Maciej Stachowiak wrote: > On Dec 22, 2010, at 12:06 PM, Adam Barth wrote: >> On Wed, Dec 22, 2010 at 10:40 AM, Mark Rowe wrote: >>> On 2010-12-22, at 10:34, Adam Barth wrote: >>>> As an aside, would creating the Sources directory m

Re: [webkit-dev] code review tool changes

Thanks for the feedback. Please feel encouraged to let me and others know how you'd like these tools improved. Adam On Wed, Feb 9, 2011 at 10:49 AM, Oliver Hunt wrote: > I just discovered that the review tool doesn't save the general comments, > only inline ones (http://webkit.org/b/54121).  T

Re: [webkit-dev] Question regarding priorities of subresource content retrieval

te Chapin wrote: >> The default prioritization is found here: >> http://trac.webkit.org/browser/trunk/Source/WebCore/loader/cache/CachedResource.cpp#L51. >> There are cases where we override this (e.g., I'm pretty sure we load >> favicons at a lower priority

Re: [webkit-dev] Question regarding priorities of subresource content retrieval

There is already some amount of code that's involved with prioritizing subresource loads. See http://trac.webkit.org/browser/trunk/Source/WebCore/loader/ResourceLoadScheduler.h and http://trac.webkit.org/browser/trunk/Source/WebCore/loader/cache/CachedResourceLoader.h. I suspect the prioritizati

Re: [webkit-dev] Proposal: Let's make the WebKit2 test bot a core builder

Go for it. The only requirement to be a core build is that the bot is green. If the bot is red for long stretches, we can remove it. Adam On Sun, Feb 6, 2011 at 2:16 PM, Maciej Stachowiak wrote: > > I'd like to add  "SnowLeopard Intel Release (WebKit2 Tests)" to the set of > core builders. >

Re: [webkit-dev] Nightly (r77618) hangs when submitting a review

Sorry, that's probably my fault. Mitz kindly fixed the issue for me (although he didn't add a test): http://trac.webkit.org/changeset/77697 Apologies for the inconvenience. We've switched over to a new XSS filter in last night's nightly, so let me know if you have any XSS filter-related trouble

[webkit-dev] Thanks for a green tree

I'd like to thank everyone who's been working to make the tree green again. The tree has been pretty red these past few days, which makes it harder to prevent regressions. I was pleasantly surprised to pull up the tree just now and see lots of green boxes. Thanks! Adam P.S., It looks like we s

Re: [webkit-dev] No buildbot coverage for Mac Debug

isn't one of the core testers. > > We are working on a fix for Leopard debug. > > -- Stephanie > > On Feb 3, 2011, at 4:06 PM, Adam Barth wrote: > >> Looking into a failure I saw locally on my machine, I noticed that we >> don't have any buildbot coverag

[webkit-dev] No buildbot coverage for Mac Debug

Looking into a failure I saw locally on my machine, I noticed that we don't have any buildbot coverage for the Debug build on Mac. We used to cover this configuration with a Leopard bot, but that bot has been unable to link for a while (we think because of insufficient memory). Would it be possib

Re: [webkit-dev] About removing comments

On Tue, Feb 1, 2011 at 9:52 PM, Simon Fraser wrote: > On Feb 1, 2011, at 9:51 PM, Adam Barth wrote: >> On Tue, Feb 1, 2011 at 9:47 PM, Alexey Proskuryakov wrote: >>> Please don't start a comment removing crusade! >>> >>> I've just noticed a patch th

Re: [webkit-dev] About removing comments

On Tue, Feb 1, 2011 at 9:47 PM, Alexey Proskuryakov wrote: > > Please don't start a comment removing crusade! > > I've just noticed a patch that got landed a few hours ago, which removed a > comment I found quite useful when fixing a bug in related code, >

Re: [webkit-dev] Using Visual Studio 2010 for Apple's Windows WebKit port

On Mon, Jan 31, 2011 at 6:04 PM, Jeremy Orlow wrote: > How hard will the transition be?  If it's going to take a lot of time and > cause a lot of churn anyway, would this be a good time to try and make that > port use GYP or CMake?  (I assume the answer is probably no, but figured it > was worth a

Re: [webkit-dev] coding style and comments

: http://trac.webkit.org/browser/trunk/Source/WebCore/loader/FrameLoader.cpp#L2717 It saved me a bunch of time digging through the history of FrameLoader to understand why that code was written the way it was. Adam On Sun, Jan 30, 2011 at 10:27 AM, Adam Barth wrote: > On Sun, Jan 30, 2011 a

Re: [webkit-dev] coding style and comments

On Sun, Jan 30, 2011 at 7:40 AM, David Kilzer wrote: > An interesting case study would be the (still ongoing?) refactoring of the > loader code over the past few months (thanks to Adam Barth and others).   Is > it easier to understand now than before the refactoring started?  How many &

Re: [webkit-dev] Same Origin Restriction on WOFF fonts across WebKit

On Fri, Jan 28, 2011 at 4:07 PM, Maciej Stachowiak wrote: > On Jan 28, 2011, at 3:44 PM, Adam Barth wrote: >> On Fri, Jan 28, 2011 at 3:11 PM, Maciej Stachowiak wrote: >>> On Jan 28, 2011, at 3:06 PM, Tab Atkins Jr. wrote: >>>> The WOFF font specification requires t

Re: [webkit-dev] Same Origin Restriction on WOFF fonts across WebKit

On Fri, Jan 28, 2011 at 3:11 PM, Maciej Stachowiak wrote: > On Jan 28, 2011, at 3:06 PM, Tab Atkins Jr. wrote: >> The WOFF font specification requires that browsers apply Same Origin >> Restrictions (SOR) to WOFF fonts.  So far, Firefox and IE9 follow this >> requirement, while we and Opera don't.

Re: [webkit-dev] style checking and build failed without any useful info.

of? >> >> 2. This patch is significantly larger, $190KB. >> Adam, please take a look at the log when you get a chance. >> Thanks. >> >> On Jan 27, 2011, at 6:32 PM, Adam Barth wrote: >> >> Strange.  We've had problems before where the writes don

Re: [webkit-dev] style checking and build failed without any useful info.

Strange. We've had problems before where the writes don't quite make it all the way to AppEngine (which hosts queues.webkit.org), but it's strange that all the bots would run into the same problem. It might be worth uploading the patch again to see if the problem recurs. Eric or I can also dig i

Re: [webkit-dev] beforeload & link (esp rel prefetch)

2011/1/20 Gavin Peters (蓋文彼德斯) : > I also have thought about how we can go forward, I'd like folks > comments on this: > > Step 1: Land bug 51941, a refactoring of the HTMLLinkPrefetch element > which pulls out loading for rel types prefetch, icon and dns-prefetch. That sounds like a reasonable fi

Re: [webkit-dev] Best way to rebaseline 400+ tests?

Unfortunately, we don't have a good solution to this problem at the moment. Mihai can comment on the status of webkit-patch rebaseline-server, which is pretty awesome. webkit-patch rebaseline is another option, but it's pretty bare-bones. Koz is working on a new rebaseline command to rule them a

Re: [webkit-dev] beforeload & link (esp rel prefetch)

2011/1/20 Darin Adler : > On Jan 20, 2011, at 5:52 PM, Gavin Peters (蓋文彼德斯) wrote: > > [2] I just installed Incognito mode in a local Safari, and sniffed it. I can > confirm requests to blocked domains go straight through; with cookies, > everything. The only place you won't see them is in the docu

Re: [webkit-dev] Please do NOT call Position::Position(node, offset) or Position::node()

One approach we've used in other code is to put the word "deprecated" in the name of the function in question. That makes these issues very visible in code reviews. For a constructor, you can require an enum value with depreciated in its name. Adam On Wed, Jan 19, 2011 at 6:11 PM, Ryosuke Niwa

Re: [webkit-dev] Leopard Bot has been broken for 5 days.

I investigated this issue for a while. Disabling the test just causes the next test to fail. I'm not very familiar with this code. I can spend more time investigating, but having someone familiar with ideographs would likely be more efficient. Adam On Tue, Jan 18, 2011 at 4:49 PM, Eric Seidel

Re: [webkit-dev] question re: including some python-licensed code into the tree

In the past, we've used autoinstall to make use of library code that doesn't have a compatible license, assuming that the library is freely distributed on the Internet. However, that approach does not seem appropriate for this particular use. Adam On Tue, Jan 18, 2011 at 3:59 PM, Dirk Pranke w

Re: [webkit-dev] Done moving source files into Source

On Mon, Jan 17, 2011 at 4:28 AM, Patrick Gansterer wrote: > Adam Barth: >>> Otherwise we need to keep the files in the root directory. :-( >> >> I'm not sure I understand the connection.  For example, >> cmakeconfig.h.cmake seems to be entirely concerned wi

Re: [webkit-dev] Done moving source files into Source

On Mon, Jan 17, 2011 at 2:49 AM, Patrick Gansterer wrote: > Congratulation! > > Adam Barth: > >> If you own one of the files below, please consider moving it from the >> root directory to the Source directory: >> >> cmakeconfig.h.cmake >> CMakeLists.

Re: [webkit-dev] Done moving source files into Source

Yes, but not immediately. Adam On Mon, Jan 17, 2011 at 3:43 AM, Kenneth Rohde Christiansen wrote: > Were you going to move wtf out of JavaScriptCore as well? > > Kenneth > > On Mon, Jan 17, 2011 at 11:12 AM, Adam Barth wrote: >> As of early this morning, I've fini

[webkit-dev] Done moving source files into Source

As of early this morning, I've finished moving all the source files around. I'd like to congratulate myself on painting the bike shed a beautiful shade of pink. WebKitLibraries probably should be renamed to Libraries, but that's blocked on moving LayoutTests to RegressionTests (to free up the "L"

Re: [webkit-dev] New mailling list for buildbot events?

On Fri, Jan 14, 2011 at 8:06 AM, William Siegrist wrote: > On Jan 13, 2011, at 7:33 PM, Ryosuke Niwa wrote: >> Getting build bots result for every single revision seems quite noisy.  Will >> be possible to have a page where I can signup for an email or is it too hard >> to maintain? >> >> e.g. I

Re: [webkit-dev] WebCore has moved: How to avoid merge conflicts

; > On Jan 8, 2011, at 9:44 AM, Dimitri Glazkov wrote: > >> Thanks for your hard work, Adam! >> >> I tried this morning to follow your steps. It worked great, except >> there were a few .orig files left after webkit-patch had run. I >> removed them by hand and was on

Re: [webkit-dev] Help with GTK build

On Mon, Jan 10, 2011 at 12:32 AM, Alejandro Garcia Castro wrote: > On Sat, Jan 08, 2011 at 12:50:11PM +0100, Alejandro G. Castro wrote: >> On Sat, Jan 08, 2011 at 12:20:18PM +0100, Alejandro G. Castro wrote: >> > >> > [...] >> > >> > Yeah, it is the length, we already had that issue when doing "ma

[webkit-dev] WebCore has moved: How to avoid merge conflicts

As of r75314, WebCore is now located in Source/WebCore. If you have outstanding patches to WebCore, here's what you can do to avoid merge conflicts: 1) *BEFORE* updating past r75314, create a patch for your change, either with svn-create-patch or by uploading your patch to bugs.webkit.org with web

[webkit-dev] Help with GTK build

Hi GTK folks, As we've been discussing, I moved WebCore this evening. The GTK bot has a mysterious build error that I'm hoping you can help me with: make all-am make[1]: Entering directory `/home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug' /bin/mkdir -p ./.deps/DerivedSources ma

Re: [webkit-dev] Regarding SecurityOrigin API usage

On Thu, Jan 6, 2011 at 10:17 PM, Pushparajan V wrote: > On Fri, Jan 7, 2011 at 1:18 AM, Adam Barth wrote: >> On Thu, Jan 6, 2011 at 6:27 AM, Pushparajan V wrote: >>> I have a query regarding addOriginAccessWhitelistEntry API in >>> SecurityOrigin.cpp. Is there any

Re: [webkit-dev] RuntimeEnabledFeatures for JSC (was RE: Getting at Settings object from WorkerContext)

On Thu, Jan 6, 2011 at 1:04 PM, Jeremy Orlow wrote: > On Thu, Jan 6, 2011 at 8:57 PM, Adam Barth wrote: >> On Thu, Jan 6, 2011 at 12:47 PM, Darin Adler wrote: >> > On Jan 6, 2011, at 12:41 PM, Joe Mason wrote: >> >> I took a look at CodeGeneratorJS.pm to se

Re: [webkit-dev] RuntimeEnabledFeatures for JSC (was RE: Getting at Settings object from WorkerContext)

On Thu, Jan 6, 2011 at 12:47 PM, Darin Adler wrote: > On Jan 6, 2011, at 12:41 PM, Joe Mason wrote: >> I took a look at CodeGeneratorJS.pm to see how hard it would be to port this >> over. I have no idea where to start…  The structure of CodeGeneratorJS.pm >> and CodeGeneratorV8.pm seem quite di

Re: [webkit-dev] Regarding SecurityOrigin API usage

On Thu, Jan 6, 2011 at 6:27 AM, Pushparajan V wrote: > I have a query regarding addOriginAccessWhitelistEntry API in > SecurityOrigin.cpp. Is there any special requirement in the > sourceOrigin argument of this API when the scheme of the sourceOrigin > is already added to the localScheme list? Th

[webkit-dev] WebCore, WebKit, WebKit2 moving to Source this weekend

People of WebKit, If the stars align, I'm going to move WebCore, WebKit, and WebKit2 to the Source directory this weekend. As with the JavaScriptCore move, I'll teach svn-apply how to apply patches that reference the old locations, which should help you avoid merge conflicts as before. Adam

Re: [webkit-dev] git history and the moving to Source

include renames. >> >> 2) If you are viewing diffs (like with -p), you must pass -M etc. just >> as you would to git diff for it to find renames. >> >> Here's an interesting thread from Linus on the subject: >>   http://kerneltrap.org/mailarchive/git/2009/1/30

Re: [webkit-dev] git history and the moving to Source

There's a git option to follow renames. I think it's --follow, but some git experts might know better. Adam On Mon, Jan 3, 2011 at 5:53 PM, Balazs Kelemen wrote: > I have just realized that git log -- filename does not output the > history before the file had been moved to Source. It seems lik

[webkit-dev] Qt buildbot help

I'm having trouble getting the Qt build bots to compile again after moving JavaScriptCore into Source. They don't seem to realize that PLATFORM(QT) should be defined. I suspect they might just need a clobber, but I'm not sure how to do that via build.webkit.org. I'd be much obliged if someone wi

[webkit-dev] JavaScriptCore has moved: How to avoid merge conflicts

As of r74855, JavaScriptCore is now located in Source/JavaScriptCore. If you have outstanding patches to JavaScriptCore, here's what you can do to avoid merge conflicts: 1) *BEFORE* updating past r74855, create a patch for your change, either with svn-create-patch or by uploading your patch to bug

Re: [webkit-dev] Regarding the preload scanner in WebKit

On Fri, Dec 31, 2010 at 2:16 AM, Aneesh Bhasin wrote: > Hi Adam, > > Thanks for the quick reply. A few more questions for my own understanding : > > On Thu, Dec 30, 2010 at 10:08 AM, Adam Barth wrote: >> On Wed, Dec 29, 2010 at 8:19 PM, Aneesh Bhasin >> wrote: >&g

Re: [webkit-dev] More thoughts on cleaning up the root directory

On Mon, Dec 27, 2010 at 1:28 PM, Adam Barth wrote: > On Mon, Dec 27, 2010 at 1:25 PM, Darin Adler wrote: >> On Dec 27, 2010, at 11:14 AM, Adam Barth wrote: >>> On Mon, Dec 27, 2010 at 10:37 AM, Mark Rowe wrote: >>>> Can someone also elaborate on why "S

Re: [webkit-dev] Regarding the preload scanner in WebKit

On Wed, Dec 29, 2010 at 8:19 PM, Aneesh Bhasin wrote: > I have been reading about the preload scanner that is supported in the > WebKit since quite some time now ( > http://webkit.org/blog/166/optimizing-page-loading-in-web-browser/ ) . As > per my understanding (please correct me if I am wrong),

Re: [webkit-dev] More thoughts on cleaning up the root directory

On Mon, Dec 27, 2010 at 1:25 PM, Darin Adler wrote: > On Dec 27, 2010, at 11:14 AM, Adam Barth wrote: >> On Mon, Dec 27, 2010 at 10:37 AM, Mark Rowe wrote: >>> Can someone also elaborate on why "Sources" was chosen as the top-level >>> directory name rat

Re: [webkit-dev] More thoughts on cleaning up the root directory

ave slightly different ideas about what should go into this folder. That sounds like a complex topic that we might need to discuss more later. On Mon, Dec 27, 2010 at 3:58 AM, Patrick Gansterer wrote: > Adam Barth: >> There are a bunch of build-system related files that are currently in &

[webkit-dev] More thoughts on cleaning up the root directory

Here's a snapshot of my current thinking on where the files and folders currently in the top-level directory might go. There are a bunch of build-system related files that are currently in the root. I'm not sure whether we should leave them in there or move them into Sources somewhere. I'm tempt

Re: [webkit-dev] Moving source code to Sources

tual move. The tree may look a little messy > for a while though. > Regards, > Carl > > On 24 Dec 2010 23:39, "Adam Barth" wrote: > > Thanks for the suggestion.  I'll read up on svn:externals.  One thing > we were thinking about doing was teaching svn-apply h

Re: [webkit-dev] Moving source code to Sources

t; It would be easy to write a small sed script to fix patches.  One > could even just build such into svn-apply rather trivially. > > -eric > > On Fri, Dec 24, 2010 at 3:13 AM, Adam Barth wrote: >> I've started the process o... ___

[webkit-dev] Moving source code to Sources

I've started the process of moving the source code to a Sources directory. So far, I've moved JavaScriptGlue, which is a small project used by the Mac build. I'll be moving the rest of the projects, as discussed. Moving the code to Sources will let us break out various components, such as WTF an

Re: [webkit-dev] Ports that use the checked-in image decoders

On Wed, Dec 22, 2010 at 3:13 PM, Darin Adler wrote: > On Dec 22, 2010, at 2:59 PM, Eric Seidel wrote: >> both Apple's Windows port and Chromium's windows port use the checked-in >> image decoders > > I believe that’s incorrect. > > The WebKit that comes with Safari on Windows uses image decoders

[webkit-dev] Moving WTF out of JavaScriptCore

[Forking the thread] On Wed, Dec 22, 2010 at 10:40 AM, Mark Rowe wrote: > On 2010-12-22, at 10:34, Adam Barth wrote: >> As an aside, would creating the Sources directory make it easier to >> move WTF out of JavaScriptCore? > > I don't think that the location of the sour

Re: [webkit-dev] Renaming directories

On Wed, Dec 22, 2010 at 10:27 AM, Mark Rowe wrote: > > On 2010-12-22, at 10:19, Adam Barth wrote: > > On Wed, Dec 22, 2010 at 9:37 AM, Kenneth Russell wrote: > > On Tue, Dec 21, 2010 at 11:40 PM, Adam Barth wrote: > > On Tue, Dec 21, 2010 at 11:30 PM, Darin Adler wrote:

Re: [webkit-dev] Renaming directories

On Wed, Dec 22, 2010 at 9:37 AM, Kenneth Russell wrote: > On Tue, Dec 21, 2010 at 11:40 PM, Adam Barth wrote: >> On Tue, Dec 21, 2010 at 11:30 PM, Darin Adler wrote: >>> On Dec 21, 2010, at 11:20 PM, Adam Barth wrote: >>>> Looking through my working copy, the

Re: [webkit-dev] Renaming directories

On Tue, Dec 21, 2010 at 11:30 PM, Darin Adler wrote: > On Dec 21, 2010, at 11:20 PM, Adam Barth wrote: >> Looking through my working copy, there are a couple of things that aren't >> obvious to me where they would go in this structure: WebKitBuild and >> WebKitLi

Re: [webkit-dev] Renaming directories

On Tue, Dec 21, 2010 at 10:59 AM, Darin Adler wrote: > Before we move LayoutTests, we might want to discuss further changes to > structure. > > Mark Rowe and I talked about this briefly and he suggested a top level with > just: > >    Examples >    Sources >    Tests >    Tools >    Websites > >

Re: [webkit-dev] Renaming directories

On Mon, Dec 20, 2010 at 12:31 PM, Darin Adler wrote: > On Dec 19, 2010, at 3:22 AM, Mark Rowe wrote: >> My 2¢: Add a top-level Sites directory and then do the following: >> WebKitSite => Sites/webkit.org >> BugsSite => Sites/bugs.webkit.org >> PlanetWebKit => Sites/planet.webkit.org > > Yes, that

Re: [webkit-dev] Renaming directories

On Sun, Dec 19, 2010 at 7:32 AM, Dimitri Glazkov wrote: > On Sun, Dec 19, 2010 at 3:22 AM, Mark Rowe wrote: >> On 2010-12-18, at 08:43, Darin Adler wrote: >> On Dec 18, 2010, at 2:23 AM, Adam Barth wrote: >> >> While we're in the mood to rename directories, wou

Re: [webkit-dev] Renaming directories

On Sat, Dec 18, 2010 at 11:39 AM, William Siegrist wrote: > On Dec 18, 2010, at 11:05 AM, Adam Barth wrote: >> On Sat, Dec 18, 2010 at 8:43 AM, Darin Adler wrote: >>> On Dec 18, 2010, at 2:23 AM, Adam Barth wrote: >>> >>>> While we're in the mood to re

Re: [webkit-dev] Renaming directories

On Sat, Dec 18, 2010 at 8:43 AM, Darin Adler wrote: > On Dec 18, 2010, at 2:23 AM, Adam Barth wrote: > >> While we're in the mood to rename directories, would these renamings make >> sense: >> >> WebKitSite => WebSite >> WebKitExamplePlugins => Exa

[webkit-dev] Renaming directories

While we're in the mood to rename directories, would these renamings make sense: WebKitSite => WebSite WebKitExamplePlugins => ExamplePlugins LayoutTests => Tests Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailm

Re: [webkit-dev] Build Slave Shutdown

button to solve those problems, but perhaps I should have just talked with you directly instead. Adam On Thu, Dec 16, 2010 at 2:39 PM, William Siegrist wrote: > Forced builds are still enabled. But you normally shutdown slaves you do not > have shell access to? > > On Dec 16, 2

Re: [webkit-dev] Build Slave Shutdown

I've used the shutdown/restart functionality before to try to unwedge a broken bot. The most useful feature, though, is the force build feature, which I use occasionally late at night when the tree is quiet to probe for flakiness. Adam On Thu, Dec 16, 2010 at 9:05 AM, William Siegrist wrote: >

Re: [webkit-dev] Looking for a V8 bindings volunteer to fix setLocation, open, and showModalDialog

Sure. On Fri, Dec 10, 2010 at 6:21 PM, Darin Adler wrote: > Hi folks. > > I’m moved the logic of setLocation, open, and showModalDialog out of the > JavaScript bindings and into the DOMWindow class. > > http://trac.webkit.org/changeset/73647 > http://trac.webkit.org/changeset/73660 > http://trac

Re: [webkit-dev] WebKitTools is changing to Tools

Is it time to throw the switch now? Adam On Sun, Nov 21, 2010 at 9:55 AM, Dan Bernstein wrote: > > On Nov 21, 2010, at 5:41 AM, Eric Seidel wrote: > > That's likely to break all the ews and commit bots. Since I'm on vacation at > least the ones I run will remain broken until I return on 29th. >

Re: [webkit-dev] When are patches added to EWS Queue?

Hi Brian, We had an issue with the EWS today when the machine ran out of disk. I'm in the process of bringing up a new machine with 10x the disk space. There's nothing you need to do. Everything should get rolling shortly. Adam On Tue, Dec 7, 2010 at 7:20 PM, Brian Weinstein wrote: > I uploa

Re: [webkit-dev] Why do both DOMWindow and Document objects hold SecurityOrigin objects?

At the time when we introduced DOMWindow::securityOrigin, there was a situation where we needed to know the security origin of something but the document wasn't available. Hopefully that reason has disappeared and we can remove DOMWindow::securityOrigin. Adam On Tue, Dec 7, 2010 at 12:16 PM, Sa

Re: [webkit-dev] Better approach for JavaScript bindings, especially for the DOM window object

This sounds like a good approach. Historically, we've tried to keep as many of the security checks in the bindings themselves because they might not be applicable for bindings to other languages, such as Objective C. In some cases, like javascript URLs, the API surface in the bindings was too hug

Re: [webkit-dev] webkit-patch rebaseline problem

It would be helpful to see more of the stack trace, but I bet it's trying to access some URL that doesn't exist, probably on build.webkit.org. Adam On Tue, Dec 7, 2010 at 1:20 AM, Alejandro Garcia Castro wrote: > > Hi, > > does anyone know anything about this issue executing rebaseline? > > xml

Re: [webkit-dev] cr-mac-ews

maruel mentioned something about command-line flags we can pass to gclient to make it more robust. Adam On Sun, Dec 5, 2010 at 9:49 AM, Dimitri Glazkov wrote: > You need to rm -rf /Projects/CrMacEWS/WebKit/chromium/third_party. We > had to do the same for build.webkit.org builders this week. >

Re: [webkit-dev] Exposing CSS pixel metrics to the scripting environment

rmation to media queries in CSS: the > very hackish result of this would mean a dozen or so css declarations, > calibrated for the Mozilla browser environment, then some JS to pull through > and see which media queries were active. A proprietary, ugly, approach in > itself. >

Re: [webkit-dev] Exposing CSS pixel metrics to the scripting environment

As a general rule, if Mozilla refuses to implement a feature, we're unlikely to implement the feature unless there is a very compelling reason to do so. Proprietary features are harmful to the web, which is why we prefer to discuss new features in standards bodies. Adam On Sat, Nov 27, 2010 at

Re: [webkit-dev] Why are the mock implementations in WebCore/platform?

Originally, I thought it made sense to mock out pieces of the platform abstraction that didn't exist in all ports (e.g., GPS sensors). I'm not sure why you'd want to mock out a client interface. Can't you just implement the client interface in DRT? Adam On Fri, Nov 26, 2010 at 10:33 AM, Sam We

Re: [webkit-dev] change in behavior of review page in bugzilla

orwarded message -- > From: > Date: Mon, Nov 8, 2010 at 2:18 PM > Subject: [webkit-changes] [71570] trunk/BugsSite > To: webkit-chan...@lists.webkit.org > > > Revision 71570 Author aba...@webkit.org Date 2010-11-08 14:18:05 -0800 (Mon, > 08 Nov 2010) > > Log Message

[webkit-dev] Can't build Chromium Linux

Both my Chromium Linux boxes are getting this compile error, which doesn't seem to be showing up on the bots: WebKit/chromium/third_party/ffmpeg/patched-ffmpeg-mt/libavcodec/libvpxdec.c:27: fatal error: vpx/vpx_decoder.h: No such file or directory This is preventing the chromium-ews from running.

Re: [webkit-dev] W3C Proposal: User Interface Independence for Accessible Rich Internet Applications

On Fri, Nov 5, 2010 at 6:40 PM, James Robinson wrote: > On Fri, Nov 5, 2010 at 6:32 PM, James Craig wrote: >> Ojan Vafai wrote: >> >> How is [ DOMAttributeChangeRequestEvent ] any different than >> DOMAttrModified? The spec claims it doesn't have the problems that >> DOMAttrModified has, but I do

Re: [webkit-dev] HTML5 Parsing & MathML

On Tue, Nov 2, 2010 at 9:52 AM, David Carlisle wrote: > On 2 November 2010 16:26, Adam Barth wrote: >> On Tue, Nov 2, 2010 at 7:55 AM, David Carlisle >> wrote: >>> Alex Milowski milowski.org> writes: >>> >>> sorry for late reply, I&#x

Re: [webkit-dev] HTML5 Parsing & MathML

On Tue, Nov 2, 2010 at 7:55 AM, David Carlisle wrote: > Alex Milowski milowski.org> writes: > > sorry for late reply, I'm not subscribed, just saw this in the archives. > >> >> On Fri, Oct 1, 2010 at 12:52 PM, Adam Barth webkit.org> wrote: >> > Our p

Re: [webkit-dev] Line breaking

Ok, you asked for it. :) Adam On Fri, Oct 29, 2010 at 12:16 AM, David Hyatt wrote: > Pick me! Pick me! > > On Oct 29, 2010, at 1:54 AM, Adam Barth wrote: > >> In looking at a bunch of web compat bugs filed in the Chromium bug >> tracker, it seems like WebKit'

[webkit-dev] Line breaking

In looking at a bunch of web compat bugs filed in the Chromium bug tracker, it seems like WebKit's line breaking behavior is a major source of compatibility problems. I'm currently writing a test suite to reverse engineer the line breaking behavior of other browsers. I'm not familiar with the his

Re: [webkit-dev] Adding new JS bindings, having "slight" problems

If this is part of ECMAScript, it should be in the JavaScript engine proper, not in WebCore. With respect to missing features of the IDL compiler, we add features to the IDL compiler as we need them. There's lots of stuff in WebIDL that we haven't needed to implement yet. Adam On Wed, Oct 27,

Re: [webkit-dev] webkit-patch --suggest-reviewers

48182 > Dave > > ____ > From: Adam Barth > To: webkit-dev@lists.webkit.org > Sent: Thu, October 21, 2010 10:09:12 PM > Subject: [webkit-dev] webkit-patch --suggest-reviewers > > Eric and I are working on a new feature of webkit-patch to make it > easier for

[webkit-dev] webkit-patch --suggest-reviewers

Eric and I are working on a new feature of webkit-patch to make it easier for you to find reviewers for your code. When you upload a patch with webkit-patch, you can try passing the --suggest-reviewers option. webkit-patch will look at your patch and try to guess who might be good reviewers (and

Re: [webkit-dev] Tiger?

te: > Ping? > > On Mon, Oct 11, 2010 at 9:26 AM, Adam Barth wrote: >> >> I don't see a Tiger buildbot anymore.  Does that mean I'm allowed to >> break the Tiger build?  If so, can we rip out all the Tiger-specific >> code? >> >> Adam >>

<    3   4   5   6   7   8   9   10   11   12   >