Re: [webkit-dev] ResourceHandle and the Frame parameter

2007-06-12 Thread Morgan L
--- Maciej Stachowiak <[EMAIL PROTECTED]> wrote: > > On Jun 12, 2007, at 5:41 PM, Morgan L wrote: > > > > > --- Maciej Stachowiak <[EMAIL PROTECTED]> wrote: > > > >> > >> On Jun 12, 2007, at 5:22 PM, Maciej Stachowiak > >> wrot

Re: [webkit-dev] ResourceHandle and the Frame parameter

2007-06-12 Thread Morgan L
--- Maciej Stachowiak <[EMAIL PROTECTED]> wrote: > > On Jun 12, 2007, at 5:22 PM, Maciej Stachowiak > wrote: > > > > > On Jun 12, 2007, at 2:33 PM, Darin Adler wrote: > > > >> I think we'll have to rethink this. > ResourceHandle is intended to > >> be a low level networking layer, and so it >

Re: [webkit-dev] ResourceHandle and the Frame parameter

2007-06-12 Thread Morgan L
I went ahead and filed a bug for this issue: http://bugs.webkit.org/show_bug.cgi?id=14106 --- Morgan L <[EMAIL PROTECTED]> wrote: > In the meantime, will you accept a patch to add a > Frame pointer to loadResourceSynchronously? > > > > --- Darin Adler <[EMAIL

Re: [webkit-dev] ResourceHandle and the Frame parameter

2007-06-12 Thread Morgan L
In the meantime, will you accept a patch to add a Frame pointer to loadResourceSynchronously? --- Darin Adler <[EMAIL PROTECTED]> wrote: > I think we'll have to rethink this. ResourceHandle > is intended to be > a low level networking layer, and so it doesn't make > sense to have > higher l

[webkit-dev] ResourceHandle and the Frame parameter

2007-06-12 Thread Morgan L
Congrats on the windows launch! :-) Now, on to my question... There is a comment in ResourceHandle.h about the Frame parameter to ResourceHandle's static create function. The comment suggests that the Frame parameter might be removed in the future or that it at least shouldn't be there. I want

[webkit-dev] FrameLoaderClient::dispatchCreatePage

2007-02-16 Thread Morgan L
I was wondering if there are any plans to replace FrameLoaderClient::dispatchCreatePage with a call to ChromeClient::createWindow. It seems like FrameLoader::createWindow already calls ChromeClient::CreateWindow, and FrameLoaderClient::dispatchCreatePage is somewhat duplicating ChromeClient::creat

Re: [webkit-dev] Changes to GraphicsContext

2007-01-02 Thread Morgan L
Thanks for the info! Perhaps some of this should be added as comments to GraphicsContext.h? --morganl David Hyatt <[EMAIL PROTECTED]> wrote: I changed how the graphics context works today to avoid updating CoreGraphics's fill and stroke colors in every drawGlyphs call. Basically I chang

Re: [webkit-dev] WebCore/platform directory

2006-12-08 Thread Morgan L
example, you could declare the "d" in an #else section if the MAC platform version were entirely implemented w/o use of d-pointer. -- morgan - Original Message From: Maciej Stachowiak <[EMAIL PROTECTED]> To: Morgan L <[EMAIL PROTECTED]> Cc: Sebastien Roret <[EMAI

Re: [webkit-dev] WebCore/platform directory

2006-12-07 Thread Morgan L
middle ground to be had :-) -- morgan - Original Message From: Sebastien Roret <[EMAIL PROTECTED]> To: Morgan L <[EMAIL PROTECTED]>; webkit-dev@lists.webkit.org Sent: Thursday, December 7, 2006 2:58:57 AM Subject: Re: [webkit-dev] WebCore/platform directory Hi Morgan, On 12/

Re: [webkit-dev] WebCore/platform directory

2006-12-06 Thread Morgan L
Hi, I don't speak for the WebKit developers, but I'm also interested in WebKit porting. One bit of feedback that you might find useful: I don't think it is necessary for all of the platform classes to be defined with virtual functions. That would only be necessary if there could be multiple i