Re: [webkit-dev] Ports not building as C++11?
Thanks Anders. I look forward to the changes for our WEC2013 builds! Patrick East | Software Engineer +1 425.519.5912 | patri...@bsquare.com<mailto:patri...@bsquare.com> Bsquare │Forging Smart Connections www.bsquare.com<http://www.bsquare.com/> From: Anders Carlsson [mailto:ander...@apple.com] Sent: Tuesday, July 30, 2013 2:02 PM To: Brent Fulgham Cc: Patrick East; WebKit Development Subject: Re: [webkit-dev] Ports not building as C++11? On Jul 30, 2013, at 10:52 AM, Brent Fulgham mailto:bfulg...@apple.com>> wrote: I realize that CE 5, 6, and 7 are probably not top priorities for the community, but these changes will basically force dropping support for those platforms. We do have some interest in keeping WebKit working for our downstream build, so if it's possible to make this change over to using C++11 in a way that can allow for building without the new features that would be ideal. If there is anything we can do that help make this happen let me know. I think the goal is to (at least initially) conditionalize the use of various C++11 idioms. But I think we will soon reach a critical mass where we will assume the compiler supports the newer language constructs. We're already using C++11 features conditionally in WebKit. The plan is to move forward and make some features a requirement. Patrick, given the broad support for this proposal from other ports/contributors we are going to ahead and move forward with it. Regards, - Anders ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Ports not building as C++11?
Hi Brent, For a ballpark of the market size we have customers with millions of devices, and we believe there are several million other WinCE devices that are also utilizing WebKit. The target platforms do benefit quite a bit having access to the latest builds, nearly all of our customers push for having the latest performance enhancements, features, and bug fixes. Patrick East | Software Engineer +1 425.519.5912 | patri...@bsquare.com<mailto:patri...@bsquare.com> Bsquare │Forging Smart Connections www.bsquare.com<http://www.bsquare.com/> From: Brent Fulgham [mailto:bfulg...@apple.com] Sent: Tuesday, July 30, 2013 10:53 AM To: Patrick East Cc: Anders Carlsson; WebKit Development Subject: Re: [webkit-dev] Ports not building as C++11? Hi Patrick, On Jul 29, 2013, at 10:42 AM, Patrick East mailto:patri...@bsquare.com>> wrote: There is support for C++11 on Windows Embedded Compact 2013 using the newer VC11 compiler, but for CE 5, 6, or WEC 7 they will not be able to support it since they are limited to the VC9 compiler. Afaik there doesn't appear to be any plans from Microsoft to back-port the newer compiler and run time to support older versions of CE. That's too bad. Can you give me an idea of how big a 'market' we are talking about for these older OS releases? Are these targets likely to need or benefit from access to a ToT WebKit build? I realize that CE 5, 6, and 7 are probably not top priorities for the community, but these changes will basically force dropping support for those platforms. We do have some interest in keeping WebKit working for our downstream build, so if it's possible to make this change over to using C++11 in a way that can allow for building without the new features that would be ideal. If there is anything we can do that help make this happen let me know. I think the goal is to (at least initially) conditionalize the use of various C++11 idioms. But I think we will soon reach a critical mass where we will assume the compiler supports the newer language constructs. -Brent ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Ports not building as C++11?
There is support for C++11 on Windows Embedded Compact 2013 using the newer VC11 compiler, but for CE 5, 6, or WEC 7 they will not be able to support it since they are limited to the VC9 compiler. Afaik there doesn’t appear to be any plans from Microsoft to back-port the newer compiler and run time to support older versions of CE. I realize that CE 5, 6, and 7 are probably not top priorities for the community, but these changes will basically force dropping support for those platforms. We do have some interest in keeping WebKit working for our downstream build, so if it’s possible to make this change over to using C++11 in a way that can allow for building without the new features that would be ideal. If there is anything we can do that help make this happen let me know. Thanks! Patrick East | Software Engineer +1 425.519.5912 | patri...@bsquare.com<mailto:patri...@bsquare.com> Bsquare │Forging Smart Connections www.bsquare.com<http://www.bsquare.com/> From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev-boun...@lists.webkit.org] On Behalf Of Brent Fulgham Sent: Saturday, July 27, 2013 3:04 PM To: Anders Carlsson Cc: WebKit Development Subject: Re: [webkit-dev] Ports not building as C++11? The only platform I know cannot support C++11 is WinCE, and that port is in favor of making the move to C++11 in anticipation of updated build tools from Microsoft. What other platform are we talking about here? The GNU compilers have supported C++11 for a long time. -Brent Sent from my iPhone On Jul 26, 2013, at 8:12 PM, Anders Carlsson mailto:ander...@apple.com>> wrote: On Jul 26, 2013, at 8:09 PM, Allan Sandfeld Jensen mailto:k...@carewolf.com>> wrote: On Friday 26 July 2013, Anders Carlsson wrote: Hi everyone, when Oliver landed his “let’s break everything” patches in JSC the other day, I noticed that some of the follow-up build fixes by other ports were removing use of C++11 features (mainly nullptr). Are there any ports that aren’t building as C++11? If so, why not? Yes, and because C++11 is not supported on all the platforms we support. Could you please elaborate? What compilers are you using? We don't all have the option to not care about the platforms of a certain fruit themed vendor's 1 or 2 year old operating systems. I don’t think this comment adds anything constructive. Thanks, - Anders ___ webkit-dev mailing list webkit-dev@lists.webkit.org<mailto:webkit-dev@lists.webkit.org> https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Question about JITStackFrame
We've been working on trying to get SH4 JIT working on another platform that
uses the microsoft compiler. As part of this effort we could really use
someones help in understanding a little of the fundamentals for the JIT
stackframe. We have it partially working right now but there are still a few
pieces we haven't been able to put together. Specifically for the
DEFINE_STUB_FUNCTION functions it looks like it receives the address of
JITStackFrame as the parameter, but I don't know where you are supposed to
setup and pass the stack frame into these DEFINE_STUB_FUNCTION functions.
Just to make sure I'm understanding how this works correctly, is my assessment
below correct?
We have these defines:
#define SETUP_VA_LISTL_ARGS
#define STUB_ARGS_DECLARATION void** args
#define STUB_ARGS (args)
#define STUB_INIT_STACK_FRAME(stackFrame) SETUP_VA_LISTL_ARGS; JITStackFrame&
stackFrame = *reinterpret_cast(STUB_ARGS)
#define STUB_SET_RETURN_ADDRESS(returnAddress) *stackFrame.returnAddressSlot()
= ReturnAddressPtr(returnAddress)
#define STUB_RETURN_ADDRESS *stackFrame.returnAddressSlot()
#define DEFINE_STUB_FUNCTION(rtype, op) extern "C" rtype
JITStubThunked_##op(STUB_ARGS_DECLARATION)
Then we have a function such as this:
DEFINE_STUB_FUNCTION(void, op_end)
{
STUB_INIT_STACK_FRAME(stackFrame);
DEBUGMSG(PRINT_DEBUG,(L"op_end\r\n"));
ScopeChainNode* scopeChain = stackFrame.callFrame->scopeChain();
ASSERT(scopeChain->refCount > 1);
scopeChain->deref();
}
And if we fill in all the macros for the function we end up with something like:
void JITStubThunked_ op_end (void** args)
{
JITStackFrame& stackFrame = *reinterpret_cast(args)
DEBUGMSG(PRINT_DEBUG,(L"op_end\r\n"));
ScopeChainNode* scopeChain = stackFrame.callFrame->scopeChain();
ASSERT(scopeChain->refCount > 1);
scopeChain->deref();
}
So I can see from "JITStackFrame& stackFrame =
*reinterpret_cast( args)" that the args parameter is supposed
to be the address of the JITStackFrame. If my understanding is correct, there
needs to be some assembly code to setup the JITStackFrame before we call this.
How and where is this supposed to be handled?
Any help explaining this would be much appreciated!
Thanks,
Patrick East
patricke@bsquare,com
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] "highlighting" a frame
Thank for the suggestion, I found that using the outline style on a frame and iframe :hover selector only seemed to work on iframes and not frames in a frameset. I've attached a sample that shows the problem, if you're curious to see what happens. If you look at the frameset.html page and mouse over the bottom frame that contains an iframe, the border style is the only one that shows up, and it is on the outermost frame in the frameset gets a border in addition to the iframe. I suspect the behavior we are trying to get isn't really achievable with just the default html.css styling. We are going to look into using the focus ring mechanism as James MacLean suggested earlier. Patrick East patri...@bsquare.com From: Elliott Sprehn [mailto:espr...@google.com] Sent: Monday, July 16, 2012 12:54 PM To: Patrick East Cc: webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] "highlighting" a frame You'll want outline not border for this. From: wjmacl...@google.com [mailto:wjmacl...@google.com] On Behalf Of W. James MacLean Sent: Wednesday, July 11, 2012 1:09 PM To: Patrick East Cc: webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] "highlighting" a frame If you're just looking to draw a border, will the focus rings mechanism suffice? On Mon, Jul 9, 2012 at 10:37 PM, Patrick East mailto:patri...@bsquare.com>> wrote: Hello, We are working on a custom build of WebKit that will "highlight" a frame when the mouse moves over it (the intent is to have it draw a border around it for use with a custom input device). We have tried modifying the webcore html.css file adding in a :hover selector for frame and iframe that sets the border property, but this doesn't work correctly for embedded frames. When we test mousing over them it draws the border on the outer-most frame and not the inner frame which is what I want. Unfortunately I don't know much about the css code in WebKit, so any suggestions on how this could be achieved would be much appreciated. Thanks! Patrick East patri...@bsquare.com<mailto:patri...@bsquare.com> ___ webkit-dev mailing list webkit-dev@lists.webkit.org<mailto:webkit-dev@lists.webkit.org> http://lists.webkit.org/mailman/listinfo/webkit-dev x y z Title: Spatial Navigation Test Cases Spatial Navigation Fun 3x3 Centered Table Test test test test test test test test test test Vertical Sine Test test test test test test test test test test test Increasing sentence length H Ho How How How N How No How Now How Now How Now B How Now Br How Now Bro How Now Brow How Now Brown How Now Brown How Now Brown C How Now Brown Co How Now Brown Cow Split sentence H ow Now Brown Cow Ho w Now Brown Cow How Now Brown Cow How N ow Brown Cow How No w Brown Cow How Now Brown Cow How Now B rown Cow How Now Br own Cow How Now Bro wn Cow How Now Brow n Cow How Now Brown Cow How Now Brown C ow How Now Brown Co w How Now Brown Cow Line Wrap Test Which the following constanst do you like, one is g, one is pi, and the other is e. 3.14 2.71 6.67 _javascript_ Focus/Blur Test When going to any link from the following link, you should see a dialog. Test IFrames DIVs a b c last return. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] "highlighting" a frame
Hello, We are working on a custom build of WebKit that will "highlight" a frame when the mouse moves over it (the intent is to have it draw a border around it for use with a custom input device). We have tried modifying the webcore html.css file adding in a :hover selector for frame and iframe that sets the border property, but this doesn't work correctly for embedded frames. When we test mousing over them it draws the border on the outer-most frame and not the inner frame which is what I want. Unfortunately I don't know much about the css code in WebKit, so any suggestions on how this could be achieved would be much appreciated. Thanks! Patrick East patri...@bsquare.com ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
