[webkit-dev] Commit Queue Love
Independently of the other long thread, I'd like to express my love of the commit queue. It is actually quite a nice feature for someone like myself who is off in a corner. I don't want commit access. I'd rather my changes go through some process like the commit queue to ensure that it doesn't break other people's code or block forward development in some way. It is very frustrating sometimes when your patch is stuck in the commit queue for days. I don't necessarily see that as being caused by the commit queue. That is directly because it isn't getting the love it deserves! :) Being able to go around the commit queue means you can cheat. That seems like something that should be reserved for more severe problems where we know the process used by the commit queue will fail. If committers need some kind of specialized access, maybe they just need a fast track commit queue, a higher priority, or some additional options, so that the policies for building and testing can be uniformly applied while still meeting their needs. -- --Alex Milowski The excellence of grammar as a guide is proportional to the paucity of the inflexions, i.e. to the degree of analysis effected by the language considered. Bertrand Russell in a footnote of Principles of Mathematics ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Commit Queue Love
On Jul 9, 2010, at 3:38 AM, Alex Milowski wrote: Being able to go around the commit queue means you can cheat. That seems like something that should be reserved for more severe problems where we know the process used by the commit queue will fail. That is not how I see it at all. And calling it cheating is quite offensive to me. Just because I want control over when and how my patch is committed is suddenly considered cheating? Some of the glaring reasons I don't use the commit queue have been resolved (svn blame mainly), but the fact that there is no control over when the path lands is my chief reason. Often I need to update Apple's internal bug database when I make a change to WebKit, so I just can't rely on the commit bot to close the bugzilla bug. That means holding a bug open and knowing go back days later when it finally lands to close the internal bug. Other times there are internal deadlines that need to be meet and hours matter. As well as keeping patches that span WebKit and Safari in-sync. So until the commit queue solves these issues, I will keep exercising my right to svn commit and be responsive to problems my commits might bring. But please lets stop calling it cheating. — Timothy Hatcher ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Commit Queue Love
On Fri, Jul 9, 2010 at 3:39 PM, Timothy Hatcher timo...@apple.com wrote: On Jul 9, 2010, at 3:38 AM, Alex Milowski wrote: Being able to go around the commit queue means you can cheat. That seems like something that should be reserved for more severe problems where we know the process used by the commit queue will fail. That is not how I see it at all. And calling it cheating is quite offensive to me. Just because I want control over when and how my patch is committed is suddenly considered cheating? Sorry, that wasn't meant to be offensive. It is going around a process. That said, not everyone has committed to using that process. So, you're right. It isn't cheating. All I'm advocating is using the commit queue much more often. I don't have any control over when my code hits the trunk. Somehow, it all works out in the end. -- --Alex Milowski The excellence of grammar as a guide is proportional to the paucity of the inflexions, i.e. to the degree of analysis effected by the language considered. Bertrand Russell in a footnote of Principles of Mathematics ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Commit Queue Love
On Fri, Jul 9, 2010 at 7:39 AM, Timothy Hatcher timo...@apple.com wrote: Some of the glaring reasons I don't use the commit queue have been resolved (svn blame mainly), but the fact that there is no control over when the path lands is my chief reason. I agree. When my patch has a potential to affect the other parts of WebKit, I have to watch waterfall and commit myself to see all builders pass all the tests so that I can FIX them as needed. I didn't take Alex's post offensive though. Best, Ryosuke Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
