Re: [webkit-dev] Experimental new code reviews

2010-04-27 Thread Andrew Scherkus
Here's the prototype I made during the hackathon that simply uses a bunch of Javascript to make it easier to type up comments: http://ascherkus.appspot.com/bugzilla/index.html I'm not a WebKit reviewer, but from what I gathered during the session there's a lot of copying and pasting involved. I

Re: [webkit-dev] Experimental new code reviews

2010-04-20 Thread Adam Barth
At the risk of inspiring friendly competition, I've turned Andrew's demo into a patch: https://bugs.webkit.org/show_bug.cgi?id=37886 Adam On Tue, Apr 20, 2010 at 12:24 PM, Andrew Scherkus scher...@chromium.org wrote: Here's the prototype I made during the hackathon that simply uses a bunch of

[webkit-dev] Experimental new code reviews

2010-04-19 Thread Ojan Vafai
At the hackathon last Tuesday, a few of us put together mashup style rietveld integration with bugs.webkit.org. It currently requires a chrome extension. We'll integrate properly with bugzilla based on feedback if this seems to be a value add for the project.

Re: [webkit-dev] Experimental new code reviews

2010-04-19 Thread Maciej Stachowiak
I heard another group coded up a different approach to improving reviews - does anyone have a URL for that, so we can compare? Cheers, Maciej On Apr 19, 2010, at 3:35 PM, Ojan Vafai wrote: At the hackathon last Tuesday, a few of us put together mashup style rietveld integration with

Re: [webkit-dev] Experimental new code reviews

2010-04-19 Thread Adam Barth
+scherkus On Mon, Apr 19, 2010 at 4:01 PM, Maciej Stachowiak m...@apple.com wrote: I heard another group coded up a different approach to improving reviews - does anyone have a URL for that, so we can compare? Cheers, Maciej On Apr 19, 2010, at 3:35 PM, Ojan Vafai wrote: At the hackathon

Re: [webkit-dev] Experimental new code reviews

2010-04-19 Thread Ojan Vafai
I don't know if it's up anywhere. The other group's approach adds more directly upon the current review system. I don't think we need to choose one vs. another (at least not in the short term). Not that you were suggesting that. Ojan On Mon, Apr 19, 2010 at 4:06 PM, Adam Barth aba...@webkit.org