[webkit-dev] Renaming WebCore/dom/ClassNames
(https://bugs.webkit.org/show_bug.cgi?id=32250 is the relevant bug) Summary: ClassNames used to be used only for class names, but its behavior meets the requirements for HTML5's strings of space separated tokens. If folks are ok with it, I'd like to rename ClassNames to something more generic so that it is more appropriate to use it for HTML5 features (the only current html5-flavored usage I know of is the one I introduced in HTMLAnchorElementhttp://trac.webkit.org/browser/trunk/WebCore/html/HTMLAnchorElement.cpp?annotate=blamerev=51703#L343 ). I was thinking of renaming it to SpaceSplitString, or AtomicStringList (it's previous name), but I'm not hung up on any particular name. Any thoughts or objections? ~Nate ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Renaming WebCore/dom/ClassNames
On Dec 7, 2009, at 3:33 PM, Nate Chapin wrote: I was thinking of renaming it to SpaceSplitString, or AtomicStringList (it's previous name), but I'm not hung up on any particular name. Renaming seems OK. Of the two I definitely prefer SpaceSplitString. Generally I think we should only use “List” in names of things that have efficient add/remove semantics. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
