Re: [webkit-dev] Add support for CSS3 text-decoration* properties
Hi again, Just to inform I've carefully followed the guidelines from Ryosuke as well as other reviewers, and also people from www-style (regarding blink value). The following patches are now pending review: -webkit-text-decoration-line: https://bugs.webkit.org/show_bug.cgi?id=90959 -webkit-text-decoration-style: https://bugs.webkit.org/show_bug.cgi?id=90958 -webkit-text-decoration-color: https://bugs.webkit.org/show_bug.cgi?id=91638 text-decoration (shorthand as specified in CSS3 spec but also fully backwards-compatible with CSS2.1): https://bugs.webkit.org/show_bug.cgi?id=92000 I kindly ask for review and comments :) Best regards, On Fri, Aug 3, 2012 at 2:01 AM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Aug 2, 2012 at 9:43 PM, Bruno Abinader brunoabina...@gmail.com wrote: On Thu, Aug 2, 2012 at 6:10 PM, Ryosuke Niwa rn...@webkit.org wrote: Does the spec require to return new values in the computed style of text-decoration property without authors specifying new text-decoration properties and values? If not, then using text-decoration property is probably better because it'll only affect those authors who have used new properties and values. - Ryosuke If I got it right you are asking if it is necessary to designate values for all longhand properties from text-decoration. The answer is no, based on what the specification says: This property is a shorthand for setting ‘text-decoration-line’, ‘text-decoration-color’, and ‘text-decoration-style’ in one declaration. Omitted values are set to their initial values. A ‘text-decoration’ declaration that omits both the ‘text-decoration-color’ and ‘text-decoration-style’ values is backwards-compatible with CSS Levels 1 and 2. Speaking about it, I did finished a refactory on the text-decoration property that now becomes a shorthand (thus removing the necessity of having -webkit-text-decoration property), like CSS3 specifies. Though I haven't upstreamed it to Bugzilla yet, it is fully backwards-compatible with previous CSS specifications. I do have, however, a small set of questions to ask before publishing it for review: 1. I had a full layout test run and noticed a few test failures, but not exactly failures. The reason they failed is because the computed style expected something like text-decoration: underline and now it produces text-decoration-line: underline. Is it ok to update the test expectations on these cases? IMO It doesn't makes sense having a shorthand property behaving like a longhand one anymore. We need to be careful here. Computed styles are used in editing and markup generated (including style attribute values) need to be understood properly by old UAs. It's not sufficient that only WebKit with/without your patch can parse it correctly. - Ryosuke -- Bruno de Oliveira Abinader ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Add support for CSS3 text-decoration* properties
On Thu, Aug 2, 2012 at 9:43 PM, Bruno Abinader brunoabina...@gmail.comwrote: On Thu, Aug 2, 2012 at 6:10 PM, Ryosuke Niwa rn...@webkit.org wrote: Does the spec require to return new values in the computed style of text-decoration property without authors specifying new text-decoration properties and values? If not, then using text-decoration property is probably better because it'll only affect those authors who have used new properties and values. - Ryosuke If I got it right you are asking if it is necessary to designate values for all longhand properties from text-decoration. The answer is no, based on what the specification says: This property is a shorthand for setting ‘text-decoration-line’, ‘text-decoration-color’, and ‘text-decoration-style’ in one declaration. Omitted values are set to their initial values. A ‘text-decoration’ declaration that omits both the ‘text-decoration-color’ and ‘text-decoration-style’ values is backwards-compatible with CSS Levels 1 and 2. Speaking about it, I did finished a refactory on the text-decoration property that now becomes a shorthand (thus removing the necessity of having -webkit-text-decoration property), like CSS3 specifies. Though I haven't upstreamed it to Bugzilla yet, it is fully backwards-compatible with previous CSS specifications. I do have, however, a small set of questions to ask before publishing it for review: 1. I had a full layout test run and noticed a few test failures, but not exactly failures. The reason they failed is because the computed style expected something like text-decoration: underline and now it produces text-decoration-line: underline. Is it ok to update the test expectations on these cases? IMO It doesn't makes sense having a shorthand property behaving like a longhand one anymore. We need to be careful here. Computed styles are used in editing and markup generated (including style attribute values) need to be understood properly by old UAs. It's not sufficient that only WebKit with/without your patch can parse it correctly. - Ryosuke ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Add support for CSS3 text-decoration* properties
Hi again, I too think so, but I thought it was a general rule to not make non-prefixed properties follow candidate recommendation strictly. If it is a general consensus that it is ok to accept prefixed keywords, then I'll happily change the implementation to do so :) On Wed, Aug 1, 2012 at 9:53 PM, Maciej Stachowiak m...@apple.com wrote: On Aug 1, 2012, at 4:36 PM, Elliott Sprehn espr...@chromium.org wrote: On Tue, Jul 31, 2012 at 7:35 PM, Bruno Abinader brunoabina...@gmail.com wrote: Hi all :) As suggested by Ojan, I am writing a mail to you about my intention to implement all updated and missing text-decoration* properties from CSS3 spec (currently in development), named below: -webkit-text-decoration ( https://bugs.webkit.org/show_bug.cgi?id=92000 ) CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration Status: Proposed patch / pending review It seems weird to have a prefixed version of text-decoration instead of just making text-decoration allow the new prefixed keywords. What's the reason for having a whole new prefixed property? Making regular text-decoration accept prefixed keywords for the new/unstable tuff sounds like a good approach to me. I too am curious why that is not proposed. - Maciej -- Bruno de Oliveira Abinader ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Add support for CSS3 text-decoration* properties
Hi again, On Thu, Aug 2, 2012 at 6:10 PM, Ryosuke Niwa rn...@webkit.org wrote: Does the spec require to return new values in the computed style of text-decoration property without authors specifying new text-decoration properties and values? If not, then using text-decoration property is probably better because it'll only affect those authors who have used new properties and values. - Ryosuke If I got it right you are asking if it is necessary to designate values for all longhand properties from text-decoration. The answer is no, based on what the specification says: This property is a shorthand for setting ‘text-decoration-line’, ‘text-decoration-color’, and ‘text-decoration-style’ in one declaration. Omitted values are set to their initial values. A ‘text-decoration’ declaration that omits both the ‘text-decoration-color’ and ‘text-decoration-style’ values is backwards-compatible with CSS Levels 1 and 2. Speaking about it, I did finished a refactory on the text-decoration property that now becomes a shorthand (thus removing the necessity of having -webkit-text-decoration property), like CSS3 specifies. Though I haven't upstreamed it to Bugzilla yet, it is fully backwards-compatible with previous CSS specifications. I do have, however, a small set of questions to ask before publishing it for review: 1. I had a full layout test run and noticed a few test failures, but not exactly failures. The reason they failed is because the computed style expected something like text-decoration: underline and now it produces text-decoration-line: underline. Is it ok to update the test expectations on these cases? IMO It doesn't makes sense having a shorthand property behaving like a longhand one anymore. 2. The current WebKit implementation of text-decoration actually parses the blink value, but does nothing with it later. On my implementation I preserved the same behavior, but in order to avoid complex parsing techniques I decided to treat it as a 4th bitwise value of text-decoration-line, which does not contemplates the blink value on the CSS3 specification, but makes no harm since nothing is done with it anyways. Said this, I am going to suggest a change on the CSS3 specification of text-decoration, related to the blink value. But first, we need to ask ourselves if this is really needed, it seems that only Firefox and Opera implements this, and to not implement it satisfies the checkpoint 3.3 of WAI-UAAG ( http://www.w3.org/TR/UAAG/guidelines.html#tech-on-off-blinking-text ). I imagine two scenarios for this: 2.1 Abolish usage of blink value, since the same behavior is achievable with rgba() alpha animation. 2.2 Make blink become a shorthand, not just a valid value inside text-decoration property, so text-property acceptable values become like this: text-decoration-line || text-decoration-style || text-decoration-color || text-decoration-blink Where text-decoration-blink would accept either blink or fixed values, for example. In this approach, text-decoration-blink could be even a shorthand property itself covering more complex instructions like time delay between blinks, whether or not blinking animates or only changes states from visible to hidden, etc. I really ask for feedback on the questions above and appreciate your feedback! Best regards, -- Bruno de Oliveira Abinader ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Add support for CSS3 text-decoration* properties
Hi Ryosuke, Indeed. On the proposed implementation I've assured that the original text-decoration from CSS 2.1 spec remains with exactly same behavior as before (though I've managed to get some shared code to avoid duplication). Layout tests results from my local run points no new failing tests due to these changes so far. As for the editing execCommand, these will be handled later (you can see none of the patches touches any files inside Source/WebCore/editing directory). I know there are some management with CSSPropertyTextDecoration and CSSPropertyWebkitTextDecorationsInEffect going on there, but these stay untouched (in edting) until I acquire more information about -webkit-text-decorations-in-effect usage. On Tue, Jul 31, 2012 at 10:40 PM, Ryosuke Niwa rn...@webkit.org wrote: Please make sure the new text decoration values don't break editing (rich text editing execCommand). In particular, we probably need to update ApplyStyleCommand/EditingStyle to handle -webkit-text-decoration*. On Tue, Jul 31, 2012 at 7:35 PM, Bruno Abinader brunoabina...@gmail.com wrote: Hi all :) As suggested by Ojan, I am writing a mail to you about my intention to implement all updated and missing text-decoration* properties from CSS3 spec (currently in development), named below: -webkit-text-decoration ( https://bugs.webkit.org/show_bug.cgi?id=92000 ) CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration Status: Proposed patch / pending review -webkit-text-decoration-line ( https://bugs.webkit.org/show_bug.cgi?id=90959 ) CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration-line Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration-line Status: Proposed patch / pending review -webkit-text-decoration-style ( https://bugs.webkit.org/show_bug.cgi?id=90958 ) CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration-style Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration-style Status: Proposed patch / pending review -webkit-text-decoration-color ( https://bugs.webkit.org/show_bug.cgi?id=91638 ) CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration-color Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration-color Status: Proposed patch / pending review -webkit-text-decoration-skip ( https://bugs.webkit.org/show_bug.cgi?id=92801 ) CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration-skip Status: Work in progress As each patch touches similar places and sometimes requires previous work, this patch series requires the patches to be reviewed / commited in the same order as described above ( 92000, 90959, 90958, 91638 and 92801 ). The decision to use -webkit- prefix was suggested by Alexis on https://bugs.webkit.org/show_bug.cgi?id=90959#c13 . There is also a suggestion to use a specific flag to enable this feature at compile time, however other CSS3 properties such as text-emphasis, for example, do not use such flags, so I am a bit uncertain about it still. I am really looking forward for comments and review on the proposed patches :) Best regards, -- Bruno de Oliveira Abinader ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev -- Bruno de Oliveira Abinader ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Add support for CSS3 text-decoration* properties
Sure, that's fine. But please make sure not to ship these CSS properties until editing code is properly fixed. On Wed, Aug 1, 2012 at 4:47 AM, Bruno Abinader brunoabina...@gmail.comwrote: Hi Ryosuke, Indeed. On the proposed implementation I've assured that the original text-decoration from CSS 2.1 spec remains with exactly same behavior as before (though I've managed to get some shared code to avoid duplication). Layout tests results from my local run points no new failing tests due to these changes so far. As for the editing execCommand, these will be handled later (you can see none of the patches touches any files inside Source/WebCore/editing directory). I know there are some management with CSSPropertyTextDecoration and CSSPropertyWebkitTextDecorationsInEffect going on there, but these stay untouched (in edting) until I acquire more information about -webkit-text-decorations-in-effect usage. On Tue, Jul 31, 2012 at 10:40 PM, Ryosuke Niwa rn...@webkit.org wrote: Please make sure the new text decoration values don't break editing (rich text editing execCommand). In particular, we probably need to update ApplyStyleCommand/EditingStyle to handle -webkit-text-decoration*. On Tue, Jul 31, 2012 at 7:35 PM, Bruno Abinader brunoabina...@gmail.com wrote: Hi all :) As suggested by Ojan, I am writing a mail to you about my intention to implement all updated and missing text-decoration* properties from CSS3 spec (currently in development), named below: -webkit-text-decoration ( https://bugs.webkit.org/show_bug.cgi?id=92000) CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration Status: Proposed patch / pending review -webkit-text-decoration-line ( https://bugs.webkit.org/show_bug.cgi?id=90959 ) CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration-line Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration-line Status: Proposed patch / pending review -webkit-text-decoration-style ( https://bugs.webkit.org/show_bug.cgi?id=90958 ) CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration-style Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration-style Status: Proposed patch / pending review -webkit-text-decoration-color ( https://bugs.webkit.org/show_bug.cgi?id=91638 ) CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration-color Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration-color Status: Proposed patch / pending review -webkit-text-decoration-skip ( https://bugs.webkit.org/show_bug.cgi?id=92801 ) CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration-skip Status: Work in progress As each patch touches similar places and sometimes requires previous work, this patch series requires the patches to be reviewed / commited in the same order as described above ( 92000, 90959, 90958, 91638 and 92801 ). The decision to use -webkit- prefix was suggested by Alexis on https://bugs.webkit.org/show_bug.cgi?id=90959#c13 . There is also a suggestion to use a specific flag to enable this feature at compile time, however other CSS3 properties such as text-emphasis, for example, do not use such flags, so I am a bit uncertain about it still. I am really looking forward for comments and review on the proposed patches :) Best regards, -- Bruno de Oliveira Abinader ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev -- Bruno de Oliveira Abinader ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Add support for CSS3 text-decoration* properties
On Tue, Jul 31, 2012 at 7:35 PM, Bruno Abinader brunoabina...@gmail.comwrote: Hi all :) As suggested by Ojan, I am writing a mail to you about my intention to implement all updated and missing text-decoration* properties from CSS3 spec (currently in development), named below: -webkit-text-decoration ( https://bugs.webkit.org/show_bug.cgi?id=92000 ) CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration Status: Proposed patch / pending review It seems weird to have a prefixed version of text-decoration instead of just making text-decoration allow the new prefixed keywords. What's the reason for having a whole new prefixed property? - E ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Add support for CSS3 text-decoration* properties
Hi Elliott, On Wed, Aug 1, 2012 at 7:36 PM, Elliott Sprehn espr...@chromium.org wrote: It seems weird to have a prefixed version of text-decoration instead of just making text-decoration allow the new prefixed keywords. What's the reason for having a whole new prefixed property? The rationale is that the CSS3 specification for text-decoration property differs from CSS2.1 one, and since it's still in development it is subject to change. But of course, the way the CSS3 text-decoration spec is defined, it clearly supports the CSS2.1 specification as well. Best regards, -- Bruno de Oliveira Abinader ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Add support for CSS3 text-decoration* properties
On Aug 1, 2012, at 4:36 PM, Elliott Sprehn espr...@chromium.org wrote: On Tue, Jul 31, 2012 at 7:35 PM, Bruno Abinader brunoabina...@gmail.com wrote: Hi all :) As suggested by Ojan, I am writing a mail to you about my intention to implement all updated and missing text-decoration* properties from CSS3 spec (currently in development), named below: -webkit-text-decoration ( https://bugs.webkit.org/show_bug.cgi?id=92000 ) CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration Status: Proposed patch / pending review It seems weird to have a prefixed version of text-decoration instead of just making text-decoration allow the new prefixed keywords. What's the reason for having a whole new prefixed property? Making regular text-decoration accept prefixed keywords for the new/unstable tuff sounds like a good approach to me. I too am curious why that is not proposed. - Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Add support for CSS3 text-decoration* properties
Hi all :) As suggested by Ojan, I am writing a mail to you about my intention to implement all updated and missing text-decoration* properties from CSS3 spec (currently in development), named below: -webkit-text-decoration ( https://bugs.webkit.org/show_bug.cgi?id=92000 ) CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration Status: Proposed patch / pending review -webkit-text-decoration-line ( https://bugs.webkit.org/show_bug.cgi?id=90959 ) CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration-line Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration-line Status: Proposed patch / pending review -webkit-text-decoration-style ( https://bugs.webkit.org/show_bug.cgi?id=90958 ) CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration-style Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration-style Status: Proposed patch / pending review -webkit-text-decoration-color ( https://bugs.webkit.org/show_bug.cgi?id=91638 ) CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration-color Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration-color Status: Proposed patch / pending review -webkit-text-decoration-skip ( https://bugs.webkit.org/show_bug.cgi?id=92801 ) CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration-skip Status: Work in progress As each patch touches similar places and sometimes requires previous work, this patch series requires the patches to be reviewed / commited in the same order as described above ( 92000, 90959, 90958, 91638 and 92801 ). The decision to use -webkit- prefix was suggested by Alexis on https://bugs.webkit.org/show_bug.cgi?id=90959#c13 . There is also a suggestion to use a specific flag to enable this feature at compile time, however other CSS3 properties such as text-emphasis, for example, do not use such flags, so I am a bit uncertain about it still. I am really looking forward for comments and review on the proposed patches :) Best regards, -- Bruno de Oliveira Abinader ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Add support for CSS3 text-decoration* properties
Please make sure the new text decoration values don't break editing (rich text editing execCommand). In particular, we probably need to update ApplyStyleCommand/EditingStyle to handle -webkit-text-decoration*. On Tue, Jul 31, 2012 at 7:35 PM, Bruno Abinader brunoabina...@gmail.comwrote: Hi all :) As suggested by Ojan, I am writing a mail to you about my intention to implement all updated and missing text-decoration* properties from CSS3 spec (currently in development), named below: -webkit-text-decoration ( https://bugs.webkit.org/show_bug.cgi?id=92000 ) CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration Status: Proposed patch / pending review -webkit-text-decoration-line ( https://bugs.webkit.org/show_bug.cgi?id=90959 ) CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration-line Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration-line Status: Proposed patch / pending review -webkit-text-decoration-style ( https://bugs.webkit.org/show_bug.cgi?id=90958 ) CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration-style Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration-style Status: Proposed patch / pending review -webkit-text-decoration-color ( https://bugs.webkit.org/show_bug.cgi?id=91638 ) CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration-color Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration-color Status: Proposed patch / pending review -webkit-text-decoration-skip ( https://bugs.webkit.org/show_bug.cgi?id=92801 ) CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration-skip Status: Work in progress As each patch touches similar places and sometimes requires previous work, this patch series requires the patches to be reviewed / commited in the same order as described above ( 92000, 90959, 90958, 91638 and 92801 ). The decision to use -webkit- prefix was suggested by Alexis on https://bugs.webkit.org/show_bug.cgi?id=90959#c13 . There is also a suggestion to use a specific flag to enable this feature at compile time, however other CSS3 properties such as text-emphasis, for example, do not use such flags, so I am a bit uncertain about it still. I am really looking forward for comments and review on the proposed patches :) Best regards, -- Bruno de Oliveira Abinader ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
