Re: [webkit-dev] Bot watching and Apple bots

2012-04-26 Thread Dominik Röttsches
On 04/26/2012 01:11 AM, Maciej Stachowiak wrote: I think it may help the project overall if we made the buildbot page indicate who's the sheriff/gardner/watcher for any given buildbot. Right now it may be hard to tell who to work with if you caused breakage. Barring actual changes to the

[webkit-dev] Bot watching and Apple bots

2012-04-25 Thread Maciej Stachowiak
Hi everyone, A while back, Apple's WebKit teams instituted a bot watching rotation to try to get the bots for our ports to get and stay green. We've managed to consistently stay around low single digits of failures, but the green doesn't seem to stick. We think some folks in the community may

Re: [webkit-dev] Bot watching and Apple bots

2012-04-25 Thread Adrienne Walker
Hi- This has been on my mind lately too, so I'm happy that you brought it up. I have a couple of questions: Would it be possible to make mac's ews warn about test failures in the same way that chromium-ews does? That's been super helpful for keeping Chromium green. Also, when you say pay

Re: [webkit-dev] Bot watching and Apple bots

2012-04-25 Thread Ryosuke Niwa
On Wed, Apr 25, 2012 at 2:34 PM, Adrienne Walker e...@google.com wrote: Also, when you say pay attention, what level of involvement should we expect for one committer making the bots go red on a port that they are not primarily working on? Should we expect test expectation rebaselining? Patch

Re: [webkit-dev] Bot watching and Apple bots

2012-04-25 Thread Dirk Pranke
On Wed, Apr 25, 2012 at 2:40 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Apr 25, 2012 at 2:34 PM, Adrienne Walker e...@google.com wrote: Also, when you say pay attention, what level of involvement should we expect for one committer making the bots go red on a port that they are not

Re: [webkit-dev] Bot watching and Apple bots

2012-04-25 Thread Ryosuke Niwa
On Wed, Apr 25, 2012 at 2:51 PM, Dirk Pranke dpra...@chromium.org wrote: Given that some people often land changes that break baselines on every bot, and that we clearly don't expect the patch submitter to fix every bot in this situation, how do you square that with what you just wrote?

Re: [webkit-dev] Bot watching and Apple bots

2012-04-25 Thread Ojan Vafai
Good to know. I had stopped paying attention to many of the Apple bots for the reason you mention. It would be really helpful if someone could make the webkit-patch tooling works correctly for the non-Chromium bots. Specifically, webkit-patch rebaseline-test and webkit-patch garden-o-matic. They

Re: [webkit-dev] Bot watching and Apple bots

2012-04-25 Thread Dirk Pranke
On Wed, Apr 25, 2012 at 3:50 PM, Ojan Vafai o...@chromium.org wrote: Good to know. I had stopped paying attention to many of the Apple bots for the reason you mention. It would be really helpful if someone could make the webkit-patch tooling works correctly for the non-Chromium bots.