Re: [webkit-dev] Compile-time assertions for object sizes

2011-09-29 Thread Antti Koivisto
On Thu, Sep 29, 2011 at 9:40 PM, Andreas Kling wrote: > One idea is to add a file that would only be built on (for example) 64-bit > Mac and then at least that bot would break if an object changes size. That's > obviously not ideal though. > I like that approach as it allows you to explicitly as

Re: [webkit-dev] Compile-time assertions for object sizes

2011-09-29 Thread Darin Adler
On Sep 29, 2011, at 1:48 PM, Andreas Kling wrote: > Right, but those keywords would pertain to the struct containing the > bitfields, not InlineBox itself. Or maybe I'm misunderstanding you? Yes, I was wrong, you are right. I had lost the thread. I’m not sure we need to group bit fields in a st

Re: [webkit-dev] Compile-time assertions for object sizes

2011-09-29 Thread Andreas Kling
On Thu, Sep 29, 2011 at 10:43 PM, Darin Adler wrote: > On Sep 29, 2011, at 1:40 PM, Andreas Kling wrote: > > > Good idea in general, though it doesn't work for InlineBox since its bits > are spread across public, protected and private. > > I'm not sure it's worth losing those classifications for

Re: [webkit-dev] Compile-time assertions for object sizes

2011-09-29 Thread Darin Adler
On Sep 29, 2011, at 1:40 PM, Andreas Kling wrote: > Good idea in general, though it doesn't work for InlineBox since its bits are > spread across public, protected and private. > I'm not sure it's worth losing those classifications for the sake of the > anti-bloat mechanism. We wouldn’t have to

Re: [webkit-dev] Compile-time assertions for object sizes

2011-09-29 Thread Andreas Kling
On Thu, Sep 29, 2011 at 9:11 PM, Simon Fraser wrote: > > On Sep 29, 2011, at 11:40 AM, Andreas Kling wrote: > > > Dear WebKittens, > > > > I'd like to add some compile-time assertions for the sizes of various > objects. The motivation comes a patch fixing bloat in InlineBox[1]. > > > > There are t

Re: [webkit-dev] Compile-time assertions for object sizes

2011-09-29 Thread Simon Fraser
On Sep 29, 2011, at 11:40 AM, Andreas Kling wrote: > Dear WebKittens, > > I'd like to add some compile-time assertions for the sizes of various > objects. The motivation comes a patch fixing bloat in InlineBox[1]. > > There are two major problems with this: > > 1. The sizes will differ on 32-

Re: [webkit-dev] Compile-time assertions for object sizes

2011-09-29 Thread David Levin
On Thu, Sep 29, 2011 at 12:11 PM, Simon Fraser wrote: > > On Sep 29, 2011, at 11:40 AM, Andreas Kling wrote: > > > Dear WebKittens, > > > > I'd like to add some compile-time assertions for the sizes of various > objects. The motivation comes a patch fixing bloat in InlineBox[1]. > > > > There are

[webkit-dev] Compile-time assertions for object sizes

2011-09-29 Thread Andreas Kling
Dear WebKittens, I'd like to add some compile-time assertions for the sizes of various objects. The motivation comes a patch fixing bloat in InlineBox[1]. There are two major problems with this: 1. The sizes will differ on 32- and 64-bit platforms. 2. The sizes will differ based on compiler flag