Re: [webkit-dev] Crashes during testing
On Fri, Feb 26, 2010 at 12:03 AM, Oliver Hunt oli...@apple.com wrote: But any regressions would have been blamed on eric. His name would show up in the SVN log, sure, but I don't think that'd fool your average WebKit developer for long. webkit-patch land does the correct thing, but i disable the testing prior to commit because a 25 minute delay prior to committing is more or less guaranteed to cause it to fail to commit due to someone else landing. Did you run the layout tests at all? I generally land with --no-build as well, but only after it's successfully passed at least one build + run of the layout tests. On Feb 25, 2010, at 2:58 PM, Kenneth Russell wrote: OK, thanks, that appears to have fixed it. How about that commit queue? Would have caught the crashes before they were checked in. -Ken On Thu, Feb 25, 2010 at 2:53 PM, Oliver Hunt oli...@apple.com wrote: Update to r55258 or later :D --Oliver On Feb 25, 2010, at 2:46 PM, Kenneth Russell wrote: A change committed some time since yesterday evening has introduced many crashes in JSC's GC during testing. A representative stack trace is attached. If you have made changes in this area recently, can you please look into this? Thanks, -Ken crash.txt___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Crashes during testing
Personally, I've found those kind of changes are responsible for a disproportionate percentage of build errors and bugs. :-) On Fri, Feb 26, 2010 at 5:16 PM, Darin Adler da...@apple.com wrote: On Feb 26, 2010, at 1:42 AM, Jeremy Orlow wrote: Did you run the layout tests at all? Oliver already said that he did, but before he made the small last minute change that caused the crash. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Crashes during testing
A change committed some time since yesterday evening has introduced many crashes in JSC's GC during testing. A representative stack trace is attached. If you have made changes in this area recently, can you please look into this? Thanks, -Ken Thread 0 Crashed: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore0x000100936478 JSC::WeakGCPtrJSC::JSPropertyNameIterator::clear(JSC::JSCell*) + 16 (WeakGCPtr.h:49) 1 com.apple.JavaScriptCore0x0001009364af JSC::Structure::clearEnumerationCache(JSC::JSPropertyNameIterator*) + 33 (JSPropertyNameIterator.h:100) 2 com.apple.JavaScriptCore0x0001009362cf JSC::JSPropertyNameIterator::~JSPropertyNameIterator() + 51 (JSPropertyNameIterator.cpp:53) 3 com.apple.JavaScriptCore0x00010087db50 JSC::Heap::sweep() + 224 (Collector.cpp:1086) 4 com.apple.JavaScriptCore0x00010087f548 JSC::Heap::collectAllGarbage() + 108 (Collector.cpp:1281) 5 com.apple.WebCore 0x0001011d8690 WebCore::collect(void*) + 44 (GCController.cpp:47) 6 com.apple.WebCore 0x0001011d86da WebCore::GCController::gcTimerFired(WebCore::TimerWebCore::GCController*) + 26 (GCController.cpp:70) 7 com.apple.WebCore 0x0001011d874d WebCore::TimerWebCore::GCController::fired() + 113 (Timer.h:98) 8 com.apple.WebCore 0x000101923286 WebCore::ThreadTimers::sharedTimerFiredInternal() + 208 (ThreadTimers.cpp:115) 9 com.apple.WebCore 0x000101923415 WebCore::ThreadTimers::sharedTimerFired() + 25 (ThreadTimers.cpp:91) 10 com.apple.WebCore 0x0001017eb178 WebCore::timerFired(__CFRunLoopTimer*, void*) + 73 (SharedTimerMac.mm:87) 11 com.apple.CoreFoundation0x7fff887eca58 __CFRunLoopRun + 6488 12 com.apple.CoreFoundation0x7fff887eac2f CFRunLoopRunSpecific + 575 13 com.apple.HIToolbox 0x7fff868cea4e RunCurrentEventLoopInMode + 333 14 com.apple.HIToolbox 0x7fff868ce853 ReceiveNextEventCommon + 310 15 com.apple.HIToolbox 0x7fff868ce70c BlockUntilNextEventMatchingListInMode + 59 16 com.apple.AppKit0x7fff8304f1f2 _DPSNextEvent + 708 17 com.apple.AppKit0x7fff8304eb41 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 155 18 com.apple.Safari0x0001ba00 0x1 + 47616 19 com.apple.AppKit0x7fff83014747 -[NSApplication run] + 395 20 com.apple.AppKit0x7fff8300d468 NSApplicationMain + 364 21 com.apple.Safari0x00011a28 0x1 + 6696 ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Crashes during testing
On Feb 25, 2010, at 2:46 PM, Kenneth Russell wrote: A change committed some time since yesterday evening has introduced many crashes in JSC's GC during testing. A representative stack trace is attached. If you have made changes in this area recently, can you please look into this? Thanks, -Ken crash.txt Do you have steps to reproduce? Regards, Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Crashes during testing
My bad, fixing now. --Oliver On Feb 25, 2010, at 2:47 PM, Maciej Stachowiak wrote: On Feb 25, 2010, at 2:46 PM, Kenneth Russell wrote: A change committed some time since yesterday evening has introduced many crashes in JSC's GC during testing. A representative stack trace is attached. If you have made changes in this area recently, can you please look into this? Thanks, -Ken crash.txt Do you have steps to reproduce? Regards, Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Crashes during testing
Update to r55258 or later :D --Oliver On Feb 25, 2010, at 2:46 PM, Kenneth Russell wrote: A change committed some time since yesterday evening has introduced many crashes in JSC's GC during testing. A representative stack trace is attached. If you have made changes in this area recently, can you please look into this? Thanks, -Ken crash.txt___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Crashes during testing
OK, thanks, that appears to have fixed it. How about that commit queue? Would have caught the crashes before they were checked in. -Ken On Thu, Feb 25, 2010 at 2:53 PM, Oliver Hunt oli...@apple.com wrote: Update to r55258 or later :D --Oliver On Feb 25, 2010, at 2:46 PM, Kenneth Russell wrote: A change committed some time since yesterday evening has introduced many crashes in JSC's GC during testing. A representative stack trace is attached. If you have made changes in this area recently, can you please look into this? Thanks, -Ken crash.txt___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Crashes during testing
But any regressions would have been blamed on eric. webkit-patch land does the correct thing, but i disable the testing prior to commit because a 25 minute delay prior to committing is more or less guaranteed to cause it to fail to commit due to someone else landing. --Oliver On Feb 25, 2010, at 2:58 PM, Kenneth Russell wrote: OK, thanks, that appears to have fixed it. How about that commit queue? Would have caught the crashes before they were checked in. -Ken On Thu, Feb 25, 2010 at 2:53 PM, Oliver Hunt oli...@apple.com wrote: Update to r55258 or later :D --Oliver On Feb 25, 2010, at 2:46 PM, Kenneth Russell wrote: A change committed some time since yesterday evening has introduced many crashes in JSC's GC during testing. A representative stack trace is attached. If you have made changes in this area recently, can you please look into this? Thanks, -Ken crash.txt___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Crashes during testing
On Thu, Feb 25, 2010 at 3:03 PM, Oliver Hunt oli...@apple.com wrote: But any regressions would have been blamed on eric. webkit-patch land does the correct thing, but i disable the testing prior to commit because a 25 minute delay prior to committing is more or less guaranteed to cause it to fail to commit due to someone else landing. There are two things we can do to improve that: 1) Make the tests faster. This benefits everyone and should be a side-effect of moving to the new multi-threaded LayoutTest driver. 2) Teach webkit-patch land how commit even if someone committed while it ran. I have an experimental patch for this that I can finish. Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
