Re: [webkit-dev] Including new IETestCenter tests in the LayoutTests
The code we submit in WebKit has to be BSD or LGPL compatible code. (/me remember how hard it is to find real world CSS BSD compatible chunk to write a perf test) I found http://msdn.microsoft.com/en-us/cc300389.aspx then you have to see if that is ok for us. In any case the copyright is Microsoft. On Tue, Feb 14, 2012 at 9:31 PM, Adam Barth aba...@webkit.org wrote: On Tue, Feb 14, 2012 at 3:03 PM, Dave Tharp dth...@codeaurora.org wrote: I am currently looking at the WebKit CSS3 failures on IETestCenter (http://samples.msdn.microsoft.com/ietestcenter/ ). I’m making some progress, and getting ready to submit a patch. I’ve contacted Beth Dakin about my approach on the first patch, and she says I should proceed. As part of the patch, of course I need to submit a passing layout test. This is where a question for the community arises: Presuming it is legal (I have my legal department looking at it), I think it makes sense to bring in the tests verbatim from the IETestCenter site. I do understand that there will likely be some overlap (thus, inefficiency) in coverage, but I think having a complete, identical set of tests will make it easier to verify WebKit’s performance in this test suite. There is a precedent for this: the IETestCenter javascript tests are already present in the LayoutTests tree. Assuming there are no legal barriers, importing the whole test suite would be valuable. The LayoutTests contain a number of test suites developed externally (e.g., acid3, W3C conformance tests). Some of these tests are redundant with other tests, but having the whole test suite as a unit is valuable itself. The alternative is to write new tests or enhance existing tests in the current LayoutTests tree. I’m open to either approach, just need some direction from the team. That path is also fine. I would encourage you to import all of the IE test center CSS tests (assuming it passes legal muster). Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- Alexis Menard (darktears) Software Engineer INdT Recife Brazil ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Including new IETestCenter tests in the LayoutTests
On Feb 15, 2012, at 2:26 AM, Alexis Menard wrote: The code we submit in WebKit has to be BSD or LGPL compatible code. (/me remember how hard it is to find real world CSS BSD compatible chunk to write a perf test) I found http://msdn.microsoft.com/en-us/cc300389.aspx then you have to see if that is ok for us. In any case the copyright is Microsoft. Actually, the license terms for the IETestCenter content itself are here: http://samples.msdn.microsoft.com/ietestcenter/support/copyright.htm This is a BSD-equivalent license. So it should be acceptable to incorporate the tests into the WebKit repository. As Adam mentioned, we are happy to import external test suites wholesale, even if they are not fully passing yet. Regards, Maciej On Tue, Feb 14, 2012 at 9:31 PM, Adam Barth aba...@webkit.org wrote: On Tue, Feb 14, 2012 at 3:03 PM, Dave Tharp dth...@codeaurora.org wrote: I am currently looking at the WebKit CSS3 failures on IETestCenter (http://samples.msdn.microsoft.com/ietestcenter/ ). I’m making some progress, and getting ready to submit a patch. I’ve contacted Beth Dakin about my approach on the first patch, and she says I should proceed. As part of the patch, of course I need to submit a passing layout test. This is where a question for the community arises: Presuming it is legal (I have my legal department looking at it), I think it makes sense to bring in the tests verbatim from the IETestCenter site. I do understand that there will likely be some overlap (thus, inefficiency) in coverage, but I think having a complete, identical set of tests will make it easier to verify WebKit’s performance in this test suite. There is a precedent for this: the IETestCenter javascript tests are already present in the LayoutTests tree. Assuming there are no legal barriers, importing the whole test suite would be valuable. The LayoutTests contain a number of test suites developed externally (e.g., acid3, W3C conformance tests). Some of these tests are redundant with other tests, but having the whole test suite as a unit is valuable itself. The alternative is to write new tests or enhance existing tests in the current LayoutTests tree. I’m open to either approach, just need some direction from the team. That path is also fine. I would encourage you to import all of the IE test center CSS tests (assuming it passes legal muster). Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- Alexis Menard (darktears) Software Engineer INdT Recife Brazil ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Including new IETestCenter tests in the LayoutTests
Greetings, I am currently looking at the WebKit CSS3 failures on IETestCenter (http://samples.msdn.microsoft.com/ietestcenter/ ). I'm making some progress, and getting ready to submit a patch. I've contacted Beth Dakin about my approach on the first patch, and she says I should proceed. As part of the patch, of course I need to submit a passing layout test. This is where a question for the community arises: Presuming it is legal (I have my legal department looking at it), I think it makes sense to bring in the tests verbatim from the IETestCenter site. I do understand that there will likely be some overlap (thus, inefficiency) in coverage, but I think having a complete, identical set of tests will make it easier to verify WebKit's performance in this test suite. There is a precedent for this: the IETestCenter javascript tests are already present in the LayoutTests tree. The alternative is to write new tests or enhance existing tests in the current LayoutTests tree. I'm open to either approach, just need some direction from the team. -Dave Tharp ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Including new IETestCenter tests in the LayoutTests
On Tue, Feb 14, 2012 at 3:03 PM, Dave Tharp dth...@codeaurora.org wrote: I am currently looking at the WebKit CSS3 failures on IETestCenter (http://samples.msdn.microsoft.com/ietestcenter/ ). I’m making some progress, and getting ready to submit a patch. I’ve contacted Beth Dakin about my approach on the first patch, and she says I should proceed. As part of the patch, of course I need to submit a passing layout test. This is where a question for the community arises: Presuming it is legal (I have my legal department looking at it), I think it makes sense to bring in the tests verbatim from the IETestCenter site. I do understand that there will likely be some overlap (thus, inefficiency) in coverage, but I think having a complete, identical set of tests will make it easier to verify WebKit’s performance in this test suite. There is a precedent for this: the IETestCenter javascript tests are already present in the LayoutTests tree. Assuming there are no legal barriers, importing the whole test suite would be valuable. The LayoutTests contain a number of test suites developed externally (e.g., acid3, W3C conformance tests). Some of these tests are redundant with other tests, but having the whole test suite as a unit is valuable itself. The alternative is to write new tests or enhance existing tests in the current LayoutTests tree. I’m open to either approach, just need some direction from the team. That path is also fine. I would encourage you to import all of the IE test center CSS tests (assuming it passes legal muster). Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
