On Aug 2, 2009, at 2:44 AM, Adam Barth wrote:
On Sun, Aug 2, 2009 at 2:09 AM, Darin Adler wrote:
On Aug 2, 2009, at 2:05 AM, Adam Barth wrote:
In any case:
https://bugs.webkit.org/show_bug.cgi?id=27931
I'll have a patch shortly. Please let me know if there are other
call
sites you'd
In this case, we could probably reuse the isNodeSubType from
CodeGeneratorV8.pm
(http://trac.webkit.org/browser/trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm#L337),
which in turn uses FindParentsRecursively from CodeGenerator.pm
(http://trac.webkit.org/browser/trunk/WebCore/bindings/scripts/Cod
On Sun, Aug 2, 2009 at 2:09 AM, Darin Adler wrote:
> On Aug 2, 2009, at 2:05 AM, Adam Barth wrote:
>
>> In any case:
>>
>> https://bugs.webkit.org/show_bug.cgi?id=27931
>>
>> I'll have a patch shortly. Please let me know if there are other call
>> sites you'd like changed.
>
> Thanks! Once you p
On Aug 2, 2009, at 2:05 AM, Adam Barth wrote:
In any case:
https://bugs.webkit.org/show_bug.cgi?id=27931
I'll have a patch shortly. Please let me know if there are other
call sites you'd like changed.
Thanks! Once you pointed out this was not due to a recent change, I
had resolved to
On Sun, Aug 2, 2009 at 1:45 AM, Adam Barth wrote:
> On Sun, Aug 2, 2009 at 1:41 AM, Adam Barth wrote:
>> On Sun, Aug 2, 2009 at 1:13 AM, Darin Adler wrote:
>>> I noticed that many JavaScript binding implementations are now calling the
>>> virtual function scriptExecutionContext on DOM nodes. This s
On Sun, Aug 2, 2009 at 1:41 AM, Adam Barth wrote:
> On Sun, Aug 2, 2009 at 1:13 AM, Darin Adler wrote:
>> I noticed that many JavaScript binding implementations are now calling the
>> virtual function scriptExecutionContext on DOM nodes. This should never be
>> done! That's a virtual function, so i
On Sun, Aug 2, 2009 at 1:13 AM, Darin Adler wrote:
> I noticed that many JavaScript binding implementations are now calling the
> virtual function scriptExecutionContext on DOM nodes. This should never be
> done! That's a virtual function, so it's not as fast as calling document().
> The virtual No
I noticed that many JavaScript binding implementations are now calling
the virtual function scriptExecutionContext on DOM nodes. This should
never be done! That's a virtual function, so it's not as fast as
calling document(). The virtual Node::scriptExecutionContext()
function should be mad
8 matches
Mail list logo