Re: [webkit-dev] Meaning of PLATFORM(MAC) and platform/cocoa?

[Jeremy Moskovich]

On Mon, Jul 5, 2010 at 10:22 PM, Joseph Pecoraro  wrote:

> It seems like a good idea to share as much code as we can between ports
>
> rather than forking files.
>
>
> Absolutely, that was the original reason behind platform/cocoa!
>

Thanks Joe,

I'd really appreciate it if someone could provide some guidelines on the
exact meaning of both of these.  Reading through the bug description and
looking at the code gives a general feeling for the meaning of these but it
would be nice to get an "official" definition of what each represents.

> If a certain file uses Cocoa and is shared between OS X ports (including
> Chromium),
>
> where should the file go?
>
>
> It could be that "cocoa" is a misleading name. We thought of "darwin" at
> the time.
> But putting code in platform/cocoa would be fine if the code is shared. Do
> you
> have a specific example in mind?
>

Yep: https://bugs.webkit.org/show_bug.cgi?id=41398

Best regards,
Jeremy
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Meaning of PLATFORM(MAC) and platform/cocoa?

[Joseph Pecoraro]

> It seems like a good idea to share as much code as we can between ports
> rather than forking files.

Absolutely, that was the original reason behind platform/cocoa!


> To that end, would it be possible for someone to explain the exact meaning
> of PLATFORM(MAC) and the intended use of the platform/cocoa directory?

I added this to allow shared code between PLATFORM(MAC) and
PLATFORM(IPHONE). You can see some of the discussion and original
patches on this bug:
https://bugs.webkit.org/show_bug.cgi?id=35870

Checking the svn history on WebCore/platform/cocoa would give you some
history on it as well.


> If a certain file uses Cocoa and is shared between OS X ports (including 
> Chromium),
> where should the file go?

It could be that "cocoa" is a misleading name. We thought of "darwin" at the 
time.
But putting code in platform/cocoa would be fine if the code is shared. Do you
have a specific example in mind?

- Joe___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] Meaning of PLATFORM(MAC) and platform/cocoa?

[Jeremy Moskovich]

Hi,

It seems like a good idea to share as much code as we can between ports
rather than forking files.

To that end, would it be possible for someone to explain the exact meaning
of PLATFORM(MAC) and the intended use of the
platform/cocoadirectory?

If a certain file uses Cocoa and is shared between OS X ports (including
Chromium), where should the file go?

Thanks and best regards,
Jeremy
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev