Re: [webkit-dev] Misplaced files

2010-08-31 Thread Jeremy Orlow
On Mon, Aug 30, 2010 at 5:17 PM, Darin Fisher da...@chromium.org wrote: On Mon, Aug 30, 2010 at 9:11 AM, Maciej Stachowiak m...@apple.com wrote: On Aug 30, 2010, at 8:36 AM, Darin Fisher wrote: On Mon, Aug 30, 2010 at 12:18 AM, Adam Barth aba...@webkit.org wrote: On Fri, Aug 27, 2010 at

Re: [webkit-dev] Misplaced files

2010-08-31 Thread Yaar Schnitman
Regarding renaming files: The .cpp and .h file names need to correspond with .idl names, which in turn correspond with the interfaces specified in these .idl. The later are standard, user-facing strings. This means that you can't change them without fixing a lot of generation and build rules. If

Re: [webkit-dev] Misplaced files

2010-08-31 Thread Jeremy Orlow
You're talking about the module part of the IDL? Is that even used by anything or specified anywhere? As far as I can tell, the answer is no. On Tue, Aug 31, 2010 at 4:54 PM, Yaar Schnitman y...@chromium.org wrote: Regarding renaming files: The .cpp and .h file names need to correspond with

Re: [webkit-dev] Misplaced files

2010-08-31 Thread Jeremy Orlow
On Tue, Aug 31, 2010 at 5:57 PM, Yaar Schnitman y...@chromium.org wrote: No, the file names. The module part matters when IDLs refer to each other (typedefs and includes) - but these are easy to fix. Can you give an example of what you're talking about? I can't remember seeing anything like

Re: [webkit-dev] Misplaced files

2010-08-30 Thread Adam Barth
On Fri, Aug 27, 2010 at 8:12 PM, Maciej Stachowiak m...@apple.com wrote: Yes. The file-related stuff should all be in one directory, I think. Ok. I moved the files from WebCore/html to WebCore/fileapi. On Aug 27, 2010, at 6:19 PM, Kinuko Yasuda wrote: We have bunch of FileSystem (which is a

Re: [webkit-dev] Misplaced files

2010-08-30 Thread Darin Fisher
On Mon, Aug 30, 2010 at 12:18 AM, Adam Barth aba...@webkit.org wrote: On Fri, Aug 27, 2010 at 8:12 PM, Maciej Stachowiak m...@apple.com wrote: Yes. The file-related stuff should all be in one directory, I think. Ok. I moved the files from WebCore/html to WebCore/fileapi. On Aug 27, 2010,

Re: [webkit-dev] Misplaced files

2010-08-30 Thread Maciej Stachowiak
On Aug 30, 2010, at 8:36 AM, Darin Fisher wrote: On Mon, Aug 30, 2010 at 12:18 AM, Adam Barth aba...@webkit.org wrote: On Fri, Aug 27, 2010 at 8:12 PM, Maciej Stachowiak m...@apple.com wrote: Yes. The file-related stuff should all be in one directory, I think. Ok. I moved the files from

Re: [webkit-dev] Misplaced files

2010-08-30 Thread Kinuko Yasuda
On Mon, Aug 30, 2010 at 12:18 AM, Adam Barth aba...@webkit.org wrote: On Fri, Aug 27, 2010 at 8:12 PM, Maciej Stachowiak m...@apple.com wrote: Yes. The file-related stuff should all be in one directory, I think. Ok. I moved the files from WebCore/html to WebCore/fileapi. On Aug 27, 2010,

[webkit-dev] Misplaced files

2010-08-27 Thread Adam Barth
Looking through WebCore/html I noticed the files below. I'm not sure they belong in WebCore/html because they don't appear to be HTML-specific. Rather, they seem like generic web platform APIs (e.g., they could be exposed to SVG or whatever other markup languages we choose to support in the

Re: [webkit-dev] Misplaced files

2010-08-27 Thread Maciej Stachowiak
On Aug 27, 2010, at 3:55 PM, Adam Barth wrote: Looking through WebCore/html I noticed the files below. I'm not sure they belong in WebCore/html because they don't appear to be HTML-specific. Rather, they seem like generic web platform APIs (e.g., they could be exposed to SVG or whatever

Re: [webkit-dev] Misplaced files

2010-08-27 Thread Dmitry Titov
Considering there are already specific WebCore subdirs for notifications, storage, workers, svg, mathml and others, it seems having a new subdirectory named perhaps 'blob' wouldn't be out of line. There is quite a few of those Blob/File files already... Dmitry On Fri, Aug 27, 2010 at 3:55 PM,

Re: [webkit-dev] Misplaced files

2010-08-27 Thread Adam Barth
On Fri, Aug 27, 2010 at 4:08 PM, Maciej Stachowiak m...@apple.com wrote: On Aug 27, 2010, at 3:55 PM, Adam Barth wrote: Looking through WebCore/html I noticed the files below.  I'm not sure they belong in WebCore/html because they don't appear to be HTML-specific.  Rather, they seem like

Re: [webkit-dev] Misplaced files

2010-08-27 Thread Maciej Stachowiak
On Aug 27, 2010, at 5:15 PM, Adam Barth wrote: On Fri, Aug 27, 2010 at 4:08 PM, Maciej Stachowiak m...@apple.com wrote: On Aug 27, 2010, at 3:55 PM, Adam Barth wrote: Looking through WebCore/html I noticed the files below. I'm not sure they belong in WebCore/html because they don't appear

Re: [webkit-dev] Misplaced files

2010-08-27 Thread Kinuko Yasuda
(Sending from the right address) We have bunch of FileSystem (which is a part of File API) related files in WebCore/storage/. Maybe we should move them to the new directory too? On Fri, Aug 27, 2010 at 6:01 PM, Maciej Stachowiak m...@apple.com wrote: On Aug 27, 2010, at 5:15 PM, Adam Barth

Re: [webkit-dev] Misplaced files

2010-08-27 Thread Maciej Stachowiak
On Aug 27, 2010, at 6:19 PM, Kinuko Yasuda wrote: We have bunch of FileSystem (which is a part of File API) related files in WebCore/storage/. Maybe we should move them to the new directory too? Yes. The file-related stuff should all be in one directory, I think. Regards, Maciej On

Re: [webkit-dev] Misplaced files

2010-08-27 Thread Darin Fisher
On Fri, Aug 27, 2010 at 8:12 PM, Maciej Stachowiak m...@apple.com wrote: On Aug 27, 2010, at 6:19 PM, Kinuko Yasuda wrote: We have bunch of FileSystem (which is a part of File API) related files in WebCore/storage/. Maybe we should move them to the new directory too? Yes. The