Re: [webkit-dev] PSA: WebKit2 and DrawingAreaImpl
On Oct 2, 2013, at 10:28 AM, Brent Fulgham wrote: > Hi Anders, > > On Oct 1, 2013, at 6:19 PM, Anders Carlsson wrote: > >> I just wanted to let everyone know that we (Apple) are moving away from >> DrawingAreaImpl and always using our tiled drawing area. Longer term we’d >> like to remove DrawingAreaImpl completely since it was designed back when we >> didn’t run in accelerated compositing mode all the time. > > I believe that this only effects WebKit2, correct? If so, this will have no > impact on the Windows port or the WinCairo port. > Yup, it’s WebKit2 only. - Anders ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] PSA: WebKit2 and DrawingAreaImpl
On Wed, Oct 02, 2013 at 09:49:23AM -0700, Anders Carlsson wrote: > > On Oct 1, 2013, at 11:29 PM, Sergio Villar Senin wrote: > > > On 02/10/13 03:19, Anders Carlsson wrote: > >> Hello, > >> > >> I just wanted to let everyone know that we (Apple) are moving away from > >> DrawingAreaImpl and always using our tiled drawing area. Longer term > >> we’d like to remove DrawingAreaImpl completely since it was designed > >> back when we didn’t run in accelerated compositing mode all the time. > >> > >> It’s my understanding that all the other non-mac ports use coordinated > >> graphics now, and so the logical step would be to create a special > >> DrawingArea subclass for coordinated graphics and move the relevant > >> code there. That’d allow us to remove DrawingAreaImpl and > >> LayerTreeHost. > > > > GTK is not using coordinated graphics, we do WebProcess compositing. > > I see. Are you ever not in accelerated composited mode? > Yes, we do enter accelerated composited mode when required, it is not activated all the time. I did not check that code in quite some time but we had planned to try a tiled solution at some point, we just did not have the time to do it up until now, your proposal is a good excuse to push the task. Regarding activating accelerated compositing all the time we will have to check if we have any users that would care about it, considering this is not going to happen tomorrow we can start with work and on the process check if we should add something. Please add me to any of the bugs you open and I'll try to check the code to help with that. Thanks for the heads up. Alex ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] PSA: WebKit2 and DrawingAreaImpl
On 02/10/13 18:49, Anders Carlsson wrote: > > On Oct 1, 2013, at 11:29 PM, Sergio Villar Senin wrote: > >> On 02/10/13 03:19, Anders Carlsson wrote: >>> Hello, >>> >>> I just wanted to let everyone know that we (Apple) are moving away from >>> DrawingAreaImpl and always using our tiled drawing area. Longer term we’d >>> like to remove DrawingAreaImpl completely since it was designed back when >>> we didn’t run in accelerated compositing mode all the time. >>> >>> It’s my understanding that all the other non-mac ports use coordinated >>> graphics now, and so the logical step would be to create a special >>> DrawingArea subclass for coordinated graphics and move the relevant code >>> there. That’d allow us to remove DrawingAreaImpl and LayerTreeHost. >> >> GTK is not using coordinated graphics, we do WebProcess compositing. > > I see. Are you ever not in accelerated composited mode? I think Martin Robinson is the one to ask here but AFAIK we're always in AC mode unless some error occurs, like if we're unable to create the GL context. Oh, and I think AC is not working either when running WK2 in Wayland. BR ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] PSA: WebKit2 and DrawingAreaImpl
Hi Anders, On Oct 1, 2013, at 6:19 PM, Anders Carlsson wrote: > I just wanted to let everyone know that we (Apple) are moving away from > DrawingAreaImpl and always using our tiled drawing area. Longer term we’d > like to remove DrawingAreaImpl completely since it was designed back when we > didn’t run in accelerated compositing mode all the time. I believe that this only effects WebKit2, correct? If so, this will have no impact on the Windows port or the WinCairo port. Thanks, -Brent ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] PSA: WebKit2 and DrawingAreaImpl
On Oct 1, 2013, at 11:29 PM, Sergio Villar Senin wrote: > On 02/10/13 03:19, Anders Carlsson wrote: >> Hello, >> >> I just wanted to let everyone know that we (Apple) are moving away from >> DrawingAreaImpl and always using our tiled drawing area. Longer term we’d >> like to remove DrawingAreaImpl completely since it was designed back when we >> didn’t run in accelerated compositing mode all the time. >> >> It’s my understanding that all the other non-mac ports use coordinated >> graphics now, and so the logical step would be to create a special >> DrawingArea subclass for coordinated graphics and move the relevant code >> there. That’d allow us to remove DrawingAreaImpl and LayerTreeHost. > > GTK is not using coordinated graphics, we do WebProcess compositing. I see. Are you ever not in accelerated composited mode? - Anders ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] PSA: WebKit2 and DrawingAreaImpl
Thanks for the heads up, Anders I've created a bug for this, https://bugs.webkit.org/show_bug.cgi?id=122207 On Wed, Oct 2, 2013 at 3:19 AM, Anders Carlsson wrote: > Hello, > > I just wanted to let everyone know that we (Apple) are moving away from > DrawingAreaImpl and always using our tiled drawing area. Longer term we’d > like to remove DrawingAreaImpl completely since it was designed back when > we didn’t run in accelerated compositing mode all the time. > > It’s my understanding that all the other non-mac ports use coordinated > graphics now, and so the logical step would be to create a special > DrawingArea subclass for coordinated graphics and move the relevant code > there. That’d allow us to remove DrawingAreaImpl and LayerTreeHost. > > I’d be more than happy to review any patches to do this, and answer any > questions. > > Thanks, > - Anders > > > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] PSA: WebKit2 and DrawingAreaImpl
On 02/10/13 03:19, Anders Carlsson wrote: > Hello, > > I just wanted to let everyone know that we (Apple) are moving away from > DrawingAreaImpl and always using our tiled drawing area. Longer term we’d > like to remove DrawingAreaImpl completely since it was designed back when we > didn’t run in accelerated compositing mode all the time. > > It’s my understanding that all the other non-mac ports use coordinated > graphics now, and so the logical step would be to create a special > DrawingArea subclass for coordinated graphics and move the relevant code > there. That’d allow us to remove DrawingAreaImpl and LayerTreeHost. GTK is not using coordinated graphics, we do WebProcess compositing. BR ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] PSA: WebKit2 and DrawingAreaImpl
Hello, I just wanted to let everyone know that we (Apple) are moving away from DrawingAreaImpl and always using our tiled drawing area. Longer term we’d like to remove DrawingAreaImpl completely since it was designed back when we didn’t run in accelerated compositing mode all the time. It’s my understanding that all the other non-mac ports use coordinated graphics now, and so the logical step would be to create a special DrawingArea subclass for coordinated graphics and move the relevant code there. That’d allow us to remove DrawingAreaImpl and LayerTreeHost. I’d be more than happy to review any patches to do this, and answer any questions. Thanks, - Anders ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
